perf probe: Introduce --no-advice option when a new event is created
PATCH 1/1 perf probe: Introduce --no-advice option when a new event is created
This patch introduces a new option namely "--no-advice" to be used with the add command. Now one has the ability to avoid the generation of any advice when a new event is created. Thus making the output reasonable. For example:
# perf probe --no-advice --add 'user_path_at%return return=$retval:s32'
Added new event:
probe:user_path_at__return (on user_path_at%return with return=$retval:s32)
#--- tools/perf/builtin-probe.c | 4 +++- tools/perf/util/probe-event.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-)
tools/perf/builtin-probe.c +3 -1
@@ -391,7 +391,7 @@ static int perf_add_probe_events(struct perf_probe_event *pevs, int npevs) }/* Note that it is possible to skip all events because of blacklist */ -if (event) { +if (event && !probe_conf.no_advice) {#ifndef HAVE_LIBTRACEEVENT pr_info ("\nperf is not linked with libtraceevent, to use the new probe you can use tracefs:\n\n" );pr_info ("\tcd /sys/kernel/tracing/\n" );
@@ -577,6 +577,8 @@ __cmd_probe(int argc, const char **argv) "directory", "path to kernel source"),OPT_BOOLEAN ('\0' ,"no-inlines" , &probe_conf.no_inlines,"Don't search inlined functions" ), +OPT_BOOLEAN ('\0' ,"no-advice" , &probe_conf.no_advice, +"Don't provide any advice after a new event is created." ),OPT__DRY_RUN (&probe_event_dry_run),OPT_INTEGER ('\0' ,"max-probes" , &probe_conf.max_probes, "Set how many probe points can be found for a probe."),
tools/perf/util/probe-event.h +1 -0
@@ -14,6 +14,7 @@ struct probe_conf {bool show_location_range;bool force_add;bool no_inlines; +bool no_advice;bool cache;bool bootconfig;int max_probes;
Signature · 1 line
2.47.1
Namhyung Kim
maintainerHello,
Sorry for the late reply.
Quoted 9 lines · Aaron Tomlin
This patch introduces a new option namely "--no-advice" to be used with the add command. Now one has the ability to avoid the generation of any advice when a new event is created. Thus making the output reasonable. For example:
# perf probe --no-advice --add 'user_path_at%return return=$retval:s32' Added new event: probe:user_path_at__return (on user_path_at%return with return=$retval:s32) #
Thanks for sending the patch but why do you care? You can just ignore the message.
Thanks,
Namhyung
Quoted 44 lines
Signed-off-by Aaron Tomlin <[email protected]>--- tools/perf/builtin-probe.c | 4 +++- tools/perf/util/probe-event.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-)tools/perf/builtin-probe.c +3
-1@@ -391,7 +391,7 @@ static int perf_add_probe_events(struct perf_probe_event *pevs, int npevs) }/* Note that it is possible to skip all events because of blacklist */ -if (event) { +if (event && !probe_conf.no_advice) {#ifndef HAVE_LIBTRACEEVENT pr_info ("\nperf is not linked with libtraceevent, to use the new probe you can use tracefs:\n\n" );pr_info ("\tcd /sys/kernel/tracing/\n" );@@ -577,6 +577,8 @@ __cmd_probe(int argc, const char **argv) "directory", "path to kernel source"),OPT_BOOLEAN ('\0' ,"no-inlines" , &probe_conf.no_inlines,"Don't search inlined functions" ), +OPT_BOOLEAN ('\0' ,"no-advice" , &probe_conf.no_advice, +"Don't provide any advice after a new event is created." ),OPT__DRY_RUN (&probe_event_dry_run),OPT_INTEGER ('\0' ,"max-probes" , &probe_conf.max_probes, "Set how many probe points can be found for a probe."),tools/perf/util/probe-event.h +1
-0@@ -14,6 +14,7 @@ struct probe_conf {bool show_location_range;bool force_add;bool no_inlines; +bool no_advice;bool cache;bool bootconfig;int max_probes;Signature · 1 line
2.47.1
Quoted 1 line · Namhyung Kim
Hello,
Hi Namhyung,
Quoted 1 line
Sorry for the late reply.
No problem at all.
Quoted 6 lines · Aaron Tomlin
Quoted 5 lines
This patch introduces a new option namely "--no-advice" to be used with the add command. Now one has the ability to avoid the generation of any advice when a new event is created. Thus making the output reasonable. For example:
Quoted 7 lines
Quoted 4 lines
# perf probe --no-advice --add 'user_path_at%return return=$retval:s32' Added new event: probe:user_path_at__return (on user_path_at%return with return=$retval:s32) #Thanks for sending the patch but why do you care? You can just ignore the message.
I understand.
As a frequent and avid perf-probe user, I often only need to confirm the successful creation of a new event, ensuring its presence under /sys/kernel/debug/tracing/events/probes for subsequent use with Ftrace. The ability to suppress verbose output would be a valuable enhancement.
Please let me know your thoughts.
Kind regards,
Signature · 1 line
Aaron Tomlin
Namhyung Kim
maintainerQuoted 23 lines · Aaron Tomlin
Quoted 1 line · Namhyung Kim
Hello,
Hi Namhyung,
Quoted 1 line
Sorry for the late reply.
No problem at all.
Quoted 6 lines · Aaron Tomlin
Quoted 5 lines
This patch introduces a new option namely "--no-advice" to be used with the add command. Now one has the ability to avoid the generation of any advice when a new event is created. Thus making the output reasonable. For example:
Quoted 7 lines
Quoted 4 lines
# perf probe --no-advice --add 'user_path_at%return return=$retval:s32' Added new event: probe:user_path_at__return (on user_path_at%return with return=$retval:s32) #Thanks for sending the patch but why do you care? You can just ignore the message.
Quoted 8 lines
I understand.
As a frequent and avid perf-probe user, I often only need to confirm the successful creation of a new event, ensuring its presence under
/sys/kernel/debug/tracing/events/probesfor subsequent use with Ftrace. The ability to suppress verbose output would be a valuable enhancement.Please let me know your thoughts.
Sounds like you may want -q option to suppress all output and check the exit code of the command.
Thanks,
Namhyung
Quoted 2 lines · Namhyung Kim
Sounds like you may want -q option to suppress all output and check the exit code of the command.
Hi Namhyung,
I will prepare another patch.
Signature · 1 line
Aaron Tomlin
cover perf probe: Extend the quiet option
In reply to Namhyung KimHi Namhyung,
Apologies for the delay. I suspect this is the idea you had in mind?
Aaron Tomlin (1):
perf probe: Extend the quiet option
tools/perf/builtin-probe.c | 16 +++++++++++----- tools/perf/util/probe-event.h | 1 + 2 files changed, 12 insertions(+), 5 deletions(-)
Signature · 1 line
2.47.1
PATCH 1/1 perf probe: Extend the quiet option
In reply to Namhyung KimTo provide a consistent and complete quiet mode, this patch expands the scope of the [-q|--quiet] option to suppress all informational messages, including those indicating successful event creation, in addition to the currently suppressed warnings and messages. For example:
❯ sudo ./perf probe --quiet --add proc_sys_open
❯ echo $?
0--- tools/perf/builtin-probe.c | 16 +++++++++++----- tools/perf/util/probe-event.h | 1 + 2 files changed, 12 insertions(+), 5 deletions(-)
tools/perf/builtin-probe.c +11 -5
@@ -391,7 +391,7 @@ static int perf_add_probe_events(struct perf_probe_event *pevs, int npevs) }/* Note that it is possible to skip all events because of blacklist */ -if (event) { +if (event && !probe_conf.quiet) {#ifndef HAVE_LIBTRACEEVENT pr_info ("\nperf is not linked with libtraceevent, to use the new probe you can use tracefs:\n\n" );pr_info ("\tcd /sys/kernel/tracing/\n" );
@@ -467,8 +467,11 @@ static int perf_del_probe_events(struct strfilter *filter) ret =probe_file__get_events (kfd, filter, klist);if (ret ==0 ) { -strlist__for_each_entry (ent, klist) +strlist__for_each_entry (ent, klist) { +if (probe_conf.quiet) +continue ;pr_info ("Removed event: %s\n" , ent->s); + } ret =probe_file__del_strlist (kfd, klist);if (ret <0 )
@@ -478,8 +481,11 @@ static int perf_del_probe_events(struct strfilter *filter) ret2 =probe_file__get_events (ufd, filter, ulist);if (ret2 ==0 ) { -strlist__for_each_entry (ent, ulist) +strlist__for_each_entry (ent, ulist) { +if (probe_conf.quiet) +continue ;pr_info ("Removed event: %s\n" , ent->s); + } ret2 =probe_file__del_strlist (ufd, ulist);if (ret2 <0 )
@@ -531,7 +537,7 @@ __cmd_probe(int argc, const char **argv)struct option options[] = {OPT_INCR ('v' ,"verbose" , &verbose,"be more verbose (show parsed arguments, etc)" ), -OPT_BOOLEAN ('q' ,"quiet" , &quiet, +OPT_BOOLEAN ('q' ,"quiet" , &probe_conf.quiet,"be quiet (do not show any warnings or messages)" ), OPT_CALLBACK_DEFAULT('l', "list", NULL, "[GROUP:]EVENT", "list up probe events",
@@ -631,7 +637,7 @@ __cmd_probe(int argc, const char **argv) argc =parse_options (argc, argv, options, probe_usage,PARSE_OPT_STOP_AT_NON_OPTION ); -if (quiet) { +if (probe_conf.quiet) {if (verbose !=0 ) {pr_err (" Error: -v and -q are exclusive.\n" );return -EINVAL ;
tools/perf/util/probe-event.h +1 -0
@@ -10,6 +10,7 @@ struct nsinfo;/* Probe related configurations */ struct probe_conf { +bool quiet;bool show_ext_vars;bool show_location_range;bool force_add;
Signature · 1 line
2.47.1
A message that is not in the archive (sent off-list or not yet received): CA+JHD92anFo9rNOZ8NVyY4j23ukyWO-LRroHfUTnuOLnL-05-g@mail.gmail.com
Quoted 8 lines · Arnaldo Carvalho de Melo
Consider setting it via 'perf config', see a recent patch I sent for the wall clock profiling feature, it would be something like:
perf config probe.quiet=true
https://lore.kernel.org/lkml/Z4akewi7UPXpagce@x1/
- Arnaldo
Thank you Arnaldo.
Signature · 1 line
Aaron Tomlin