Skip to contentSkip to conversation

fs/btrfs/super.c:2482 btrfs_print_mod_info() warn: inconsistent indenting

PATCH kernel test robot 2 participants 2 messages Dec 16, 2024 – Dec 17, 2024

lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e25c8d66f6786300b680866c0e0139981273feba
commit: 286dd5a60b7114fb8fdcabdccd01598161f67d83 [3606/4379] btrfs: modload to print RAID1 balancing status
config: i386-randconfig-141-20241216 (https://download.01.org/0day-ci/archive/20241217/[email protected]/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

smatch warnings:
fs/btrfs/super.c:2482 btrfs_print_mod_info() warn: inconsistent indenting

vim +2482 fs/btrfs/super.c

2445
2446 static int __init btrfs_print_mod_info(void)
2447 {
2448 static const char options[] = ""
2449 #ifdef CONFIG_BTRFS_DEBUG
2450 ", debug=on"
2451 #endif
2452 #ifdef CONFIG_BTRFS_ASSERT
2453 ", assert=on"
2454 #endif
2455 #ifdef CONFIG_BTRFS_FS_REF_VERIFY
2456 ", ref-verify=on"
2457 #endif
2458 #ifdef CONFIG_BLK_DEV_ZONED
2459 ", zoned=yes"
2460 #else
2461 ", zoned=no"
2462 #endif
2463 #ifdef CONFIG_FS_VERITY
2464 ", fsverity=yes"
2465 #else
2466 ", fsverity=no"
2467 #endif
2468 #ifdef CONFIG_BTRFS_EXPERIMENTAL
2469 ", experimental=yes"
2470 #else
2471 ", experimental=no"
2472 #endif
2473 ;
2474
2475 #ifdef CONFIG_BTRFS_EXPERIMENTAL
2476 if (btrfs_get_raid1_balancing() == NULL)
2477 pr_info("Btrfs loaded%s\n", options);
2478 else
2479 pr_info("Btrfs loaded%s, raid1_balancing=%s\n",
2480 options, btrfs_get_raid1_balancing());
2481 #else

> 2482			pr_info("Btrfs loaded%s\n", options);

2483 #endif
2484
2485 return 0;
2486 }
2487

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#1 lore raw

Thanks for the report.

Fixed in

https://lore.kernel.org/linux-btrfs/[email protected]/T/#mb80a020c62bdf298bae160937a1db9e84a416d5e

-Anand

Quoted 60 lines · kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e25c8d66f6786300b680866c0e0139981273feba
commit: 286dd5a60b7114fb8fdcabdccd01598161f67d83 [3606/4379] btrfs: modload to print RAID1 balancing status
config: i386-randconfig-141-20241216 (https://download.01.org/0day-ci/archive/20241217/[email protected]/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

smatch warnings:
fs/btrfs/super.c:2482 btrfs_print_mod_info() warn: inconsistent indenting

vim +2482 fs/btrfs/super.c

   2445	
   2446	static int __init btrfs_print_mod_info(void)
   2447	{
   2448		static const char options[] = ""
   2449	#ifdef CONFIG_BTRFS_DEBUG
   2450				", debug=on"
   2451	#endif
   2452	#ifdef CONFIG_BTRFS_ASSERT
   2453				", assert=on"
   2454	#endif
   2455	#ifdef CONFIG_BTRFS_FS_REF_VERIFY
   2456				", ref-verify=on"
   2457	#endif
   2458	#ifdef CONFIG_BLK_DEV_ZONED
   2459				", zoned=yes"
   2460	#else
   2461				", zoned=no"
   2462	#endif
   2463	#ifdef CONFIG_FS_VERITY
   2464				", fsverity=yes"
   2465	#else
   2466				", fsverity=no"
   2467	#endif
   2468	#ifdef CONFIG_BTRFS_EXPERIMENTAL
   2469				", experimental=yes"
   2470	#else
   2471				", experimental=no"
   2472	#endif
   2473				;
   2474	
   2475	#ifdef CONFIG_BTRFS_EXPERIMENTAL
   2476		if (btrfs_get_raid1_balancing() == NULL)
   2477			pr_info("Btrfs loaded%s\n", options);
   2478		else
   2479			pr_info("Btrfs loaded%s, raid1_balancing=%s\n",
   2480				 options, btrfs_get_raid1_balancing());
   2481	#else
Quoted 1 line

2482 pr_info("Btrfs loaded%s\n", options);

2483 #endif
2484

   2485		return 0;
   2486	}
   2487