Skip to contentSkip to conversation

firmware: cs_dsp: Fix endianness conversion in cs_dsp_mock_wmfw.c

PATCH In review Richard Fitzgerald 2 participants 2 messages Dec 17, 2024

Subsystems (2)
lore
Share & tools
lore

Richard Fitzgerald

author maintainer
#0 lore raw

PATCH 1/1 firmware: cs_dsp: Fix endianness conversion in cs_dsp_mock_wmfw.c

In cs_dsp_mock_wmfw_add_coeff_desc() the value stored in longstring->len needs a cpu_to_le16() conversion.

Fixes 5cf1b7b47180 ("firmware: cs_dsp: Add mock wmfw file generator for KUnit testing")
---
 drivers/firmware/cirrus/test/cs_dsp_mock_wmfw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/cirrus/test/cs_dsp_mock_wmfw.c +1 -1
index d3d84da239a3..5a3ac03ac37f 100644
@@ -334,7 +334,7 @@ void cs_dsp_mock_wmfw_add_coeff_desc(struct cs_dsp_mock_wmfw_builder *builder,
 				  sizeof(*ple32)) / sizeof(*ple32);
 
 		longstring = (__force struct wmfw_long_string *)ple32;
-		longstring->len = description_len;
+		longstring->len = cpu_to_le16(description_len);
 		memcpy(longstring->data, def->description, description_len);
 
 		/* Round up to next __le32 multiple */
Signature · 1 line
2.39.5
#1 lore raw
Quoted 4 lines · Richard Fitzgerald

In cs_dsp_mock_wmfw_add_coeff_desc() the value stored in longstring->len needs a cpu_to_le16() conversion.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] firmware: cs_dsp: Fix endianness conversion in cs_dsp_mock_wmfw.c

      commit: 644115e86023fccdaecb1318133ed14418b76f49

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark