Skip to contentSkip to conversation

pinctrl-tegra: Add config property GPIO mode

PATCH In review Prathamesh Shete 3 participants 5 messages Dec 17, 2024 – Feb 28, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 pinctrl-tegra: Add config property GPIO mode

The SFIO/GPIO select bit is a crucial part of Tegra's pin multiplexing system:
- When set to 1, the pin operates in SFIO mode, controlled by the pin's assigned special function.
- When set to 0, the pin operates as a general-purpose GPIO.

This SFIO/GPIO select bit that is set for a given pin is not displayed, adding the support to retrieve this information from the pinmux set for each pin.

---
 drivers/pinctrl/tegra/pinctrl-tegra.c | 11 +++++++++++
 drivers/pinctrl/tegra/pinctrl-tegra.h |  2 ++
 2 files changed, 13 insertions(+)
drivers/pinctrl/tegra/pinctrl-tegra.c +11 -0
index 9523b93008d0..46728f19fa8e 100644
@@ -96,6 +96,7 @@ static const struct cfg_param {
 	{"nvidia,slew-rate-falling",	TEGRA_PINCONF_PARAM_SLEW_RATE_FALLING},
 	{"nvidia,slew-rate-rising",	TEGRA_PINCONF_PARAM_SLEW_RATE_RISING},
 	{"nvidia,drive-type",		TEGRA_PINCONF_PARAM_DRIVE_TYPE},
+	{"nvidia,gpio-mode",		TEGRA_PINCONF_PARAM_GPIO_MODE},
 };
 
 static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev,
@@ -476,6 +477,16 @@ static int tegra_pinconf_reg(struct tegra_pmx *pmx,
 		*bit = g->drvtype_bit;
 		*width = 2;
 		break;
+	case TEGRA_PINCONF_PARAM_GPIO_MODE:
+		if (pmx->soc->sfsel_in_mux) {
+			*bank = g->mux_bank;
+			*reg = g->mux_reg;
+			*bit = g->sfsel_bit;
+			*width = 1;
+		} else {
+			*reg = -EINVAL;
+		}
+		break;
 	default:
 		dev_err(pmx->dev, "Invalid config param %04x\n", param);
 		return -ENOTSUPP;
drivers/pinctrl/tegra/pinctrl-tegra.h +2 -0
index b97136685f7a..a47ac519f3ec 100644
@@ -60,6 +60,8 @@ enum tegra_pinconf_param {
 	TEGRA_PINCONF_PARAM_SLEW_RATE_RISING,
 	/* argument: Integer, range is HW-dependant */
 	TEGRA_PINCONF_PARAM_DRIVE_TYPE,
+	/* argument: Boolean */
+	TEGRA_PINCONF_PARAM_GPIO_MODE,
 };
 
 enum tegra_pinconf_pull {
Signature · 1 line
2.17.1
#1 lore raw

Hi Prathamesh,

thanks for your patch!

a question here:

Quoted 11 lines · Prathamesh Shete

The SFIO/GPIO select bit is a crucial part of Tegra's pin multiplexing system:
- When set to 1, the pin operates in SFIO mode, controlled by the pin's assigned special function.
- When set to 0, the pin operates as a general-purpose GPIO.

This SFIO/GPIO select bit that is set for a given pin is not displayed, adding the support to retrieve this information from the pinmux set for each pin.

If the description is correct, why is this bit not unconditionally set in
tegra_pinctrl_gpio_request_enable()
and unconditionally cleared in tegra_pinctrl_gpio_disable_free()
?

Yours,
Linus Walleij

#2 lore raw
Quoted 18 lines · Linus Walleij

Hi Prathamesh,

thanks for your patch!

a question here:

Quoted 10 lines · Prathamesh Shete

The SFIO/GPIO select bit is a crucial part of Tegra's pin multiplexing system:
- When set to 1, the pin operates in SFIO mode, controlled by the pin's assigned special function.
- When set to 0, the pin operates as a general-purpose GPIO.

This SFIO/GPIO select bit that is set for a given pin is not displayed, adding the support to retrieve this information from the pinmux set for each pin.

Quoted 8 lines
Quoted 1 line

If the description is correct, why is this bit not unconditionally set in
tegra_pinctrl_gpio_request_enable()
and unconditionally cleared in tegra_pinctrl_gpio_disable_free()
?

Sorry for the late reply. This bit is already being set during .gpio_request_enable() and .gpio_disable_free(). My understanding is that this patch is primarily for making this available in debugfs. I suppose we could make that clearer by not making this part of the standard pinconfig options, but rather put it into a "read-only" set configs?

Thierry

#3 lore raw

Hi Linus,

Can you please help check on this and provide feedback

Thanks
Prathamesh.

On 23/01/25, 2:31 PM, "Thierry Reding" <[email protected]> wrote:

Quoted 44 lines · Linus Walleij

Hi Prathamesh,

thanks for your patch!

a question here:

Quoted 14 lines · On Tue, Dec 17, 2024 at 4:33 PM Prathamesh Shete <[email protected]…

The SFIO/GPIO select bit is a crucial part of Tegra's pin multiplexing

system:

- When set to 1, the pin operates in SFIO mode, controlled by the

pin's assigned special function.

- When set to 0, the pin operates as a general-purpose GPIO.

This SFIO/GPIO select bit that is set for a given pin is not displayed,

Quoted 7 lines

adding the support to retrieve this information from the

pinmux set for each pin.

Signed-off-by Prathamesh Shete <[email protected] <mailto:[email protected]>>

If the description is correct, why is this bit not unconditionally

set in

Quoted 7 lines

tegra_pinctrl_gpio_request_enable()

and unconditionally cleared in

tegra_pinctrl_gpio_disable_free()

?

Sorry for the late reply. This bit is already being set during

.gpio_request_enable() and .gpio_disable_free(). My understanding is

that this patch is primarily for making this available in debugfs. I

suppose we could make that clearer by not making this part of the

standard pinconfig options, but rather put it into a "read-only" set

configs?

Thierry

#4 lore raw
In reply to Prathamesh Shete

Hi Prathamesh,

Quoted 11 lines · Prathamesh Shete

The SFIO/GPIO select bit is a crucial part of Tegra's pin multiplexing system:
- When set to 1, the pin operates in SFIO mode, controlled by the pin's assigned special function.
- When set to 0, the pin operates as a general-purpose GPIO.

This SFIO/GPIO select bit that is set for a given pin is not displayed, adding the support to retrieve this information from the pinmux set for each pin.

Sorry for taking so long and losing track of this :(

Patch applied, I take it this is for getting the right info in debugfs as Thierry says, and that's fine.

Yours,
Linus Walleij