xe-ci: Disable xe_evict subtests that are expected to possibly fail
PATCH 1/1 xe-ci: Disable xe_evict subtests that are expected to possibly fail
Threads may compete over VRAM resources, and since there is no serialization in TTM, threaded evict tests may have a high possibility of failing.
Disable such tests until we have a working exhaustive eviction implementation in place.
--- tests/intel-ci/xe-fast-feedback.testlist | 5 ----- tests/intel-ci/xe.blocklist.txt | 7 +++++++ 2 files changed, 7 insertions(+), 5 deletions(-)
tests/intel-ci/xe-fast-feedback.testlist +0 -5
@@ -263,19 +263,14 @@ igt@xe_exec_threads@threads-mixed-shared-vm-basic igt@xe_exec_threads@threads-mixed-fd-basic igt@xe_exec_threads@threads-mixed-userptr-invalidate igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm igt@xe_evict@evict-beng-small igt@xe_evict@evict-beng-small-cm igt@xe_evict@evict-beng-small-external igt@xe_evict@evict-beng-small-external-cm igt@xe_evict@evict-beng-small-multi-vm igt@xe_evict@evict-cm-threads-small -igt@xe_evict@evict-mixed-threads-small -igt@xe_evict@evict-mixed-threads-small-multi-vm igt@xe_evict@evict-small igt@xe_evict@evict-small-cm igt@xe_evict@evict-small-external igt@xe_evict@evict-small-external-cm igt@xe_evict@evict-small-multi-vm -igt@xe_evict@evict-small-multi-vm-cm -igt@xe_evict@evict-threads-small
tests/intel-ci/xe.blocklist.txt +7 -0
@@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$ igt@sriov_basic@enable-vfs-bind-unbind-each$ igt@sriov_basic@bind-unbind-vf$ ################################################################## +# Exclude xe_evict tests that are not expected to succeed +# due to missing TTM exhaustive eviction +################################################################## +igt@xe_evict@*-multi-vm-cm* +igt@xe_evict@*-threads-* +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race. +##################################################################
Signature · 1 line
2.47.1
Quoted 10 lines · Thomas Hellström
Threads may compete over VRAM resources, and since there is no serialization in TTM, threaded evict tests may have a high possibility of failing.
Disable such tests until we have a working exhaustive eviction implementation in place.
Signed-off-by Thomas Hellström <[email protected]>Cc Matthew Brost <[email protected]>Cc <[email protected]>
Saw many failures of these tests on BMG
Quoted 44 lines
--- tests/intel-ci/xe-fast-feedback.testlist | 5 ----- tests/intel-ci/xe.blocklist.txt | 7 +++++++ 2 files changed, 7 insertions(+), 5 deletions(-)tests/intel-ci/xe-fast-feedback.testlist +0
-5@@ -263,19 +263,14 @@ igt@xe_exec_threads@threads-mixed-shared-vm-basic igt@xe_exec_threads@threads-mixed-fd-basic igt@xe_exec_threads@threads-mixed-userptr-invalidate igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm igt@xe_evict@evict-beng-small igt@xe_evict@evict-beng-small-cm igt@xe_evict@evict-beng-small-external igt@xe_evict@evict-beng-small-external-cm igt@xe_evict@evict-beng-small-multi-vm igt@xe_evict@evict-cm-threads-small -igt@xe_evict@evict-mixed-threads-small -igt@xe_evict@evict-mixed-threads-small-multi-vm igt@xe_evict@evict-small igt@xe_evict@evict-small-cm igt@xe_evict@evict-small-external igt@xe_evict@evict-small-external-cm igt@xe_evict@evict-small-multi-vm -igt@xe_evict@evict-small-multi-vm-cm -igt@xe_evict@evict-threads-smalltests/intel-ci/xe.blocklist.txt +7
-0@@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$ igt@sriov_basic@enable-vfs-bind-unbind-each$ igt@sriov_basic@bind-unbind-vf$ ################################################################## +# Exclude xe_evict tests that are not expected to succeed +# due to missing TTM exhaustive eviction +################################################################## +igt@xe_evict@*-multi-vm-cm* +igt@xe_evict@*-threads-* +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race. +##################################################################
Hi Thomas,
Quoted 10 lines · Thomas Hellström
Threads may compete over VRAM resources, and since there is no serialization in TTM, threaded evict tests may have a high possibility of failing.
Disable such tests until we have a working exhaustive eviction implementation in place.
Signed-off-by Thomas Hellström <[email protected]>Cc Matthew Brost <[email protected]>Cc <[email protected]>
Looks reasonable, please only change prefix into
tests/intel-ci/xe*:
also consider writing it a little shorter, like:
[PATCH i-g-t] tests/intel-ci/xe*: Disable few xe_evict subtests
With this
Please also see one nit below.
Quoted 34 lines
--- tests/intel-ci/xe-fast-feedback.testlist | 5 ----- tests/intel-ci/xe.blocklist.txt | 7 +++++++ 2 files changed, 7 insertions(+), 5 deletions(-)tests/intel-ci/xe-fast-feedback.testlist +0
-5@@ -263,19 +263,14 @@ igt@xe_exec_threads@threads-mixed-shared-vm-basic igt@xe_exec_threads@threads-mixed-fd-basic igt@xe_exec_threads@threads-mixed-userptr-invalidate igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm igt@xe_evict@evict-beng-small igt@xe_evict@evict-beng-small-cm igt@xe_evict@evict-beng-small-external igt@xe_evict@evict-beng-small-external-cm igt@xe_evict@evict-beng-small-multi-vm igt@xe_evict@evict-cm-threads-small -igt@xe_evict@evict-mixed-threads-small -igt@xe_evict@evict-mixed-threads-small-multi-vm igt@xe_evict@evict-small igt@xe_evict@evict-small-cm igt@xe_evict@evict-small-external igt@xe_evict@evict-small-external-cm igt@xe_evict@evict-small-multi-vm -igt@xe_evict@evict-small-multi-vm-cm -igt@xe_evict@evict-threads-smalltests/intel-ci/xe.blocklist.txt +0
-0
tests/intel-ci/xe.blocklist.txt igt@sriov_basic@enable-vfs-autoprobe-on$ · line 98
Quoted 9 lines
tests/intel-ci/xe.blocklist.txt +6
-0@@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$ igt@sriov_basic@enable-vfs-bind-unbind-each$ igt@sriov_basic@bind-unbind-vf$ ################################################################## +# Exclude xe_evict tests that are not expected to succeed +# due to missing TTM exhaustive eviction +################################################################## +igt@xe_evict@*-multi-vm-cm* +igt@xe_evict@*-threads-* +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race.
Did you mean that
igt@xe_evict@evict-cm-threads-small
should stay in BAT?
Regards,
Kamil
Quoted 4 lines
tests/intel-ci/xe.blocklist.txt +1
-0+##################################################################Signature · 1 line
2.47.1
Quoted 75 lines · Kamil Konieczny
Hi Thomas,
Quoted 10 lines · Thomas Hellström
Threads may compete over VRAM resources, and since there is no serialization in TTM, threaded evict tests may have a high possibility of failing.
Disable such tests until we have a working exhaustive eviction implementation in place.
Signed-off-by Thomas Hellström <[email protected]>Cc Matthew Brost <[email protected]>Cc <[email protected]>Looks reasonable, please only change prefix into
tests/intel-ci/xe*:also consider writing it a little shorter, like:
[PATCH i-g-t] tests/intel-ci/xe*: Disable fewxe_evictsubtestsWith this
Acked-by Kamil Konieczny <[email protected]>Please also see one nit below.
Quoted 41 lines
---
tests/intel-ci/xe-fast-feedback.testlist | 5 ----- tests/intel-ci/xe.blocklist.txt | 7 +++++++2 files changed, 7 insertions(+), 5 deletions(-)tests/intel-ci/xe-fast-feedback.testlist +0
-0@@ -263,19 +263,14 @@igt@xe_exec_threads@threads-mixed-shared-vm-basic igt@xe_exec_threads@threads-mixed-fd-basic igt@xe_exec_threads@threads-mixed-userptr-invalidate
igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm igt@xe_evict@evict-beng-small igt@xe_evict@evict-beng-small-cm igt@xe_evict@evict-beng-small-external igt@xe_evict@evict-beng-small-external-cm igt@xe_evict@evict-beng-small-multi-vm igt@xe_evict@evict-cm-threads-smalltests/intel-ci/xe-fast-feedback.testlist +0
-2-igt@xe_evict@evict-mixed-threads-small -igt@xe_evict@evict-mixed-threads-small-multi-vmigt@xe_evict@evict-small
igt@xe_evict@evict-small-cm
igt@xe_evict@evict-small-external
igt@xe_evict@evict-small-external-cm
igt@xe_evict@evict-small-multi-vmtests/intel-ci/xe-fast-feedback.testlist +0
-2-igt@xe_evict@evict-small-multi-vm-cm -igt@xe_evict@evict-threads-smalltests/intel- renamed from tests/intel-ci/xe.blocklist.txt +0
-0
ci/xe.blocklist.txt
indexe29e745a0..ed9e572a5100644tests/intel-ci/xe.blocklist.txt +0
-0@@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$igt@sriov_basic@enable-vfs-bind-unbind-each$
igt@sriov_basic@bind-unbind-vf$
##################################################################tests/intel-ci/xe.blocklist.txt igt@sriov_basic@enable-vfs-autoprobe-on$ · line 98
Quoted 6 lines
tests/intel-ci/xe.blocklist.txt +6
-0+# Exclude xe_evict tests that are not expected to succeed +# due to missing TTM exhaustive eviction +################################################################## +igt@xe_evict@*-multi-vm-cm* +igt@xe_evict@*-threads-* +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race.Did you mean that
igt@xe_evict@evict-cm-threads-small
Quoted 1 line
should stay in BAT?
No it shouldn't. Good catch. I'll update.
Quoted 8 lines
Regards,
KamilQuoted 4 lines
+##################################################################
Signature · 1 line
2.47.1
Quoted 29 lines · Thomas Hellström
Threads may compete over VRAM resources, and since there is no serialization in TTM, threaded evict tests may have a high possibility of failing.
Disable such tests until we have a working exhaustive eviction implementation in place.
Signed-off-by Thomas Hellström <[email protected]>Cc Matthew Brost <[email protected]>Cc <[email protected]>--- tests/intel-ci/xe-fast-feedback.testlist | 5 ----- tests/intel-ci/xe.blocklist.txt | 7 +++++++ 2 files changed, 7 insertions(+), 5 deletions(-)tests/intel-ci/xe-fast-feedback.testlist +0
-1@@ -263,19 +263,14 @@ igt@xe_exec_threads@threads-mixed-shared-vm-basic igt@xe_exec_threads@threads-mixed-fd-basic igt@xe_exec_threads@threads-mixed-userptr-invalidate igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm igt@xe_evict@evict-beng-small igt@xe_evict@evict-beng-small-cm igt@xe_evict@evict-beng-small-external igt@xe_evict@evict-beng-small-external-cm igt@xe_evict@evict-beng-small-multi-vm
tests/intel-ci/xe-fast-feedback.testlist igt@xe_exec_threads@threads-mixed-shared-vm-basic · line 281
Quoted 10 lines
tests/intel-ci/xe-fast-feedback.testlist +0
-4igt@xe_evict@evict-cm-threads-small -igt@xe_evict@evict-mixed-threads-small -igt@xe_evict@evict-mixed-threads-small-multi-vm igt@xe_evict@evict-small igt@xe_evict@evict-small-cm igt@xe_evict@evict-small-external igt@xe_evict@evict-small-external-cm igt@xe_evict@evict-small-multi-vm -igt@xe_evict@evict-small-multi-vm-cm -igt@xe_evict@evict-threads-small
There seem to be multiple issues pertaining to these tests.
Quoted 15 lines
tests/intel-ci/xe.blocklist.txt +7
-0@@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$ igt@sriov_basic@enable-vfs-bind-unbind-each$ igt@sriov_basic@bind-unbind-vf$ ################################################################## +# Exclude xe_evict tests that are not expected to succeed +# due to missing TTM exhaustive eviction +################################################################## +igt@xe_evict@*-multi-vm-cm* +igt@xe_evict@*-threads-* +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race. +##################################################################