Skip to contentSkip to conversation

system/confidential-guest-support: Header cleanups

PATCH In review Philippe Mathieu-Daudé 4 participants 11 messages Dec 18, 2024 KVM

lore
Share & tools
lore
#0 lore raw

cover system/confidential-guest-support: Header cleanups

Restrict "confidential-guest-support.h" to system emulation, remove few SEV declarations on user mode.

Philippe Mathieu-Daudé (2):
system: Move 'exec/confidential-guest-support.h' to system/ target/i386/sev: Reduce system specific declarations

 .../confidential-guest-support.h              |  6 ++--
 target/i386/confidential-guest.h              |  2 +-
 target/i386/sev.h                             | 29 ++++++++++---------
 backends/confidential-guest-support.c         |  2 +-
 hw/core/machine.c                             |  2 +-
 hw/i386/pc_sysfw.c                            |  2 +-
 hw/ppc/pef.c                                  |  2 +-
 hw/ppc/spapr.c                                |  2 +-
 hw/s390x/s390-virtio-ccw.c                    |  2 +-
 system/vl.c                                   |  2 +-
 target/s390x/kvm/pv.c                         |  2 +-
 11 files changed, 28 insertions(+), 25 deletions(-)
 rename include/{exec => system}/confidential-guest-support.h (96%)
Signature · 1 line
2.45.2
#1 lore raw

PATCH 1/2 system: Move 'exec/confidential-guest-support.h' to system/

"exec/confidential-guest-support.h" is specific to system emulation, so move it under the system/ namespace. Mechanical change doing:

  $ sed -i \
    -e 's,exec/confidential-guest-support.h,sysemu/confidential-guest-support.h,' \
        $(git grep -l exec/confidential-guest-support.h)
---
 include/{exec => system}/confidential-guest-support.h | 6 +++---
 target/i386/confidential-guest.h                      | 2 +-
 target/i386/sev.h                                     | 2 +-
 backends/confidential-guest-support.c                 | 2 +-
 hw/core/machine.c                                     | 2 +-
 hw/ppc/pef.c                                          | 2 +-
 hw/ppc/spapr.c                                        | 2 +-
 hw/s390x/s390-virtio-ccw.c                            | 2 +-
 system/vl.c                                           | 2 +-
 target/s390x/kvm/pv.c                                 | 2 +-
 10 files changed, 12 insertions(+), 12 deletions(-)
 rename include/{exec => system}/confidential-guest-support.h (96%)
include/system/confidential-guest-support.h renamed from include/exec/confidential-guest-support.h +3 -3
similarity index 96%
rename from include/exec/confidential-guest-support.h
rename to include/system/confidential-guest-support.h
index 02dc4e518f0..b68c4bebbc1 100644
@@ -18,7 +18,9 @@
 #ifndef QEMU_CONFIDENTIAL_GUEST_SUPPORT_H
 #define QEMU_CONFIDENTIAL_GUEST_SUPPORT_H
 
-#ifndef CONFIG_USER_ONLY
+#ifdef CONFIG_USER_ONLY
+#error Cannot include system/confidential-guest-support.h from user emulation
+#endif
 
 #include "qom/object.h"
 
@@ -94,6 +96,4 @@ static inline int confidential_guest_kvm_reset(ConfidentialGuestSupport *cgs,
     return 0;
 }
 
-#endif /* !CONFIG_USER_ONLY */
-
 #endif /* QEMU_CONFIDENTIAL_GUEST_SUPPORT_H */
target/i386/confidential-guest.h +1 -1
index 7342d2843aa..0afb8317b58 100644
@@ -14,7 +14,7 @@
 
 #include "qom/object.h"
 
-#include "exec/confidential-guest-support.h"
+#include "system/confidential-guest-support.h"
 
 #define TYPE_X86_CONFIDENTIAL_GUEST "x86-confidential-guest"
 
target/i386/sev.h +1 -1
index 858005a119c..2664c0b1b6c 100644
@@ -18,7 +18,7 @@
 #include CONFIG_DEVICES /* CONFIG_SEV */
 #endif
 
-#include "exec/confidential-guest-support.h"
+#include "system/confidential-guest-support.h"
 
 #define TYPE_SEV_COMMON "sev-common"
 #define TYPE_SEV_GUEST "sev-guest"
backends/confidential-guest-support.c +1 -1
index 052fde8db04..1cd9bed505d 100644
@@ -13,7 +13,7 @@
 
 #include "qemu/osdep.h"
 
-#include "exec/confidential-guest-support.h"
+#include "system/confidential-guest-support.h"
 
 OBJECT_DEFINE_ABSTRACT_TYPE(ConfidentialGuestSupport,
                             confidential_guest_support,
hw/core/machine.c +1 -1
index ba819fec0af..0e8af37194f 100644
@@ -30,7 +30,7 @@
 #include "hw/pci/pci_bridge.h"
 #include "hw/mem/nvdimm.h"
 #include "migration/global_state.h"
-#include "exec/confidential-guest-support.h"
+#include "system/confidential-guest-support.h"
 #include "hw/virtio/virtio-pci.h"
 #include "hw/virtio/virtio-net.h"
 #include "hw/virtio/virtio-iommu.h"
hw/ppc/pef.c +1 -1
index cffda44602e..8b2d726e008 100644
@@ -14,7 +14,7 @@
 #include "qom/object_interfaces.h"
 #include "system/kvm.h"
 #include "migration/blocker.h"
-#include "exec/confidential-guest-support.h"
+#include "system/confidential-guest-support.h"
 
 #define TYPE_PEF_GUEST "pef-guest"
 OBJECT_DECLARE_SIMPLE_TYPE(PefGuest, PEF_GUEST)
hw/ppc/spapr.c +1 -1
index ad21018b5aa..623842f8064 100644
@@ -75,7 +75,7 @@
 #include "hw/virtio/vhost-scsi-common.h"
 
 #include "exec/ram_addr.h"
-#include "exec/confidential-guest-support.h"
+#include "system/confidential-guest-support.h"
 #include "hw/usb.h"
 #include "qemu/config-file.h"
 #include "qemu/error-report.h"
hw/s390x/s390-virtio-ccw.c +1 -1
index f4d64d64f94..b45d8963b36 100644
@@ -14,7 +14,7 @@
 #include "qemu/osdep.h"
 #include "qapi/error.h"
 #include "exec/ram_addr.h"
-#include "exec/confidential-guest-support.h"
+#include "system/confidential-guest-support.h"
 #include "hw/boards.h"
 #include "hw/s390x/s390-virtio-hcall.h"
 #include "hw/s390x/sclp.h"
system/vl.c +1 -1
index a271ecc1acf..4785b3ff09a 100644
@@ -107,7 +107,7 @@
 #include "qemu/plugin.h"
 #include "qemu/queue.h"
 #include "system/arch_init.h"
-#include "exec/confidential-guest-support.h"
+#include "system/confidential-guest-support.h"
 
 #include "ui/qemu-spice.h"
 #include "qapi/string-input-visitor.h"
target/s390x/kvm/pv.c +1 -1
index e4b0d17a48a..69c1811e156 100644
@@ -19,7 +19,7 @@
 #include "system/kvm.h"
 #include "system/cpus.h"
 #include "qom/object_interfaces.h"
-#include "exec/confidential-guest-support.h"
+#include "system/confidential-guest-support.h"
 #include "hw/s390x/ipl.h"
 #include "hw/s390x/sclp.h"
 #include "target/s390x/kvm/kvm_s390x.h"
Signature · 1 line
2.45.2
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] system: Move 'exec/confidential-guest-support.h' to system/

Quoted 21 lines · Philippe Mathieu-Daudé

"exec/confidential-guest-support.h" is specific to system emulation, so move it under the system/ namespace. Mechanical change doing:

   $ sed -i \
     -e 's,exec/confidential-guest-support.h,sysemu/confidential-guest-support.h,' \
         $(git grep -l exec/confidential-guest-support.h)
---
  include/{exec => system}/confidential-guest-support.h | 6 +++---
  target/i386/confidential-guest.h                      | 2 +-
  target/i386/sev.h                                     | 2 +-
  backends/confidential-guest-support.c                 | 2 +-
  hw/core/machine.c                                     | 2 +-
  hw/ppc/pef.c                                          | 2 +-
  hw/ppc/spapr.c                                        | 2 +-
  hw/s390x/s390-virtio-ccw.c                            | 2 +-
  system/vl.c                                           | 2 +-
  target/s390x/kvm/pv.c                                 | 2 +-
  10 files changed, 12 insertions(+), 12 deletions(-)
Quoted 1 line

rename include/{exec => system}/confidential-guest-support.h (96%)

Reviewed-by on v1 1/2
#3 lore raw

Re: [PATCH 1/2] system: Move 'exec/confidential-guest-support.h' to system/

In reply to Philippe Mathieu-Daudé
Quoted 15 lines · Philippe Mathieu-Daudé

Date: Wed, 18 Dec 2024 16:59:12 +0100
From: Philippe Mathieu-Daudé <[email protected]>
Subject: [PATCH 1/2] system: Move 'exec/confidential-guest-support.h' to
system/
X-Mailer: git-send-email 2.45.2

"exec/confidential-guest-support.h" is specific to system emulation, so move it under the system/ namespace. Mechanical change doing:

  $ sed -i \
    -e 's,exec/confidential-guest-support.h,sysemu/confidential-guest-support.h,' \
        $(git grep -l exec/confidential-guest-support.h)
Quoted 14 lines
---
 include/{exec => system}/confidential-guest-support.h | 6 +++---
 target/i386/confidential-guest.h                      | 2 +-
 target/i386/sev.h                                     | 2 +-
 backends/confidential-guest-support.c                 | 2 +-
 hw/core/machine.c                                     | 2 +-
 hw/ppc/pef.c                                          | 2 +-
 hw/ppc/spapr.c                                        | 2 +-
 hw/s390x/s390-virtio-ccw.c                            | 2 +-
 system/vl.c                                           | 2 +-
 target/s390x/kvm/pv.c                                 | 2 +-
 10 files changed, 12 insertions(+), 12 deletions(-)
 rename include/{exec => system}/confidential-guest-support.h (96%)

(MAINTAINERS is missed to change? :-))

#4 lore raw

Re: [PATCH 1/2] system: Move 'exec/confidential-guest-support.h' to system/

Quoted 31 lines · Zhao Liu
Quoted 27 lines · Philippe Mathieu-Daudé

Date: Wed, 18 Dec 2024 16:59:12 +0100
From: Philippe Mathieu-Daudé <[email protected]>
Subject: [PATCH 1/2] system: Move 'exec/confidential-guest-support.h' to
system/
X-Mailer: git-send-email 2.45.2

"exec/confidential-guest-support.h" is specific to system emulation, so move it under the system/ namespace. Mechanical change doing:

   $ sed -i \
     -e 's,exec/confidential-guest-support.h,sysemu/confidential-guest-support.h,' \
         $(git grep -l exec/confidential-guest-support.h)
---
  include/{exec => system}/confidential-guest-support.h | 6 +++---
  target/i386/confidential-guest.h                      | 2 +-
  target/i386/sev.h                                     | 2 +-
  backends/confidential-guest-support.c                 | 2 +-
  hw/core/machine.c                                     | 2 +-
  hw/ppc/pef.c                                          | 2 +-
  hw/ppc/spapr.c                                        | 2 +-
  hw/s390x/s390-virtio-ccw.c                            | 2 +-
  system/vl.c                                           | 2 +-
  target/s390x/kvm/pv.c                                 | 2 +-
  10 files changed, 12 insertions(+), 12 deletions(-)
Quoted 2 lines

rename include/{exec => system}/confidential-guest-support.h (96%)

Quoted 3 lines

(MAINTAINERS is missed to change? :-))

Yeah there is no entry for CGS in MAINTAINERS :(

#5 lore raw

PATCH 2/2 target/i386/sev: Reduce system specific declarations

In reply to Philippe Mathieu-Daudé

"system/confidential-guest-support.h" is not needed, remove it. Reorder #ifdef'ry to reduce declarations exposed on user emulation.

---
 target/i386/sev.h  | 29 ++++++++++++++++-------------
 hw/i386/pc_sysfw.c |  2 +-
 2 files changed, 17 insertions(+), 14 deletions(-)
target/i386/sev.h +16 -13
index 2664c0b1b6c..373669eaace 100644
@@ -18,7 +18,17 @@
 #include CONFIG_DEVICES /* CONFIG_SEV */
 #endif
 
-#include "system/confidential-guest-support.h"
+#if !defined(CONFIG_SEV) || defined(CONFIG_USER_ONLY)
+#define sev_enabled() 0
+#define sev_es_enabled() 0
+#define sev_snp_enabled() 0
+#else
+bool sev_enabled(void);
+bool sev_es_enabled(void);
+bool sev_snp_enabled(void);
+#endif
+
+#if !defined(CONFIG_USER_ONLY)
 
 #define TYPE_SEV_COMMON "sev-common"
 #define TYPE_SEV_GUEST "sev-guest"
@@ -45,18 +55,6 @@ typedef struct SevKernelLoaderContext {
     size_t cmdline_size;
 } SevKernelLoaderContext;
 
-#ifdef CONFIG_SEV
-bool sev_enabled(void);
-bool sev_es_enabled(void);
-bool sev_snp_enabled(void);
-#else
-#define sev_enabled() 0
-#define sev_es_enabled() 0
-#define sev_snp_enabled() 0
-#endif
-
-uint32_t sev_get_cbit_position(void);
-uint32_t sev_get_reduced_phys_bits(void);
 bool sev_add_kernel_loader_hashes(SevKernelLoaderContext *ctx, Error **errp);
 
 int sev_encrypt_flash(hwaddr gpa, uint8_t *ptr, uint64_t len, Error **errp);
@@ -68,4 +66,9 @@ void sev_es_set_reset_vector(CPUState *cpu);
 
 void pc_system_parse_sev_metadata(uint8_t *flash_ptr, size_t flash_size);
 
+#endif /* !CONFIG_USER_ONLY */
+
+uint32_t sev_get_cbit_position(void);
+uint32_t sev_get_reduced_phys_bits(void);
+
 #endif
hw/i386/pc_sysfw.c +1 -1
index da7ed121292..1eeb58ab37f 100644
@@ -36,7 +36,7 @@
 #include "hw/qdev-properties.h"
 #include "hw/block/flash.h"
 #include "system/kvm.h"
-#include "sev.h"
+#include "target/i386/sev.h"
 
 #define FLASH_SECTOR_SIZE 4096
 
Signature · 1 line
2.45.2
Reviewed-by on v1 2/2
#6 lore raw

Re: [PATCH 2/2] target/i386/sev: Reduce system specific declarations

Quoted 9 lines · Philippe Mathieu-Daudé

"system/confidential-guest-support.h" is not needed, remove it. Reorder #ifdef'ry to reduce declarations exposed on user emulation.

---
  target/i386/sev.h  | 29 ++++++++++++++++-------------
  hw/i386/pc_sysfw.c |  2 +-
  2 files changed, 17 insertions(+), 14 deletions(-)
Reviewed-by on v1 2/2
#7 lore raw

Re: [PATCH 2/2] target/i386/sev: Reduce system specific declarations

In reply to Philippe Mathieu-Daudé
Quoted 9 lines · Philippe Mathieu-Daudé

Date: Wed, 18 Dec 2024 16:59:13 +0100
From: Philippe Mathieu-Daudé <[email protected]>
Subject: [PATCH 2/2] target/i386/sev: Reduce system specific declarations
X-Mailer: git-send-email 2.45.2

"system/confidential-guest-support.h" is not needed, remove it. Reorder #ifdef'ry to reduce declarations exposed on user emulation.

Quoted 6 lines
---
 target/i386/sev.h  | 29 ++++++++++++++++-------------
 hw/i386/pc_sysfw.c |  2 +-
 2 files changed, 17 insertions(+), 14 deletions(-)
#8 lore raw

Re: [PATCH 2/2] target/i386/sev: Reduce system specific declarations

In reply to Philippe Mathieu-Daudé
Quoted 20 lines · Philippe Mathieu-Daudé

"system/confidential-guest-support.h" is not needed, remove it. Reorder #ifdef'ry to reduce declarations exposed on user emulation.

---
 target/i386/sev.h  | 29 ++++++++++++++++-------------
 hw/i386/pc_sysfw.c |  2 +-
 2 files changed, 17 insertions(+), 14 deletions(-)
target/i386/sev.h +1 -1
index 2664c0b1b6c..373669eaace 100644
@@ -18,7 +18,17 @@
 #include CONFIG_DEVICES /* CONFIG_SEV */
 #endif
 
-#include "system/confidential-guest-support.h"
+#if !defined(CONFIG_SEV) || defined(CONFIG_USER_ONLY)

target/i386/sev.h line 31

Quoted 10 lines
target/i386/sev.h +10 -0
+#define sev_enabled() 0
+#define sev_es_enabled() 0
+#define sev_snp_enabled() 0
+#else
+bool sev_enabled(void);
+bool sev_es_enabled(void);
+bool sev_snp_enabled(void);
+#endif
+
+#if !defined(CONFIG_USER_ONLY)

I'm surprised any of this header file is relevant to user mode. If something is mistakely calling sev_ functions from user mode compiled code, I'd be inclined to fix the caller such that its #include ".../sev.h" can be wrapped by !CONFIG_USER_ONLY

Quoted 49 lines
target/i386/sev.h +5 -12
 #define TYPE_SEV_COMMON "sev-common"
 #define TYPE_SEV_GUEST "sev-guest"
@@ -45,18 +55,6 @@ typedef struct SevKernelLoaderContext {
     size_t cmdline_size;
 } SevKernelLoaderContext;
 
-#ifdef CONFIG_SEV
-bool sev_enabled(void);
-bool sev_es_enabled(void);
-bool sev_snp_enabled(void);
-#else
-#define sev_enabled() 0
-#define sev_es_enabled() 0
-#define sev_snp_enabled() 0
-#endif
-
-uint32_t sev_get_cbit_position(void);
-uint32_t sev_get_reduced_phys_bits(void);
 bool sev_add_kernel_loader_hashes(SevKernelLoaderContext *ctx, Error **errp);
 
 int sev_encrypt_flash(hwaddr gpa, uint8_t *ptr, uint64_t len, Error **errp);
@@ -68,4 +66,9 @@ void sev_es_set_reset_vector(CPUState *cpu);
 
 void pc_system_parse_sev_metadata(uint8_t *flash_ptr, size_t flash_size);
 
+#endif /* !CONFIG_USER_ONLY */
+
+uint32_t sev_get_cbit_position(void);
+uint32_t sev_get_reduced_phys_bits(void);
+
 #endif
hw/i386/pc_sysfw.c +1 -1
index da7ed121292..1eeb58ab37f 100644
@@ -36,7 +36,7 @@
 #include "hw/qdev-properties.h"
 #include "hw/block/flash.h"
 #include "system/kvm.h"
-#include "sev.h"
+#include "target/i386/sev.h"
 
 #define FLASH_SECTOR_SIZE 4096
 
Signature · 1 line
2.45.2

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#9 lore raw

Re: [PATCH 2/2] target/i386/sev: Reduce system specific declarations

Quoted 29 lines · Daniel P. Berrangé
Quoted 28 lines · Philippe Mathieu-Daudé

"system/confidential-guest-support.h" is not needed, remove it. Reorder #ifdef'ry to reduce declarations exposed on user emulation.

---
  target/i386/sev.h  | 29 ++++++++++++++++-------------
  hw/i386/pc_sysfw.c |  2 +-
  2 files changed, 17 insertions(+), 14 deletions(-)
target/i386/sev.h +9 -1
index 2664c0b1b6c..373669eaace 100644
@@ -18,7 +18,17 @@
  #include CONFIG_DEVICES /* CONFIG_SEV */
  #endif
 
-#include "system/confidential-guest-support.h"
+#if !defined(CONFIG_SEV) || defined(CONFIG_USER_ONLY)
+#define sev_enabled() 0
+#define sev_es_enabled() 0
+#define sev_snp_enabled() 0
+#else
+bool sev_enabled(void);
+bool sev_es_enabled(void);
+bool sev_snp_enabled(void);
+#endif
Quoted 8 lines

target/i386/sev.h line 31

Quoted 2 lines
target/i386/sev.h +2 -0
+
+#if !defined(CONFIG_USER_ONLY)

I'm surprised any of this header file is relevant to user mode. If something is mistakely calling sev_ functions from user mode compiled code, I'd be inclined to fix the caller such that its #include ".../sev.h" can be wrapped by !CONFIG_USER_ONLY

I forgot to mention and just replied in another post:

The motivation is to reduce system-specific definitions exposed to user-mode in target/i386/cpu.c, like hwaddr &co, but I'm not there yet and have too many local patches so starting to send what's ready.

WRT SEV what is bugging me is in cpu_x86_cpuid():

target/i386/cpu.c-7137- case 0x8000001F:
target/i386/cpu.c-7138- *eax = *ebx = *ecx = *edx = 0;
target/i386/cpu.c:7139: if (sev_enabled()) {

target/i386/cpu.c-7140-            *eax = 0x2;
target/i386/cpu.c-7141-            *eax |= sev_es_enabled() ? 0x8 : 0;
target/i386/cpu.c-7142-            *eax |= sev_snp_enabled() ? 0x10 : 0;
target/i386/cpu.c-7143-            *ebx = sev_get_cbit_position() & 0x3f; /* EBX[5:0] */
target/i386/cpu.c-7144-            *ebx |= (sev_get_reduced_phys_bits() & 0x3f) << 6; /* EBX[11:6] */

target/i386/cpu.c-7145- }
target/i386/cpu.c-7146- break;

but maybe I can use #ifdef'ry around CONFIG_USER_ONLY like with SGX:

    case 0x12:
#ifndef CONFIG_USER_ONLY
        if (count > 1) {
            uint64_t epc_addr, epc_size;

            if (sgx_epc_get_section(count - 2, &epc_addr, &epc_size)) {
                *eax = *ebx = *ecx = *edx = 0;
                break;
            }
            ...
#endif
        break;
Quoted 23 lines
Quoted 23 lines
target/i386/sev.h +0 -12
  #define TYPE_SEV_COMMON "sev-common"
  #define TYPE_SEV_GUEST "sev-guest"
@@ -45,18 +55,6 @@ typedef struct SevKernelLoaderContext {
      size_t cmdline_size;
  } SevKernelLoaderContext;
 
-#ifdef CONFIG_SEV
-bool sev_enabled(void);
-bool sev_es_enabled(void);
-bool sev_snp_enabled(void);
-#else
-#define sev_enabled() 0
-#define sev_es_enabled() 0
-#define sev_snp_enabled() 0
-#endif
-
-uint32_t sev_get_cbit_position(void);
-uint32_t sev_get_reduced_phys_bits(void);
  bool sev_add_kernel_loader_hashes(SevKernelLoaderContext *ctx, Error **errp);
 
  int sev_encrypt_flash(hwaddr gpa, uint8_t *ptr, uint64_t len, Error **errp);
#10 lore raw

Re: [PATCH 2/2] target/i386/sev: Reduce system specific declarations

In reply to Philippe Mathieu-Daudé
Quoted 24 lines · Philippe Mathieu-Daudé

"system/confidential-guest-support.h" is not needed, remove it. Reorder #ifdef'ry to reduce declarations exposed on user emulation.

---
  target/i386/sev.h  | 29 ++++++++++++++++-------------
  hw/i386/pc_sysfw.c |  2 +-
  2 files changed, 17 insertions(+), 14 deletions(-)
target/i386/sev.h +1 -5
+#if !defined(CONFIG_USER_ONLY)
 
  #define TYPE_SEV_COMMON "sev-common"
  #define TYPE_SEV_GUEST "sev-guest"
@@ -45,18 +55,6 @@ typedef struct SevKernelLoaderContext {
      size_t cmdline_size;
  } SevKernelLoaderContext;
 
-#ifdef CONFIG_SEV
-bool sev_enabled(void);
-bool sev_es_enabled(void);
-bool sev_snp_enabled(void);
-#else

target/i386/sev.h typedef struct SevKernelLoaderContext { · line 60

Quoted 10 lines
target/i386/sev.h +0 -7
-#define sev_enabled() 0
-#define sev_es_enabled() 0
-#define sev_snp_enabled() 0
-#endif
-
-uint32_t sev_get_cbit_position(void);
-uint32_t sev_get_reduced_phys_bits(void);
  bool sev_add_kernel_loader_hashes(SevKernelLoaderContext *ctx, Error **errp);
 
  int sev_encrypt_flash(hwaddr gpa, uint8_t *ptr, uint64_t len, Error **errp);

The motivation is to reduce system-specific definitions exposed to user-mode in target/i386/cpu.c, like hwaddr &co, but I'm not there yet and have too many local patches so starting to send what's ready.

Quoted 10 lines
target/i386/sev.h +5 -0
@@ -68,4 +66,9 @@ void sev_es_set_reset_vector(CPUState *cpu);
 
  void pc_system_parse_sev_metadata(uint8_t *flash_ptr, size_t flash_size);
 
+#endif /* !CONFIG_USER_ONLY */
+
+uint32_t sev_get_cbit_position(void);
+uint32_t sev_get_reduced_phys_bits(void);
+
  #endif