mm: Stop PMD alignment for PIE shared objects
Subsystems (2)
PATCH 1/1 mm: Stop PMD alignment for PIE shared objects
After commit 1854bc6e2420 ("mm/readahead: Align file mappings for non-DAX") any request through thp_get_unmapped_area would align to a PMD_SIZE, causing shared objects to have less randomization than previously (9 less bits for 2MB PMDs). As these lower 9 bits are the most impactful for ASLR, this change could be argued to have an impact on security. Running the pie-so program [1] multiple times we can see the randomization loss as the lower address bits get aligned to a 2MB size on x86 (pie-so):
# ./all-gather && ./all-bits
---------[SNIP]---------
aslr heap 19 bits
aslr exec 00 bits
aslr mmap 29 bits
aslr so 00 bits
aslr stack 31 bits
aslr pie-exec 30 bits
aslr pie-heap 30 bits
aslr pie-so 20 bits
aslr pie-mmap 29 bits
aslr pie-stack 30 bitsFix this issue by checking that the request is aligned to the PMD_SIZE, otherwise fall back to mm_get_unmapped_area_vmflags().
[1] https://github.com/stevegrubb/distro-elf-inspector
--- mm/huge_memory.c | 3 +++ 1 file changed, 3 insertions(+)
mm/huge_memory.c +3 -0
@@ -1101,6 +1101,9 @@ static unsigned long __thp_get_unmapped_area(struct file *filp,if (len_pad < len || (off + len_pad) < off)return 0 ; +if (!IS_ALIGNED (len,PMD_SIZE )) +return 0 ; + ret =mm_get_unmapped_area_vmflags (current->mm, filp, addr, len_pad, off >>PAGE_SHIFT , flags, vm_flags);
Signature · 1 line
2.45.0
Quoted 5 lines · Audra Mitchell
After commit
1854bc6e2420("mm/readahead: Align file mappings for non-DAX") any request throughthp_get_unmapped_areawould align to aPMD_SIZE, causing shared objects to have less randomization than previously (9 less bits for 2MB PMDs). As these lower 9 bits are the most impactful for ASLR, this change could be argued to have an impact on security.
Yes, very tiresome people have been making that argument for a long time. Do you have anything further to add to the discussion that happened here:
https://lore.kernel.org/linux-mm/[email protected]/
particularly in light of 3afb76a66b55 existing.
Quoted 2 lines
Fix this issue by checking that the request is aligned to the
PMD_SIZE, otherwise fall back tomm_get_unmapped_area_vmflags().
NAK this version anyway. Even if the executable is, say, 2.1MB in size, we still want the first 2MB of the file to be covered with a PMD mapping.
Quoted 7 lines · Matthew Wilcox
Quoted 5 lines · Audra Mitchell
After commit
1854bc6e2420("mm/readahead: Align file mappings for non-DAX") any request throughthp_get_unmapped_areawould align to aPMD_SIZE, causing shared objects to have less randomization than previously (9 less bits for 2MB PMDs). As these lower 9 bits are the most impactful for ASLR, this change could be argued to have an impact on security.
Quoted 7 lines
Yes, very tiresome people have been making that argument for a long time. Do you have anything further to add to the discussion that happened here:
https://lore.kernel.org/linux-mm/[email protected]/
particularly in light of
3afb76a66b55existing.
Hey all,
Happy Holidays! I was not aware of this discussion, so thank you for bringing it to my attention. I've read over it and I'll take a closer look after the holidays.
Respectfully, I'm trying to understand your view of this problem given your feedback - can you clarify for me what you mean by "particularly in light of" regarding 3afb76a66b55... it looks to me like this was reverted with 14d7c92f8df9 and there does appear to be some room for improvement for this topic based on linus' commit message there.
I did play around with the idea of checking to see if kaslr was enabled and only doing the return in that case, as users then could opt-in to the solution or not..
Thanks in advance for your insight!
Quoted 7 lines
Quoted 2 lines
Fix this issue by checking that the request is aligned to the
PMD_SIZE, otherwise fall back tomm_get_unmapped_area_vmflags().NAK this version anyway. Even if the executable is, say, 2.1MB in size, we still want the first 2MB of the file to be covered with a PMD mapping.
Quoted 7 lines · Matthew Wilcox
Quoted 5 lines · Audra Mitchell
After commit
1854bc6e2420("mm/readahead: Align file mappings for non-DAX") any request throughthp_get_unmapped_areawould align to aPMD_SIZE, causing shared objects to have less randomization than previously (9 less bits for 2MB PMDs). As these lower 9 bits are the most impactful for ASLR, this change could be argued to have an impact on security.
Quoted 8 lines
Yes, very tiresome people have been making that argument for a long time. Do you have anything further to add to the discussion that happened here:
https://lore.kernel.org/linux-mm/[email protected]/
particularly in light of
3afb76a66b55existing.
Linus, however, disliked the config question and ended up reverting 3afb76a66b55 a while after.