Skip to contentSkip to conversation

dmaengine: idxd: Remove unused idxd_(un)register_bus_type

PATCH Applied [email protected] 3 participants 3 messages Dec 21, 2024 – Dec 24, 2024

Subsystems (2)
dmaengine Intel IDXD driver
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 dmaengine: idxd: Remove unused idxd_(un)register_bus_type

From: "Dr. David Alan Gilbert" <[email protected]>

idxd_register_bus_type() and idxd_unregister_bus_type() have been unused since 2021's
commit d9e5481fca74 ("dmaengine: dsa: move dsa_bus_type out of idxd driver to standalone")

Remove them.

Signed-off-by Dr. David Alan Gilbert <[email protected]>
---
 drivers/dma/idxd/idxd.h  |  2 --
 drivers/dma/idxd/sysfs.c | 10 ----------
 2 files changed, 12 deletions(-)
drivers/dma/idxd/idxd.h +0 -2
index d84e21daa991..ff33ebf08ee7 100644
@@ -725,8 +725,6 @@ static inline void idxd_desc_complete(struct idxd_desc *desc,
 				   &desc->txd, &status);
 }
 
-int idxd_register_bus_type(void);
-void idxd_unregister_bus_type(void);
 int idxd_register_devices(struct idxd_device *idxd);
 void idxd_unregister_devices(struct idxd_device *idxd);
 void idxd_wqs_quiesce(struct idxd_device *idxd);
drivers/dma/idxd/sysfs.c +0 -10
index f706eae0e76b..6af493f6ba77 100644
@@ -1979,13 +1979,3 @@ void idxd_unregister_devices(struct idxd_device *idxd)
 		device_unregister(group_confdev(group));
 	}
 }
-
-int idxd_register_bus_type(void)
-{
-	return bus_register(&dsa_bus_type);
-}
-
-void idxd_unregister_bus_type(void)
-{
-	bus_unregister(&dsa_bus_type);
-}
Signature · 1 line
2.47.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · On 12/21/24 06:16, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

idxd_register_bus_type() and idxd_unregister_bus_type() have been unused since 2021's
commit d9e5481fca74 ("dmaengine: dsa: move dsa_bus_type out of idxd driver to standalone")

Remove them.

Signed-off-by Dr. David Alan Gilbert <[email protected]>
Reviewed-by Fenghua Yu <[email protected]>
Quoted 26 lines
---
  drivers/dma/idxd/idxd.h  |  2 --
  drivers/dma/idxd/sysfs.c | 10 ----------
  2 files changed, 12 deletions(-)
drivers/dma/idxd/idxd.h +0 -2
index d84e21daa991..ff33ebf08ee7 100644
@@ -725,8 +725,6 @@ static inline void idxd_desc_complete(struct idxd_desc *desc,
  				   &desc->txd, &status);
  }
 
-int idxd_register_bus_type(void);
-void idxd_unregister_bus_type(void);
  int idxd_register_devices(struct idxd_device *idxd);
  void idxd_unregister_devices(struct idxd_device *idxd);
  void idxd_wqs_quiesce(struct idxd_device *idxd);
drivers/dma/idxd/sysfs.c +0 -0
index f706eae0e76b..6af493f6ba77 100644
@@ -1979,13 +1979,3 @@ void idxd_unregister_devices(struct idxd_device *idxd)
  		device_unregister(group_confdev(group));
  	}
  }

drivers/dma/idxd/sysfs.c void idxd_unregister_devices(struct idxd_device *idxd) · line 1991

Quoted 10 lines
drivers/dma/idxd/sysfs.c +0 -10
-
-int idxd_register_bus_type(void)
-{
-	return bus_register(&dsa_bus_type);
-}
-
-void idxd_unregister_bus_type(void)
-{
-	bus_unregister(&dsa_bus_type);
-}

Thanks.

-Fenghua

maintainer Applied
#2 lore raw
In reply to [email protected]
Quoted 8 lines · On Sat, 21 Dec 2024 14:16:35 +0000, [email protected] wrote:

idxd_register_bus_type() and idxd_unregister_bus_type() have been unused since 2021's
commit d9e5481fca74 ("dmaengine: dsa: move dsa_bus_type out of idxd driver to standalone")

Remove them.

[...]

Applied, thanks!

[1/1] dmaengine: idxd: Remove unused idxd_(un)register_bus_type

      commit: 308213731f8cc772245adb729ae2364fb1d20e98

Best regards,

Signature · 1 line
~Vinod