i3c: Remove unused i3c_device_do_setdasa
PATCH 1/1 i3c: Remove unused i3c_device_do_setdasa
From: "Dr. David Alan Gilbert" <[email protected]>
i3c_device_do_setdasa() was added in 2022 as part of commit 672825cd2823 ("i3c: export SETDASA method")
but has been unused.
It calls i3c_dev_setdasa_locked() which is now also unused.
Remove them both.
(This is effectively a revert of 672825cd2823).
--- drivers/i3c/device.c | 20 -------------------- drivers/i3c/internals.h | 1 - drivers/i3c/master.c | 19 ------------------- include/linux/i3c/device.h | 2 -- 4 files changed, 42 deletions(-)
drivers/i3c/device.c +0 -20
@@ -54,26 +54,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev, }EXPORT_SYMBOL_GPL (i3c_device_do_priv_xfers); -/** -* i3c_device_do_setdasa() - do I3C dynamic address assignement with -* static address -* -* @dev: device with which the DAA should be done -* -* Return: 0 in case of success, a negative error core otherwise. -*/ -int i3c_device_do_setdasa (struct i3c_device *dev) -{ -int ret; - -i3c_bus_normaluse_lock (dev->bus); - ret =i3c_dev_setdasa_locked (dev->desc); -i3c_bus_normaluse_unlock (dev->bus); - -return ret; -} -EXPORT_SYMBOL_GPL (i3c_device_do_setdasa); -/** * i3c_device_get_info() - get I3C device information *
drivers/i3c/internals.h +0 -1
@@ -13,7 +13,6 @@void i3c_bus_normaluse_lock (struct i3c_bus *bus);void i3c_bus_normaluse_unlock (struct i3c_bus *bus); -int i3c_dev_setdasa_locked (struct i3c_dev_desc *dev);int i3c_dev_do_priv_xfers_locked (struct i3c_dev_desc *dev,struct i3c_priv_xfer *xfers,int nxfers);
drivers/i3c/master.c +0 -19
@@ -2916,25 +2916,6 @@ void i3c_master_unregister(struct i3c_master_controller *master) }EXPORT_SYMBOL_GPL (i3c_master_unregister); -int i3c_dev_setdasa_locked (struct i3c_dev_desc *dev) -{ -struct i3c_master_controller *master; - -if (!dev) -return -ENOENT ; - - master =i3c_dev_get_master (dev); -if (!master) -return -EINVAL ; - -if (!dev->boardinfo || !dev->boardinfo->init_dyn_addr || - !dev->boardinfo->static_addr) -return -EINVAL ; - -return i3c_master_setdasa_locked (master, dev->info.static_addr, - dev->boardinfo->init_dyn_addr); -} -int i3c_dev_do_priv_xfers_locked (struct i3c_dev_desc *dev,struct i3c_priv_xfer *xfers,int nxfers)
include/linux/i3c/device.h +0 -2
@@ -301,8 +301,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev,struct i3c_priv_xfer *xfers, int nxfers); -int i3c_device_do_setdasa (struct i3c_device *dev); -void i3c_device_get_info (const struct i3c_device *dev,struct i3c_device_info *info);struct i3c_ibi_payload {
Signature · 1 line
2.47.1
Alexandre Belloni
maintainerHello,
Quoted 5 lines · On 21/12/2024 14:34:18+0000, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
i3c_device_do_setdasa()was added in 2022 as part of commit672825cd2823("i3c: export SETDASA method")
Quoted 7 lines
but has been unused.
It calls
i3c_dev_setdasa_locked()which is now also unused.Remove them both.
(This is effectively a revert of672825cd2823).
Yeah, i guess this just means that we didn't see the device driver yet. I'm going to keep those function around for now.
Quoted 97 lines
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- drivers/i3c/device.c | 20 -------------------- drivers/i3c/internals.h | 1 - drivers/i3c/master.c | 19 ------------------- include/linux/i3c/device.h | 2 -- 4 files changed, 42 deletions(-)drivers/i3c/device.c +0
-20@@ -54,26 +54,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev, }EXPORT_SYMBOL_GPL (i3c_device_do_priv_xfers); -/** -* i3c_device_do_setdasa() - do I3C dynamic address assignement with -* static address -* -* @dev: device with which the DAA should be done -* -* Return: 0 in case of success, a negative error core otherwise. -*/ -int i3c_device_do_setdasa (struct i3c_device *dev) -{ -int ret; - -i3c_bus_normaluse_lock (dev->bus); - ret =i3c_dev_setdasa_locked (dev->desc); -i3c_bus_normaluse_unlock (dev->bus); - -return ret; -} -EXPORT_SYMBOL_GPL (i3c_device_do_setdasa); -/** * i3c_device_get_info() - get I3C device information * drivers/i3c/internals.h +0
-1@@ -13,7 +13,6 @@void i3c_bus_normaluse_lock (struct i3c_bus *bus);void i3c_bus_normaluse_unlock (struct i3c_bus *bus); -int i3c_dev_setdasa_locked (struct i3c_dev_desc *dev);int i3c_dev_do_priv_xfers_locked (struct i3c_dev_desc *dev,struct i3c_priv_xfer *xfers,int nxfers);drivers/i3c/master.c +0
-19@@ -2916,25 +2916,6 @@ void i3c_master_unregister(struct i3c_master_controller *master) }EXPORT_SYMBOL_GPL (i3c_master_unregister); -int i3c_dev_setdasa_locked (struct i3c_dev_desc *dev) -{ -struct i3c_master_controller *master; - -if (!dev) -return -ENOENT ; - - master =i3c_dev_get_master (dev); -if (!master) -return -EINVAL ; - -if (!dev->boardinfo || !dev->boardinfo->init_dyn_addr || - !dev->boardinfo->static_addr) -return -EINVAL ; - -return i3c_master_setdasa_locked (master, dev->info.static_addr, - dev->boardinfo->init_dyn_addr); -} -int i3c_dev_do_priv_xfers_locked (struct i3c_dev_desc *dev,struct i3c_priv_xfer *xfers,int nxfers)include/linux/i3c/device.h +0
-2@@ -301,8 +301,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev,struct i3c_priv_xfer *xfers, int nxfers); -int i3c_device_do_setdasa (struct i3c_device *dev); -void i3c_device_get_info (const struct i3c_device *dev,struct i3c_device_info *info);struct i3c_ibi_payload {Signature · 1 line
2.47.1
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Quoted 12 lines · * Alexandre Belloni ([email protected]) wrote:
Hello,
Quoted 9 lines · On 21/12/2024 14:34:18+0000, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
i3c_device_do_setdasa()was added in 2022 as part of commit672825cd2823("i3c: export SETDASA method")but has been unused.
It calls
i3c_dev_setdasa_locked()which is now also unused.
Quoted 7 lines
Quoted 3 lines
Remove them both.
(This is effectively a revert of672825cd2823).Yeah, i guess this just means that we didn't see the device driver yet. I'm going to keep those function around for now.
OK, thanks for the review.
Dave
Quoted 103 lines
Quoted 97 lines
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- drivers/i3c/device.c | 20 -------------------- drivers/i3c/internals.h | 1 - drivers/i3c/master.c | 19 ------------------- include/linux/i3c/device.h | 2 -- 4 files changed, 42 deletions(-)drivers/i3c/device.c +0
-20@@ -54,26 +54,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev, }EXPORT_SYMBOL_GPL (i3c_device_do_priv_xfers); -/** -* i3c_device_do_setdasa() - do I3C dynamic address assignement with -* static address -* -* @dev: device with which the DAA should be done -* -* Return: 0 in case of success, a negative error core otherwise. -*/ -int i3c_device_do_setdasa (struct i3c_device *dev) -{ -int ret; - -i3c_bus_normaluse_lock (dev->bus); - ret =i3c_dev_setdasa_locked (dev->desc); -i3c_bus_normaluse_unlock (dev->bus); - -return ret; -} -EXPORT_SYMBOL_GPL (i3c_device_do_setdasa); -/** * i3c_device_get_info() - get I3C device information * drivers/i3c/internals.h +0
-1@@ -13,7 +13,6 @@void i3c_bus_normaluse_lock (struct i3c_bus *bus);void i3c_bus_normaluse_unlock (struct i3c_bus *bus); -int i3c_dev_setdasa_locked (struct i3c_dev_desc *dev);int i3c_dev_do_priv_xfers_locked (struct i3c_dev_desc *dev,struct i3c_priv_xfer *xfers,int nxfers);drivers/i3c/master.c +0
-19@@ -2916,25 +2916,6 @@ void i3c_master_unregister(struct i3c_master_controller *master) }EXPORT_SYMBOL_GPL (i3c_master_unregister); -int i3c_dev_setdasa_locked (struct i3c_dev_desc *dev) -{ -struct i3c_master_controller *master; - -if (!dev) -return -ENOENT ; - - master =i3c_dev_get_master (dev); -if (!master) -return -EINVAL ; - -if (!dev->boardinfo || !dev->boardinfo->init_dyn_addr || - !dev->boardinfo->static_addr) -return -EINVAL ; - -return i3c_master_setdasa_locked (master, dev->info.static_addr, - dev->boardinfo->init_dyn_addr); -} -int i3c_dev_do_priv_xfers_locked (struct i3c_dev_desc *dev,struct i3c_priv_xfer *xfers,int nxfers)include/linux/i3c/device.h +0
-2@@ -301,8 +301,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev,struct i3c_priv_xfer *xfers, int nxfers); -int i3c_device_do_setdasa (struct i3c_device *dev); -void i3c_device_get_info (const struct i3c_device *dev,struct i3c_device_info *info);struct i3c_ibi_payload {Signature · 1 line
2.47.1Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
Quoted 13 lines · Alexandre Belloni
Hello,
Quoted 10 lines · On 21/12/2024 14:34:18+0000, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
i3c_device_do_setdasa()was added in 2022 as part of commit672825cd2823("i3c: export SETDASA method")but has been unused.
It calls
i3c_dev_setdasa_locked()which is now also unused.Remove them both.
I think there might be few drivers in future, which can use. The function looks good to be used.
Quoted 7 lines
Quoted 2 lines
(This is effectively a revert of
672825cd2823).Yeah, i guess this just means that we didn't see the device driver yet. I'm going to keep those function around for now.
Agree here. We should keep this function as is.
Quoted 98 lines
Quoted 97 lines
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- drivers/i3c/device.c | 20 -------------------- drivers/i3c/internals.h | 1 - drivers/i3c/master.c | 19 ------------------- include/linux/i3c/device.h | 2 -- 4 files changed, 42 deletions(-)drivers/i3c/device.c +0
-20@@ -54,26 +54,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev, }EXPORT_SYMBOL_GPL (i3c_device_do_priv_xfers); -/** -* i3c_device_do_setdasa() - do I3C dynamic address assignement with -* static address -* -* @dev: device with which the DAA should be done -* -* Return: 0 in case of success, a negative error core otherwise. -*/ -int i3c_device_do_setdasa (struct i3c_device *dev) -{ -int ret; - -i3c_bus_normaluse_lock (dev->bus); - ret =i3c_dev_setdasa_locked (dev->desc); -i3c_bus_normaluse_unlock (dev->bus); - -return ret; -} -EXPORT_SYMBOL_GPL (i3c_device_do_setdasa); -/** * i3c_device_get_info() - get I3C device information * drivers/i3c/internals.h +0
-1@@ -13,7 +13,6 @@void i3c_bus_normaluse_lock (struct i3c_bus *bus);void i3c_bus_normaluse_unlock (struct i3c_bus *bus); -int i3c_dev_setdasa_locked (struct i3c_dev_desc *dev);int i3c_dev_do_priv_xfers_locked (struct i3c_dev_desc *dev,struct i3c_priv_xfer *xfers,int nxfers);drivers/i3c/master.c +0
-19@@ -2916,25 +2916,6 @@ void i3c_master_unregister(struct i3c_master_controller *master) }EXPORT_SYMBOL_GPL (i3c_master_unregister); -int i3c_dev_setdasa_locked (struct i3c_dev_desc *dev) -{ -struct i3c_master_controller *master; - -if (!dev) -return -ENOENT ; - - master =i3c_dev_get_master (dev); -if (!master) -return -EINVAL ; - -if (!dev->boardinfo || !dev->boardinfo->init_dyn_addr || - !dev->boardinfo->static_addr) -return -EINVAL ; - -return i3c_master_setdasa_locked (master, dev->info.static_addr, - dev->boardinfo->init_dyn_addr); -} -int i3c_dev_do_priv_xfers_locked (struct i3c_dev_desc *dev,struct i3c_priv_xfer *xfers,int nxfers)include/linux/i3c/device.h +0
-2@@ -301,8 +301,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev,struct i3c_priv_xfer *xfers, int nxfers); -int i3c_device_do_setdasa (struct i3c_device *dev); -void i3c_device_get_info (const struct i3c_device *dev,struct i3c_device_info *info);struct i3c_ibi_payload {Signature · 1 line
2.47.1