Skip to contentSkip to conversation

package/elfutils: bump to version 0.192

PATCH Applied Thomas Bonnefille via buildroot 1 participant 4 messages Dec 22, 2024 – Feb 5, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/elfutils: bump to version 0.192

Fixes:

    https://autobuild.buildroot.org/results/29502fe97a15e4926de7cf129b641505697de9cd/
---
 ...d-a-enable-disable-progs-configure-option.patch | 22 ++++++++++++----------
 package/elfutils/elfutils.hash                     |  2 +-
 package/elfutils/elfutils.mk                       |  2 +-
 3 files changed, 14 insertions(+), 12 deletions(-)
package/elfutils/0001-Add-a-enable-disable-progs-configure-option.patch +12 -10
index bac9bc124579befb13446ef8f18014aab856c786..7f6dff94f09cc4ccc3cc0f07c0033a848fff4535 100644
@@ -1,4 +1,4 @@
-From 73e4da5ca780196d23db8029dcd28f87a0402711 Mon Sep 17 00:00:00 2001
+From 571445ec4643865566d2c5a9e27d9b78b8b00107 Mon Sep 17 00:00:00 2001
 From: Thomas Petazzoni <[email protected]>
 Date: Mon, 29 May 2017 23:03:48 +0300
 Subject: [PATCH] Add a --{enable,disable}-progs configure option
@@ -22,13 +22,15 @@ Signed-off-by: Bernd Kuhls <[email protected]>
 Signed-off-by: Peter Seiderer <[email protected]>
 [Fabrice: don't error out if obstack is not found]
 Signed-off-by: Fabrice Fontaine <[email protected]>
+[Rebased on 0.192]
+Signed-off-by: Thomas Bonnefille <[email protected]>
 ---
  Makefile.am  | 6 +++++-
- configure.ac | 6 ++++++
- 2 files changed, 11 insertions(+), 1 deletion(-)
+ configure.ac | 8 +++++++-
+ 2 files changed, 12 insertions(+), 2 deletions(-)
 
 diff --git a/Makefile.am b/Makefile.am
-index 9c47afa..edf8dfc 100644
+index 92130b57..00f5176b 100644
 --- a/Makefile.am
 +++ b/Makefile.am
 @@ -26,8 +26,12 @@ AM_MAKEFLAGS = --no-print-directory
@@ -43,13 +45,13 @@ index 9c47afa..edf8dfc 100644
 -	  libasm debuginfod src po doc tests
 +	  libasm debuginfod $(PROGS_SUBDIR) po doc tests
  
- EXTRA_DIST = elfutils.spec GPG-KEY NOTES CONTRIBUTING \
- 	     COPYING COPYING-GPLV2 COPYING-LGPLV3
+ EXTRA_DIST = elfutils.spec GPG-KEY NOTES CONTRIBUTING SECURITY \
+ 	     COPYING COPYING-GPLV2 COPYING-LGPLV3 CONDUCT
 diff --git a/configure.ac b/configure.ac
-index d345495..0dd4b1e 100644
+index f191488f..87d91f8f 100644
 --- a/configure.ac
 +++ b/configure.ac
-@@ -393,6 +393,12 @@ AS_HELP_STRING([--enable-tests-rpath],[build $ORIGIN-using rpath into tests]),
+@@ -426,6 +426,12 @@ AS_HELP_STRING([--enable-tests-rpath],[build $ORIGIN-using rpath into tests]),
  	       [tests_use_rpath=$enableval], [tests_use_rpath=no])
  AM_CONDITIONAL(TESTS_RPATH, test "$tests_use_rpath" = yes)
  
@@ -62,7 +64,7 @@ index d345495..0dd4b1e 100644
  dnl zlib is mandatory.
  save_LIBS="$LIBS"
  LIBS=
-@@ -579,7 +585,7 @@ saved_LIBS="$LIBS"
+@@ -670,7 +676,7 @@ saved_LIBS="$LIBS"
  AC_SEARCH_LIBS([_obstack_free], [obstack])
  LIBS="$saved_LIBS"
  case "$ac_cv_search__obstack_free" in
@@ -72,5 +74,5 @@ index d345495..0dd4b1e 100644
          *) obstack_LIBS= ;;
  esac
 -- 
-2.30.1
+2.47.1
 
package/elfutils/elfutils.hash +1 -1
index e3cc67dc0e5bc957d2208eaf4f7200e9e59895a7..19f628de46d2899d9ec14db0258eb692e5cb084f 100644
@@ -1,5 +1,5 @@
 # From https://sourceware.org/elfutils/ftp/0.189/sha512.sum
-sha512  93a877e34db93e5498581d0ab2d702b08c0d87e4cafd9cec9d6636dfa85a168095c305c11583a5b0fb79374dd93bc8d0e9ce6016e6c172764bcea12861605b71  elfutils-0.189.tar.bz2
+sha512  543188f5f2cfe5bc7955a878416c5f252edff9926754e5de0c6c57b132f21d9285c9b29e41281e93baad11d4ae7efbbf93580c114579c182103565fe99bd3909  elfutils-0.192.tar.bz2
 # Locally calculated
 sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  COPYING
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING-GPLV2
package/elfutils/elfutils.mk +1 -1
index 8738af7751fdb8adc06e95ac476b0e5881f2a9e9..e7c2efe86750f9f6f44c3614be9f73a942be4a0a 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-ELFUTILS_VERSION = 0.189
+ELFUTILS_VERSION = 0.192
 ELFUTILS_SOURCE = elfutils-$(ELFUTILS_VERSION).tar.bz2
 ELFUTILS_SITE = https://sourceware.org/elfutils/ftp/$(ELFUTILS_VERSION)
 ELFUTILS_INSTALL_STAGING = YES

---
base-commit: 87706103a6bdee8ed3b6ea51b45626aa9d2185ab
change-id: 20241222-bump_elfutils-70cdd46c0533

Best regards,

Signature · 6 lines
Thomas Bonnefille <[email protected]>

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Thomas,

Quoted 4 lines · On Sun, 22 Dec 2024 15:57:23 +0100 Thomas Bonnefille via buildroot…

Fixes:

    https://autobuild.buildroot.org/results/29502fe97a15e4926de7cf129b641505697de9cd/

Thanks for the fix. However, we need to understand since when this problem started occurring so we can understand whether the fix needs to be backported to our stable 2024.02.x branch.

Also, a 0.189 -> 0.192 bump brings quite a lot of other changes. Can we have a more minimal fix to backport? (And then do the version bump).

When fixing build issues, we're not only concerned about fixing the build issue, but also about understanding whether it needs to be fixed in 2024.02.x, which requires providing more details in the commit log *and* figuring out whether a more minimal solution than a bump is possible (sometimes the answer is "no", or "yes, but very complicated", and that's fine).

Thanks a lot,

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Hello Thomas,

Quoted 4 lines

On Sun, 22 Dec 2024 15:57:23 +0100
Thomas Bonnefille via buildroot <[email protected]> wrote:

Quoted 8 lines
Quoted 4 lines

Fixes:

    https://autobuild.buildroot.org/results/29502fe97a15e4926de7cf129b641505697de9cd/

Thanks for the fix. However, we need to understand since when this problem started occurring so we can understand whether the fix needs to be backported to our stable 2024.02.x branch.

I did investigate a little deeper the issue, and it seems to occure when using gcc14 and musl, as gcc14 isn't supported on 2024.02.x, I didn't succeed to reproduce the error.

Quoted 3 lines

Also, a 0.189 -> 0.192 bump brings quite a lot of other changes. Can we have a more minimal fix to backport? (And then do the version bump).

Indeed, a more minimal fix is to backport [this patch](https://patchwork.sourceware.org/project/elfutils/patch/[email protected]/#162118). This is something that I did and can send in a follow up patch if
required.

Quoted 7 lines

When fixing build issues, we're not only concerned about fixing the build issue, but also about understanding whether it needs to be fixed in 2024.02.x, which requires providing more details in the commit log *and* figuring out whether a more minimal solution than a bump is possible (sometimes the answer is "no", or "yes, but very complicated", and that's fine).

Thank you very much for thoses explanations, here the answer is yes however as it can't be reproduced in the LTS and as a bump will be required one day, is it necessary to first give a minimal solution ?

Thomas
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
In reply to Thomas Bonnefille via buildroot

Hello Thomas,

Quoted 9 lines · On Sun, 22 Dec 2024 15:57:23 +0100 Thomas Bonnefille via buildroot…

Fixes:

    https://autobuild.buildroot.org/results/29502fe97a15e4926de7cf129b641505697de9cd/
---
 ...d-a-enable-disable-progs-configure-option.patch | 22 ++++++++++++----------
 package/elfutils/elfutils.hash                     |  2 +-
 package/elfutils/elfutils.mk                       |  2 +-
 3 files changed, 14 insertions(+), 12 deletions(-)

Applied to master after splitting up the fix from the bump into two commits. One commit backports the fix. The other commit does the bump, while dropping the fix (as it's upstream).

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot