hyperv: Fixes for get_vtl(void)
Subsystems (3)
v2 cover hyperv: Fixes for get_vtl(void)
The get_vtl(void) function
* has got one bug when the code started using a wrong pointer type after refactoring, and also
* it doesn't adhere to the requirements of the Hypervisor Top-Level Funactional Specification[1, 2] as the code overlaps the input and output areas for a hypercall.
The first issue leads to a wrong 100% reproducible computation due to reading a byte worth of data at a wrong offset. That in turn leads to using a nonsensical value ("fortunately", could catch it easily!) for the current VTL when initiating VMBus communications. As a repercussion from that, the system wouldn't boot. The fix is straightforward: use the correct pointer type.
The second issue doesn't seem to lead to any reproducible breakage just yet. It is fixed with using the output hypercall pages allocated per-CPU, and that isn't the only or the most obvious choice so let me elaborate why that fix appears to be the best one in my opinion out of the options I could conceive of.
The approach chosen for fixing the second issue makes two things shine through:
* get_vtl(void) is just getting a vCPU register, no special treatment needs to be involved,
* VTLs and dom0 can and should share code as both exist to provide services to a guest(s), be that from within the partition or from outside of it.
The projected benefits include replacing the function in question with a future hv_get_vp_registers one shared between dom0 and VTLs to allow for a better test coverage.
I have validated the fixes by booting the fixed kernel in VTL2 up using OpenVMM and OpenHCL[3, 4].
[1] https://learn.microsoft.com/en-us/virtualization/hyper-v-on-windows/tlfs/hypercall-interface
[2] https://github.com/MicrosoftDocs/Virtualization-Documentation/tree/main/tlfs
[3] https://openvmm.dev/guide/user_guide/openhcl.html
[4] https://github.com/microsoft/OpenVMM
[v2]
- Used the suggestions to define an additional structure to improve code readability,
- Split out the patch with that definition.
[v1]: https://lore.kernel.org/lkml/[email protected]/
Roman Kisel (3):
hyperv: Define struct hv_output_get_vp_registers
hyperv: Fix pointer type for the output of the hypercall in
get_vtl(void)
hyperv: Do not overlap the input and output hypercall areas in
get_vtl(void)
arch/x86/hyperv/hv_init.c | 6 ++-- drivers/hv/hv_common.c | 6 ++-- include/hyperv/hvgdk_mini.h | 58 +++++++++++++++++++++++++++++++++++-- 3 files changed, 62 insertions(+), 8 deletions(-)
base-commit: 4d4ace979a3066e5c940331571e6c1c3f280d1d3
Signature · 1 line
2.34.1
PATCH v2 1/3 hyperv: Define struct hv_output_get_vp_registers
There is no definition of the output structure for the GetVpRegisters hypercall. Hence, using the hypercall is not possible when the output value has some structure to it. Even getting a datum of a primitive type reads as ad-hoc without that definition.
Define struct hv_output_get_vp_registers to enable using the GetVpRegisters hypercall. Make provisions for all supported architectures. No functional changes.
--- include/hyperv/hvgdk_mini.h | 58 +++++++++++++++++++++++++++++++++++-- 1 file changed, 56 insertions(+), 2 deletions(-)
include/hyperv/hvgdk_mini.h +56 -2
@@ -781,6 +781,8 @@ struct hv_timer_message_payload {__u64 delivery_time;/* When the message was delivered */ } __packed; +#if defined(CONFIG_X86) + struct hv_x64_segment_register { u64 base; u32 limit;
@@ -807,6 +809,8 @@ struct hv_x64_table_register {u64 base; } __packed; +#endif +union hv_input_vtl {u8 as_uint8;struct {
@@ -1068,6 +1072,41 @@ union hv_dispatch_suspend_register { } __packed; }; +#if defined(CONFIG_ARM64 ) + +union hv_arm64_pending_interruption_register { +u64 as_uint64; +struct { +u64 interruption_pending :1 ; +u64 interruption_type :1 ; +u64 reserved :30 ; +u32 error_code; + } __packed; +}; + +union hv_arm64_interrupt_state_register { +u64 as_uint64; +struct { +u64 interrupt_shadow :1 ; +u64 reserved :63 ; + } __packed; +}; + +union hv_arm64_pending_synthetic_exception_event { +u64 as_uint64[2 ]; +struct { +u32 event_pending :1 ; +u32 event_type :3 ; +u32 reserved :4 ; +u32 exception_type; +u64 context; + } __packed; +}; + +#endif + +#if defined(CONFIG_X86) + union hv_x64_interrupt_state_register { u64 as_uint64; struct {
@@ -1091,6 +1130,8 @@ union hv_x64_pending_interruption_register { } __packed; }; +#endif +union hv_register_value {struct hv_u128 reg128;u64 reg64;
@@ -1098,13 +1139,26 @@ union hv_register_value {u16 reg16;u8 reg8; -struct hv_x64_segment_register segment; -struct hv_x64_table_register table;union hv_explicit_suspend_register explicit_suspend;union hv_intercept_suspend_register intercept_suspend;union hv_dispatch_suspend_register dispatch_suspend; +#if defined(CONFIG_X86 ) +struct hv_x64_segment_register segment; +struct hv_x64_table_register table;union hv_x64_interrupt_state_register interrupt_state;union hv_x64_pending_interruption_register pending_interruption; +#elif defined(CONFIG_ARM64 ) +union hv_arm64_pending_interruption_register pending_interruption; +union hv_arm64_interrupt_state_register interrupt_state; +union hv_arm64_pending_synthetic_exception_event pending_synthetic_exception_event; +#else +#error "This architecture is not supported" +#endif +}; + +/* NOTE: Linux helper struct - NOT from Hyper-V code */ +struct hv_output_get_vp_registers { + DECLARE_FLEX_ARRAY(union hv_register_value, values); };#if defined(CONFIG_ARM64 )
Signature · 1 line
2.34.1
PATCH v2 2/3 hyperv: Fix pointer type for the output of the hypercall in get_vtl(void)
In reply to Roman KiselCommit bc905fa8b633 ("hyperv: Switch from hyperv-tlfs.h to hyperv/hvhdk.h") changed the type of the output pointer to struct hv_register_assoc from struct hv_get_vp_registers_output. That leads to an incorrect computation, and leaves the system broken.
Use the correct pointer type for the output of the GetVpRegisters hypercall.
--- arch/x86/hyperv/hv_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/x86/hyperv/hv_init.c +3 -3
@@ -416,13 +416,13 @@ static u8 __init get_vtl(void) {u64 control =HV_HYPERCALL_REP_COMP_1 |HVCALL_GET_VP_REGISTERS ;struct hv_input_get_vp_registers *input; -struct hv_register_assoc *output; +struct hv_output_get_vp_registers *output;unsigned long flags;u64 ret;local_irq_save (flags); input = *this_cpu_ptr (hyperv_pcpu_input_arg); - output = (struct hv_register_assoc *)input; + output = (struct hv_output_get_vp_registers *)input;memset (input,0 ,struct_size (input, names,1 )); input->partition_id =HV_PARTITION_ID_SELF ;
@@ -432,7 +432,7 @@ static u8 __init get_vtl(void) ret =hv_do_hypercall (control, input, output);if (hv_result_success (ret)) { - ret = output->value.reg8 &HV_X64_VTL_MASK ; + ret = output->values[0 ].reg8 &HV_X64_VTL_MASK ; }else {pr_err ("Failed to get VTL(error: %lld) exiting...\n" , ret);BUG ();
Signature · 1 line
2.34.1
PATCH v2 3/3 hyperv: Do not overlap the input and output hypercall areas in get_vtl(void)
In reply to Roman KiselThe Top-Level Functional Specification for Hyper-V, Section 3.6 [1, 2], disallows overlapping of the input and output hypercall areas, and get_vtl(void) does overlap them.
To fix this, enable allocation of the output hypercall pages when running in the VTL mode and use the output hypercall page of the current vCPU for the hypercall.
[1] https://learn.microsoft.com/en-us/virtualization/hyper-v-on-windows/tlfs/hypercall-interface
[2] https://github.com/MicrosoftDocs/Virtualization-Documentation/tree/main/tlfs
--- arch/x86/hyperv/hv_init.c | 2 +- drivers/hv/hv_common.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
arch/x86/hyperv/hv_init.c +1 -1
@@ -422,7 +422,7 @@ static u8 __init get_vtl(void)local_irq_save (flags); input = *this_cpu_ptr (hyperv_pcpu_input_arg); - output = (struct hv_output_get_vp_registers *)input; + output = *this_cpu_ptr (hyperv_pcpu_output_arg);memset (input,0 ,struct_size (input, names,1 )); input->partition_id =HV_PARTITION_ID_SELF ;
drivers/hv/hv_common.c +3 -3
@@ -340,7 +340,7 @@ int __init hv_common_init(void)BUG_ON (!hyperv_pcpu_input_arg);/* Allocate the per-CPU state for output arg for root */ -if (hv_root_partition) { +if (hv_root_partition ||IS_ENABLED (CONFIG_HYPERV_VTL_MODE )) { hyperv_pcpu_output_arg = alloc_percpu(void *);BUG_ON (!hyperv_pcpu_output_arg); }
@@ -435,7 +435,7 @@ int hv_common_cpu_init(unsigned int cpu)void **inputarg, **outputarg;u64 msr_vp_index;gfp_t flags; -int pgcount = hv_root_partition ?2 :1 ; +const int pgcount = (hv_root_partition ||IS_ENABLED (CONFIG_HYPERV_VTL_MODE )) ?2 :1 ;void *mem;int ret;
@@ -453,7 +453,7 @@ int hv_common_cpu_init(unsigned int cpu)if (!mem)return -ENOMEM ; -if (hv_root_partition) { +if (hv_root_partition ||IS_ENABLED (CONFIG_HYPERV_VTL_MODE )) { outputarg = (void **)this_cpu_ptr (hyperv_pcpu_output_arg); *outputarg = (char *)mem +HV_HYP_PAGE_SIZE ; }
Signature · 1 line
2.34.1