tools: fix atomic_set() definition to set the value correctly
Subsystems (3)
PATCH 1/1 tools: fix atomic_set() definition to set the value correctly
Currently vma test is failing because of the new vma_assert_attached() assertion. The check is failing because previous refcount_set() inside vma_mark_attached() is a NoOp. Fix the definition of atomic_set() to correctly set the value of the atomic.
Fixes 9325b8b5a1cb ("tools: add skeleton code for userland testing of VMA logic")
Signed-off-by Suren Baghdasaryan <[email protected]>
---
Applies over mm-unstable
tools/testing/shared/linux/maple_tree.h | 2 +- tools/testing/vma/linux/atomic.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
tools/testing/shared/linux/maple_tree.h +1 -1
@@ -2,6 +2,6 @@#define atomic_t int32_t#define atomic_inc (x) uatomic_inc(x)#define atomic_read (x) uatomic_read(x) -#define atomic_set (x, y) do {} while (0) +#define atomic_set (x, y) uatomic_set(x, y)#define U8_MAX UCHAR_MAX#include "../../../../include/linux/maple_tree.h"
tools/testing/vma/linux/atomic.h +1 -1
@@ -6,7 +6,7 @@#define atomic_t int32_t#define atomic_inc (x) uatomic_inc(x)#define atomic_read (x) uatomic_read(x) -#define atomic_set (x, y) do {} while (0) +#define atomic_set (x, y) uatomic_set(x, y)#define U8_MAX UCHAR_MAX#ifndef atomic_cmpxchg_relaxed
Signature · 1 line
2.47.1.613.gc27f4b7a9f-goog
Quoted 7 lines · Suren Baghdasaryan
Currently vma test is failing because of the new
vma_assert_attached()assertion. The check is failing because previousrefcount_set()insidevma_mark_attached()is a NoOp. Fix the definition ofatomic_set()to correctly set the value of the atomic.Fixes 9325b8b5a1cb ("tools: add skeleton code for userland testing of VMA logic")Signed-off-by Suren Baghdasaryan <[email protected]>
LGTM:
Reviewed-by Lorenzo Stoakes <[email protected]>
Quoted 35 lines
---
Applies over mm-unstabletools/testing/shared/linux/maple_tree.h | 2 +- tools/testing/vma/linux/atomic.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)tools/testing/shared/linux/maple_tree.h +1
-1@@ -2,6 +2,6 @@#define atomic_t int32_t#define atomic_inc (x) uatomic_inc(x)#define atomic_read (x) uatomic_read(x) -#define atomic_set (x, y) do {} while (0) +#define atomic_set (x, y) uatomic_set(x, y)#define U8_MAX UCHAR_MAX#include "../../../../include/linux/maple_tree.h" tools/testing/vma/linux/atomic.h +1
-2@@ -6,7 +6,7 @@#define atomic_t int32_t#define atomic_inc (x) uatomic_inc(x)#define atomic_read (x) uatomic_read(x) -#define atomic_set (x, y) do {} while (0) +#define atomic_set (x, y) uatomic_set(x, y)#define U8_MAX UCHAR_MAX#ifndef atomic_cmpxchg_relaxed --2.47.1.613.gc27f4b7a9f-goog