Skip to contentSkip to conversation

x86/sev: Disable UBSAN on SEV code that may execute very early

PATCH Applied Ard Biesheuvel 3 participants 3 messages Jan 1, 2025 – Jan 2, 2025 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/sev: Disable UBSAN on SEV code that may execute very early

Clang 14 and older may emit UBSAN instrumentation into code that is inlined into functions marked with __no_sanitize_undefined. This may result in faults when the code is executed very early, which may be the case for functions annotated as __head. Now that this requirement is strictly enforced, the build will fail in this case with the following message

Absolute reference to symbol '.data' not permitted in .head.text

Work around this by disabling UBSAN instrumentation on all SEV core code.

Cc Borislav Petkov <[email protected]>
Cc Nathan Chancellor <[email protected]>
---
 arch/x86/coco/sev/Makefile | 3 +++
 1 file changed, 3 insertions(+)
arch/x86/coco/sev/Makefile +3 -0
index 4e375e7305ac..08de37559307 100644
@@ -13,3 +13,6 @@ KCOV_INSTRUMENT_core.o	:= n
 # With some compiler versions the generated code results in boot hangs, caused
 # by several compilation units. To be safe, disable all instrumentation.
 KCSAN_SANITIZE		:= n
+
+# Clang 14 and older may fail to respect __no_sanitize_undefined when inlining
+UBSAN_SANITIZE		:= n
Signature · 1 line
2.45.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Ard Biesheuvel

Clang 14 and older may emit UBSAN instrumentation into code that is inlined into functions marked with __no_sanitize_undefined. This may result in faults when the code is executed very early, which may be the case for functions annotated as __head. Now that this requirement is strictly enforced, the build will fail in this case with the following message

Quoted 8 lines

Absolute reference to symbol '.data' not permitted in .head.text

Work around this by disabling UBSAN instrumentation on all SEV core code.

Cc Borislav Petkov <[email protected]>
Cc Nathan Chancellor <[email protected]>

Seems reasonable to me.

Quoted 18 lines
---
 arch/x86/coco/sev/Makefile | 3 +++
 1 file changed, 3 insertions(+)
arch/x86/coco/sev/Makefile +3 -0
index 4e375e7305ac..08de37559307 100644
@@ -13,3 +13,6 @@ KCOV_INSTRUMENT_core.o	:= n
 # With some compiler versions the generated code results in boot hangs, caused
 # by several compilation units. To be safe, disable all instrumentation.
 KCSAN_SANITIZE		:= n
+
+# Clang 14 and older may fail to respect __no_sanitize_undefined when inlining
+UBSAN_SANITIZE		:= n
Signature · 1 line
2.45.2
merge bot Applied
#2 lore raw
In reply to Ard Biesheuvel
The following commit has been merged into the x86/boot branch of tip:

The following commit has been merged into the x86/boot branch of tip:

Commit-ID:     99b863d2e87210c70354a1c75cc5bcc7a3afdc01
Gitweb:        https://git.kernel.org/tip/99b863d2e87210c70354a1c75cc5bcc7a3afdc01
Author:        Ard Biesheuvel <[email protected]>
AuthorDate:    Wed, 01 Jan 2025 12:51:20 +01:00
Committer:     Borislav Petkov (AMD) <[email protected]>
CommitterDate: Thu, 02 Jan 2025 12:13:13 +01:00

x86/sev: Disable UBSAN on SEV code that may execute very early

Clang 14 and older may emit UBSAN instrumentation into code that is inlined into functions marked with __no_sanitize_undefined¹. This may result in faults when the code is executed very early, which may be the case for functions annotated as __head. Now that this requirement is strictly enforced, the build will fail in this case with the following message

Absolute reference to symbol '.data' not permitted in .head.text

Work around this by disabling UBSAN instrumentation on all SEV core code.

¹ https://lore.kernel.org/r/20250101024348.GA1828419@ax162

[ bp: Add a footnote with Nathan's detailed explanation and a Fixes
tag ]

---
 arch/x86/coco/sev/Makefile | 3 +++
 1 file changed, 3 insertions(+)
arch/x86/coco/sev/Makefile +3 -0
index 4e375e7..08de375 100644
@@ -13,3 +13,6 @@ KCOV_INSTRUMENT_core.o	:= n
 # With some compiler versions the generated code results in boot hangs, caused
 # by several compilation units. To be safe, disable all instrumentation.
 KCSAN_SANITIZE		:= n
+
+# Clang 14 and older may fail to respect __no_sanitize_undefined when inlining
+UBSAN_SANITIZE		:= n