Skip to contentSkip to conversation

PCI/DPC: Yet another quirk for PIO log size on Intel Raptor Lake-P

PATCH Applied Takashi Iwai 3 participants 5 messages Jan 2, 2025 – Jan 14, 2025 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI/DPC: Yet another quirk for PIO log size on Intel Raptor Lake-P

There is yet another PCI entry for Intel Raptor Lake-P that shows the
error "DPC: RP PIO log size 0 is invalid":
0000:00:07.0 PCI bridge [0604]: Intel Corporation Raptor Lake-P Thunderbolt 4 PCI Express Root Port #0 [8086:a76e] 0000:00:07.2 PCI bridge [0604]: Intel Corporation Raptor Lake-P Thunderbolt 4 PCI Express Root Port #2 [8086:a72f]

Add the corresponding quirk entry for 8086:a72f.

Note that the one for 8086:a76e has been already added by the commit 627c6db20703 ("PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root Ports").

---
 drivers/pci/quirks.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/quirks.c +1 -0
index 76f4df75b08a..4ed3704ce92e 100644
@@ -6253,6 +6253,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2b, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2d, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2f, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a31, dpc_log_size);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa72f, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa73f, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa76e, dpc_log_size);
 #endif
Signature · 1 line
2.43.0
#1 lore raw
Quoted 10 lines · Takashi Iwai

There is yet another PCI entry for Intel Raptor Lake-P that shows the
error "DPC: RP PIO log size 0 is invalid":
0000:00:07.0 PCI bridge [0604]: Intel Corporation Raptor Lake-P Thunderbolt 4 PCI Express Root Port #0 [8086:a76e] 0000:00:07.2 PCI bridge [0604]: Intel Corporation Raptor Lake-P Thunderbolt 4 PCI Express Root Port #2 [8086:a72f]

Add the corresponding quirk entry for 8086:a72f.

Note that the one for 8086:a76e has been already added by the commit 627c6db20703 ("PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root Ports").

Intel folks, what's the long-term resolution of this? I'm kind of tired of adding quirks like this. So far we have these (not including the current patch), dating back to Aug 2022:

627c6db20703 ("PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root Ports") 3b8803494a06 ("PCI/DPC: Quirk PIO log size for Intel Ice Lake Root Ports") 5459c0b70467 ("PCI/DPC: Quirk PIO log size for certain Intel Root Ports")

I *thought* this problem was caused by BIOS defects that were supposed to be fixed, but nothing seems to be happening.

If Linux can't figure out the correct value by itself (and I assume it can't because we wouldn't need the register if we could), maybe we can just silently ignore it and live without the RP logs?

Quoted 21 lines
---
 drivers/pci/quirks.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/quirks.c +1 -0
index 76f4df75b08a..4ed3704ce92e 100644
@@ -6253,6 +6253,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2b, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2d, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2f, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a31, dpc_log_size);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa72f, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa73f, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa76e, dpc_log_size);
 #endif
Signature · 1 line
2.43.0
#2 lore raw

Hi,

Quoted 16 lines · Bjorn Helgaas
Quoted 10 lines · Takashi Iwai

There is yet another PCI entry for Intel Raptor Lake-P that shows the
error "DPC: RP PIO log size 0 is invalid":
0000:00:07.0 PCI bridge [0604]: Intel Corporation Raptor Lake-P Thunderbolt 4 PCI Express Root Port #0 [8086:a76e] 0000:00:07.2 PCI bridge [0604]: Intel Corporation Raptor Lake-P Thunderbolt 4 PCI Express Root Port #2 [8086:a72f]

Add the corresponding quirk entry for 8086:a72f.

Note that the one for 8086:a76e has been already added by the commit 627c6db20703 ("PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root Ports").

Intel folks, what's the long-term resolution of this? I'm kind of tired of adding quirks like this. So far we have these (not including the current patch), dating back to Aug 2022:

Quoted 6 lines

627c6db20703 ("PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root Ports") 3b8803494a06 ("PCI/DPC: Quirk PIO log size for Intel Ice Lake Root Ports") 5459c0b70467 ("PCI/DPC: Quirk PIO log size for certain Intel Root Ports")

I *thought* this problem was caused by BIOS defects that were supposed to be fixed, but nothing seems to be happening.

As far as I know it should be fixed already. I just checked my MTLP and PTL systems (both with integrated TBT PCIe root ports) and I don't see the message anymore. I don't have RPL system though. This is on reference hardware and BIOS so it is possible that the fix has not been taken into the OEM BIOS.

#3 lore raw
Quoted 24 lines · Mika Westerberg

Hi,

Quoted 20 lines · Bjorn Helgaas
Quoted 10 lines · Takashi Iwai

There is yet another PCI entry for Intel Raptor Lake-P that shows the
error "DPC: RP PIO log size 0 is invalid":
0000:00:07.0 PCI bridge [0604]: Intel Corporation Raptor Lake-P Thunderbolt 4 PCI Express Root Port #0 [8086:a76e] 0000:00:07.2 PCI bridge [0604]: Intel Corporation Raptor Lake-P Thunderbolt 4 PCI Express Root Port #2 [8086:a72f]

Add the corresponding quirk entry for 8086:a72f.

Note that the one for 8086:a76e has been already added by the commit 627c6db20703 ("PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root Ports").

Intel folks, what's the long-term resolution of this? I'm kind of tired of adding quirks like this. So far we have these (not including the current patch), dating back to Aug 2022:

627c6db20703 ("PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root Ports") 3b8803494a06 ("PCI/DPC: Quirk PIO log size for Intel Ice Lake Root Ports") 5459c0b70467 ("PCI/DPC: Quirk PIO log size for certain Intel Root Ports")

Quoted 8 lines
Quoted 2 lines

I *thought* this problem was caused by BIOS defects that were supposed to be fixed, but nothing seems to be happening.

As far as I know it should be fixed already. I just checked my MTLP and PTL systems (both with integrated TBT PCIe root ports) and I don't see the message anymore. I don't have RPL system though. This is on reference hardware and BIOS so it is possible that the fix has not been taken into the OEM BIOS.

The reporter verified that the issue persists with the latest BIOS. Sigh.

Takashi

#4 lore raw
In reply to Takashi Iwai
Quoted 5 lines · Takashi Iwai

There is yet another PCI entry for Intel Raptor Lake-P that shows the
error "DPC: RP PIO log size 0 is invalid":
0000:00:07.0 PCI bridge [0604]: Intel Corporation Raptor Lake-P Thunderbolt 4 PCI Express Root Port #0 [8086:a76e] 0000:00:07.2 PCI bridge [0604]: Intel Corporation Raptor Lake-P Thunderbolt 4 PCI Express Root Port #2 [8086:a72f]

Quoted 8 lines

Add the corresponding quirk entry for 8086:a72f.

Note that the one for 8086:a76e has been already added by the commit 627c6db20703 ("PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root Ports").

Applied to pci/dpc for v6.14, thanks!

Quoted 19 lines
---
 drivers/pci/quirks.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/quirks.c +1 -0
index 76f4df75b08a..4ed3704ce92e 100644
@@ -6253,6 +6253,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2b, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2d, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2f, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a31, dpc_log_size);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa72f, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa73f, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa76e, dpc_log_size);
 #endif
Signature · 1 line
2.43.0