Skip to contentSkip to conversation

dt-bindings: mfd: syscon: Sync compatible lists

PATCH Applied Andrew Davis 5 participants 15 messages Jan 3, 2025 – Jan 15, 2025

Subsystems (2)
Device tree bindings Multifunction devices (MFD)
lore
Share & tools
lore

Andrew Davis

author
#0 lore raw

cover dt-bindings: mfd: syscon: Sync compatible lists

Hello all,

Couple simple fixes for the two compatible lists being out of sync.

This is a resend of this series but this time based on latest next (next-20241220), last sending won't apply, sorry for the noise.

Thanks,
Andrew

Andrew Davis (3):
dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible
dt-bindings: mfd: syscon: Fix ti,j721e-acspcie-proxy-ctrl compatible
dt-bindings: mfd: syscon: Fix al,alpine-sysfabric-service compatible

 Documentation/devicetree/bindings/mfd/syscon.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.39.2
author
#1 lore raw

PATCH 1/3 dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible

This compatible was only added to the list for compatibility with older dtschema (<2024.02). Add it to the other list also so both new and old tools work.

Fixes 0d078d47cd3e ("dt-bindings: mfd: syscon: Add ti,j784s4-acspcie-proxy-ctrl compatible")
Signed-off-by Andrew Davis <[email protected]>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mfd/syscon.yaml +1 -0
index 032cdd30d95f1..717b616349e3d 100644
@@ -214,6 +214,7 @@ properties:
           - ti,am625-dss-oldi-io-ctrl
           - ti,am62p-cpsw-mac-efuse
           - ti,am654-dss-oldi-io-ctrl
+          - ti,j784s4-acspcie-proxy-ctrl
           - ti,j784s4-pcie-ctrl
           - ti,keystone-pllctrl
       - const: syscon
Signature · 1 line
2.39.2
Reviewed-by on v1 1/3
#2 lore raw

Re: [PATCH 1/3] dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible

Quoted 6 lines · Andrew Davis

This compatible was only added to the list for compatibility with older dtschema (<2024.02). Add it to the other list also so both new and old tools work.

Fixes 0d078d47cd3e ("dt-bindings: mfd: syscon: Add ti,j784s4-acspcie-proxy-ctrl compatible")
Signed-off-by Andrew Davis <[email protected]>

Thank you for the fix.

Reviewed-by Siddharth Vadapalli <[email protected]>

Regards,
Siddharth.

Quoted 19 lines
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mfd/syscon.yaml +1 -0
index 032cdd30d95f1..717b616349e3d 100644
@@ -214,6 +214,7 @@ properties:
           - ti,am625-dss-oldi-io-ctrl
           - ti,am62p-cpsw-mac-efuse
           - ti,am654-dss-oldi-io-ctrl
+          - ti,j784s4-acspcie-proxy-ctrl
           - ti,j784s4-pcie-ctrl
           - ti,keystone-pllctrl
       - const: syscon
Signature · 1 line
2.39.2
Reviewed-by on v1 1/3
#3 lore raw

Re: [PATCH 1/3] dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible

In reply to Andrew Davis
Quoted 2 lines · Andrew Davis

This compatible was only added to the list for compatibility with older dtschema (<2024.02). Add it to the other list also so both new and old

That's not a list of compatibles, but just select to apply the schema on older dtschema.

Quoted 1 line

tools work.

This compatible was simply never documented and never really worked. Original patch was probably never tested. :/

Quoted 4 lines
Fixes 0d078d47cd3e ("dt-bindings: mfd: syscon: Add ti,j784s4-acspcie-proxy-ctrl compatible")
Signed-off-by Andrew Davis <[email protected]>

---

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Reviewed-by on v1 1/3
#4 lore raw

Re: [PATCH 1/3] dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible

In reply to Andrew Davis

Hello Andrew, All,

Le 03/01/2025 à 18:45, Andrew Davis a écrit :

Quoted 6 lines

This compatible was only added to the list for compatibility with older dtschema (<2024.02). Add it to the other list also so both new and old tools work.

Fixes 0d078d47cd3e ("dt-bindings: mfd: syscon: Add ti,j784s4-acspcie-proxy-ctrl compatible")
Signed-off-by Andrew Davis <[email protected]>
Reviewed-by Romain Naour <[email protected]>

Best regards,
Romain

Quoted 16 lines
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mfd/syscon.yaml +1 -0
index 032cdd30d95f1..717b616349e3d 100644
@@ -214,6 +214,7 @@ properties:
           - ti,am625-dss-oldi-io-ctrl
           - ti,am62p-cpsw-mac-efuse
           - ti,am654-dss-oldi-io-ctrl
+          - ti,j784s4-acspcie-proxy-ctrl
           - ti,j784s4-pcie-ctrl
           - ti,keystone-pllctrl
       - const: syscon
maintainer Applied
#5 lore raw

Re: (subset) [PATCH 1/3] dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible

In reply to Andrew Davis
Quoted 5 lines · Andrew Davis

This compatible was only added to the list for compatibility with older dtschema (<2024.02). Add it to the other list also so both new and old tools work.

Applied, thanks!

[1/3] dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible

      commit: 756d4b7a873c1170b65ea1e4cf0312f0a3f9976f

--
Lee Jones [李琼斯]

author
#6 lore raw

PATCH 2/3 dt-bindings: mfd: syscon: Fix ti,j721e-acspcie-proxy-ctrl compatible

In reply to Andrew Davis

This compatible was only added to the list for compatibility with older dtschema (<2024.02). Add it to the other list also so both new and old tools work.

Fixes 8dfc4a014086 ("dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible")
Signed-off-by Andrew Davis <[email protected]>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mfd/syscon.yaml +1 -0
index 717b616349e3d..1f3e67f432e7b 100644
@@ -214,6 +214,7 @@ properties:
           - ti,am625-dss-oldi-io-ctrl
           - ti,am62p-cpsw-mac-efuse
           - ti,am654-dss-oldi-io-ctrl
+          - ti,j721e-acspcie-proxy-ctrl
           - ti,j784s4-acspcie-proxy-ctrl
           - ti,j784s4-pcie-ctrl
           - ti,keystone-pllctrl
Signature · 1 line
2.39.2
Reviewed-by on v1 2/3
#7 lore raw

Re: [PATCH 2/3] dt-bindings: mfd: syscon: Fix ti,j721e-acspcie-proxy-ctrl compatible

Quoted 7 lines · Andrew Davis

This compatible was only added to the list for compatibility with older dtschema (<2024.02). Add it to the other list also so both new and old tools work.

Fixes 8dfc4a014086 ("dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible")
Signed-off-by Andrew Davis <[email protected]>

---

Thank you for the fix.

Reviewed-by Siddharth Vadapalli <[email protected]>

Regards,
Siddharth.

Quoted 18 lines
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mfd/syscon.yaml +1 -0
index 717b616349e3d..1f3e67f432e7b 100644
@@ -214,6 +214,7 @@ properties:
           - ti,am625-dss-oldi-io-ctrl
           - ti,am62p-cpsw-mac-efuse
           - ti,am654-dss-oldi-io-ctrl
+          - ti,j721e-acspcie-proxy-ctrl
           - ti,j784s4-acspcie-proxy-ctrl
           - ti,j784s4-pcie-ctrl
           - ti,keystone-pllctrl
Signature · 1 line
2.39.2
Reviewed-by on v1 2/3
#8 lore raw

Re: [PATCH 2/3] dt-bindings: mfd: syscon: Fix ti,j721e-acspcie-proxy-ctrl compatible

In reply to Andrew Davis
Quoted 9 lines · Andrew Davis

This compatible was only added to the list for compatibility with older dtschema (<2024.02). Add it to the other list also so both new and old tools work.

Fixes 8dfc4a014086 ("dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible")
Signed-off-by Andrew Davis <[email protected]>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)
Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

#9 lore raw

Re: [PATCH 2/3] dt-bindings: mfd: syscon: Fix ti,j721e-acspcie-proxy-ctrl compatible

In reply to Andrew Davis

Hello Andrew,

Le 03/01/2025 à 18:45, Andrew Davis a écrit :

Quoted 5 lines

This compatible was only added to the list for compatibility with older dtschema (<2024.02). Add it to the other list also so both new and old tools work.

Fixes 8dfc4a014086 ("dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible")

This commit is no longer part of the kernel git tree, I'll resend the series for the j721e with your fix applied.

Thanks!

Best regards,
Romain

Quoted 17 lines
Signed-off-by Andrew Davis <[email protected]>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mfd/syscon.yaml +1 -0
index 717b616349e3d..1f3e67f432e7b 100644
@@ -214,6 +214,7 @@ properties:
           - ti,am625-dss-oldi-io-ctrl
           - ti,am62p-cpsw-mac-efuse
           - ti,am654-dss-oldi-io-ctrl
+          - ti,j721e-acspcie-proxy-ctrl
           - ti,j784s4-acspcie-proxy-ctrl
           - ti,j784s4-pcie-ctrl
           - ti,keystone-pllctrl
maintainer
#10 lore raw

Re: [PATCH 2/3] dt-bindings: mfd: syscon: Fix ti,j721e-acspcie-proxy-ctrl compatible

Quoted 11 lines · Romain Naour

Hello Andrew,

Le 03/01/2025 à 18:45, Andrew Davis a écrit :

Quoted 5 lines

This compatible was only added to the list for compatibility with older dtschema (<2024.02). Add it to the other list also so both new and old tools work.

Fixes 8dfc4a014086 ("dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible")

This commit is no longer part of the kernel git tree, I'll resend the series for the j721e with your fix applied.

So drop this patch and take the other 2?

Signature · 1 line
Lee Jones [李琼斯]
author
#11 lore raw

PATCH 3/3 dt-bindings: mfd: syscon: Fix al,alpine-sysfabric-service compatible

In reply to Andrew Davis

This compatible seems to be missing the last 'e', looks to be a typo when creating this file. Noticed this when diff'ing the two compatible lists (which should stay in sync).

Fixes f97b0435c857 ("dt-bindings: mfd: syscon: Split and enforce documenting MFD children")
Signed-off-by Andrew Davis <[email protected]>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/syscon.yaml +1 -1
index 1f3e67f432e7b..5eb0cfe1f0b89 100644
@@ -27,7 +27,7 @@ select:
     compatible:
       contains:
         enum:
-          - al,alpine-sysfabric-servic
+          - al,alpine-sysfabric-service
           - allwinner,sun8i-a83t-system-controller
           - allwinner,sun8i-h3-system-controller
           - allwinner,sun8i-v3s-system-controller
Signature · 1 line
2.39.2
Reviewed-by on v1 3/3
#12 lore raw

Re: [PATCH 3/3] dt-bindings: mfd: syscon: Fix al,alpine-sysfabric-service compatible

Quoted 6 lines · Andrew Davis

This compatible seems to be missing the last 'e', looks to be a typo when creating this file. Noticed this when diff'ing the two compatible lists (which should stay in sync).

Fixes f97b0435c857 ("dt-bindings: mfd: syscon: Split and enforce documenting MFD children")
Signed-off-by Andrew Davis <[email protected]>
Reviewed-by Siddharth Vadapalli <[email protected]>

Regards,
Siddharth.

Quoted 20 lines
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/syscon.yaml +1 -1
index 1f3e67f432e7b..5eb0cfe1f0b89 100644
@@ -27,7 +27,7 @@ select:
     compatible:
       contains:
         enum:
-          - al,alpine-sysfabric-servic
+          - al,alpine-sysfabric-service
           - allwinner,sun8i-a83t-system-controller
           - allwinner,sun8i-h3-system-controller
           - allwinner,sun8i-v3s-system-controller
Signature · 1 line
2.39.2
Reviewed-by on v1 3/3
#13 lore raw

Re: [PATCH 3/3] dt-bindings: mfd: syscon: Fix al,alpine-sysfabric-service compatible

In reply to Andrew Davis
Quoted 9 lines · Andrew Davis

This compatible seems to be missing the last 'e', looks to be a typo when creating this file. Noticed this when diff'ing the two compatible lists (which should stay in sync).

Fixes f97b0435c857 ("dt-bindings: mfd: syscon: Split and enforce documenting MFD children")
Signed-off-by Andrew Davis <[email protected]>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

maintainer Applied
#14 lore raw

Re: (subset) [PATCH 3/3] dt-bindings: mfd: syscon: Fix al,alpine-sysfabric-service compatible

In reply to Andrew Davis
Quoted 5 lines · Andrew Davis

This compatible seems to be missing the last 'e', looks to be a typo when creating this file. Noticed this when diff'ing the two compatible lists (which should stay in sync).

Applied, thanks!

[3/3] dt-bindings: mfd: syscon: Fix al,alpine-sysfabric-service compatible

      commit: 476f519d1ba1671f97f657027b33d5833b9e691d

--
Lee Jones [李琼斯]