Skip to contentSkip to conversation

dt-bindings: memory-controller: qca,ath79-ddr-controller: Drop consumer from example

PATCH Applied Rob Herring (Arm) 2 participants 3 messages Jan 3, 2025 – Jan 6, 2025

Subsystems (2)
Device tree bindings Memory controller drivers
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: memory-controller: qca,ath79-ddr-controller: Drop consumer from example

Normal practice is examples only show what the binding document defines and doesn't include consumers in a provider example (or vice-versa). The "qca,ddr-wb-channel-interrupts" and "qca,ddr-wb-channels" properties are also not yet documented by a schema, so avoid (not yet enabled) warnings on them by dropping the interrupt-controller node from the example.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 .../memory-controllers/qca,ath79-ddr-controller.yaml       | 7 -------
 1 file changed, 7 deletions(-)
Documentation/devicetree/bindings/memory-controllers/qca,ath79-ddr-controller.yaml +0 -7
index 0c511ab906bf..8b937f90a1fb 100644
@@ -52,10 +52,3 @@ examples:
 
         #qca,ddr-wb-channel-cells = <1>;
     };
-
-    interrupt-controller {
-        // ...
-        qca,ddr-wb-channel-interrupts = <2>, <3>, <4>, <5>;
-        qca,ddr-wb-channels = <&ddr_ctrl 3>, <&ddr_ctrl 2>,
-                              <&ddr_ctrl 0>, <&ddr_ctrl 1>;
-    };
Signature · 1 line
2.45.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Rob Herring (Arm)

Normal practice is examples only show what the binding document defines and doesn't include consumers in a provider example (or vice-versa). The "qca,ddr-wb-channel-interrupts" and "qca,ddr-wb-channels" properties are also not yet documented by a schema, so avoid (not yet enabled) warnings on them by dropping the interrupt-controller node from the example.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 .../memory-controllers/qca,ath79-ddr-controller.yaml       | 7 -------
 1 file changed, 7 deletions(-)

It is too late in the cycle for me to pick it up. I will take it after the merge window... or alternatively you can take it via DT for upcoming merge window:

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

author maintainer Applied
#2 lore raw
In reply to Rob Herring (Arm)
Quoted 11 lines · Rob Herring (Arm)

Normal practice is examples only show what the binding document defines and doesn't include consumers in a provider example (or vice-versa). The "qca,ddr-wb-channel-interrupts" and "qca,ddr-wb-channels" properties are also not yet documented by a schema, so avoid (not yet enabled) warnings on them by dropping the interrupt-controller node from the example.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 .../memory-controllers/qca,ath79-ddr-controller.yaml       | 7 -------
 1 file changed, 7 deletions(-)

Applied, thanks!