Skip to contentSkip to conversation

staging: gpib: Add missing mutex unlock on early return in

PATCH Superseded Dave Penkler 2 participants 2 messages Jan 8, 2025 – Jan 10, 2025 Staging

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: gpib: Add missing mutex unlock on early return in

When no matching product id was found in the attach function the driver returned without unlocking the agilent_82357a_hotplug_lock mutex.

Add the unlock call.

This was detected by smatch:
smatch warnings:
drivers/staging/gpib/agilent_82357a/agilent_82357a.c:1381 agilent_82357a_attach() warn: inconsistent returns 'global &agilent_82357a_hotplug_lock'.

Fixes 4c41fe886a56 ("staging: gpib: Add Agilent/Keysight 82357x USB GPIB driver")

---
v1 -> v2 Add subsystem prefix in subject

drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 1 +

 1 file changed, 1 insertion(+)
drivers/staging/gpib/agilent_82357a/agilent_82357a.c +1 -0
index b21eadabc466..c22c6bb30776 100644
@@ -1365,6 +1365,7 @@ static int agilent_82357a_attach(gpib_board_t *board, const gpib_board_config_t
 		break;
 	default:
 		dev_err(&usb_dev->dev, "bug, unhandled product_id in switch?\n");
+		mutex_unlock(&agilent_82357a_hotplug_lock);
 		return -EIO;
 	}
 #ifdef RESET_USB_CONFIG
Signature · 1 line
2.47.1
maintainer
#1 lore raw
Quoted 9 lines · Dave Penkler

When no matching product id was found in the attach function the driver returned without unlocking the agilent_82357a_hotplug_lock mutex.

Add the unlock call.

This was detected by smatch:
smatch warnings:
drivers/staging/gpib/agilent_82357a/agilent_82357a.c:1381 agilent_82357a_attach() warn: inconsistent returns 'global &agilent_82357a_hotplug_lock'.

Quoted 7 lines
Fixes 4c41fe886a56 ("staging: gpib: Add Agilent/Keysight 82357x USB GPIB driver")

---
v1 -> v2 Add subsystem prefix in subject

You sent 2 patches with identical subject lines, yet they do different things. That's not good, can you fix them both up and resend?

thanks,

greg k-h