mm: fix div by zero in bdi_ratio_from_pages
Subsystems (3)
PATCH v3 1/1 mm: fix div by zero in bdi_ratio_from_pages
During testing it has been detected, that it is possible to get div by zero error in bdi_set_min_bytes. The error is caused by the function bdi_ratio_from_pages(). bdi_ratio_from_pages() calls global_dirty_limits. If the dirty threshold is 0, the div by zero is raised. This can happen if the root user is setting:
echo 0 > /proc/sys/vm/dirty_ratio
The following is a test case:
echo 0 > /proc/sys/vm/dirty_ratio
cd /sys/class/bdi/<device>
echo 1 > strict_limit
echo 8192 > min_bytes
==> error is raised.
The problem is addressed by returning -EINVAL if dirty_ratio or dirty_bytes is set to 0.
---
Changes in V3:
- Used long instead of unsigned long for min_ratio / max_ratio
Changes in V2:
- check for -EINVAL in bdi_set_min_bytes()
- check for -EINVAL in bdi_set_max_bytes()
--- mm/page-writeback.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
mm/page-writeback.c +8 -2
@@ -692,6 +692,8 @@ static unsigned long bdi_ratio_from_pages(unsigned long pages)unsigned long ratio;global_dirty_limits (&background_thresh, &dirty_thresh); +if (!dirty_thresh) +return -EINVAL ; ratio =div64_u64 (pages *100ULL *BDI_RATIO_SCALE , dirty_thresh);return ratio;
@@ -790,13 +792,15 @@ int bdi_set_min_bytes(struct backing_dev_info *bdi, u64 min_bytes) {int ret;unsigned long pages = min_bytes >>PAGE_SHIFT ; -unsigned long min_ratio; +long min_ratio; ret =bdi_check_pages_limit (pages);if (ret)return ret; min_ratio =bdi_ratio_from_pages (pages); +if (min_ratio <0 ) +return min_ratio;return __bdi_set_min_ratio (bdi, min_ratio); }
@@ -809,13 +813,15 @@ int bdi_set_max_bytes(struct backing_dev_info *bdi, u64 max_bytes) {int ret;unsigned long pages = max_bytes >>PAGE_SHIFT ; -unsigned long max_ratio; +long max_ratio; ret =bdi_check_pages_limit (pages);if (ret)return ret; max_ratio =bdi_ratio_from_pages (pages); +if (max_ratio <0 ) +return max_ratio;return __bdi_set_max_ratio (bdi, max_ratio); }
base-commit: fbfd64d25c7af3b8695201ebc85efe90be28c5a3
Signature · 1 line
2.47.1
mm/page-writeback.c static unsigned long bdi_ratio_from_pages(unsigned long pages)
Quoted 40 lines · Stefan Roesch
During testing it has been detected, that it is possible to get div by zero error in
bdi_set_min_bytes. The error is caused by the functionbdi_ratio_from_pages().bdi_ratio_from_pages()callsglobal_dirty_limits. If the dirty threshold is 0, the div by zero is raised. This can happen if the root user is setting:echo 0 >
/proc/sys/vm/dirty_ratioThe following is a test case:
echo 0 >
/proc/sys/vm/dirty_ratio
cd /sys/class/bdi/<device>
echo 1 >strict_limit
echo 8192 >min_bytes==> error is raised.
The problem is addressed by returning
-EINVALifdirty_ratioordirty_bytesis set to 0.Reported-by cheung wall <[email protected]>Signed-off-by Stefan Roesch <[email protected]>---
Changes in V3:
- Used long instead of unsigned long formin_ratio/max_ratioChanges in V2:
- check for-EINVALinbdi_set_min_bytes()
- check for-EINVALinbdi_set_max_bytes()--- mm/page-writeback.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)mm/page-writeback.c +0
-0@@ -692,6 +692,8 @@ static unsigned long bdi_ratio_from_pages(unsigned long pages)
Note that I suggested returning "long" here, but it should also work as is.
Signature · 3 lines
Cheers, David / dhildenb