Skip to contentSkip to conversation

ALSA: trivial cleanups with str_yes_no()

PATCH New Takashi Iwai 1 participant 3 messages Jan 9, 2025 Sound

lore
Share & tools
lore
#0 lore raw

cover ALSA: trivial cleanups with str_yes_no()

Another series of trivial cleanups with the standard helper function.

Takashi

===

Takashi Iwai (2):
ALSA: hda/realtek: Simplify with str_yes_no()
ALSA: rme9652: Simplify with str_yes_no()

 sound/pci/hda/patch_realtek.c | 2 +-
 sound/pci/rme9652/rme9652.c   | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/2 ALSA: hda/realtek: Simplify with str_yes_no()

Use the standard helper for simplifying the code.
Merely cleanup, no behavior change.

---
 sound/pci/hda/patch_realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/patch_realtek.c +1 -1
index 1aba06062433..f578b9893a8f 100644
@@ -5900,7 +5900,7 @@ static void alc_determine_headset_type(struct hda_codec *codec)
 	}
 
 	codec_dbg(codec, "Headset jack detected iPhone-style headset: %s\n",
-		    is_ctia ? "yes" : "no");
+		  str_yes_no(is_ctia));
 	spec->current_headset_type = is_ctia ? ALC_HEADSET_TYPE_CTIA : ALC_HEADSET_TYPE_OMTP;
 }
 
Signature · 1 line
2.43.0
#2 lore raw

PATCH 2/2 ALSA: rme9652: Simplify with str_yes_no()

In reply to Takashi Iwai

Use the standard helper for simplifying the code.
Merely cleanup, no behavior change.

---
 sound/pci/rme9652/rme9652.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
sound/pci/rme9652/rme9652.c +2 -3
index d066c70ae160..5b8dd7b0a02c 100644
@@ -1561,8 +1561,7 @@ snd_rme9652_proc_read(struct snd_info_entry *entry, struct snd_info_buffer *buff
 		    x, (unsigned long) rme9652->period_bytes);
 	snd_iprintf(buffer, "Hardware pointer (frames): %ld\n",
 		    rme9652_hw_pointer(rme9652));
-	snd_iprintf(buffer, "Passthru: %s\n",
-		    rme9652->passthru ? "yes" : "no");
+	snd_iprintf(buffer, "Passthru: %s\n", str_yes_no(rme9652->passthru));
 
 	if ((rme9652->control_register & (RME9652_Master | RME9652_wsel)) == 0) {
 		snd_iprintf(buffer, "Clock mode: autosync\n");
@@ -1685,7 +1684,7 @@ snd_rme9652_proc_read(struct snd_info_entry *entry, struct snd_info_buffer *buff
 	snd_iprintf(buffer, "\n");
 
 	snd_iprintf(buffer, "Timecode signal: %s\n",
-		    (status & RME9652_tc_valid) ? "yes" : "no");
+		    str_yes_no(status & RME9652_tc_valid));
 
 	/* thru modes */
 
Signature · 1 line
2.43.0