Skip to contentSkip to conversation

fs/proc: fix softlockup in __read_vmcore (part 2)

PATCH Applied Rik van Riel 1 participant 1 message Jan 10, 2025

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/proc: fix softlockup in __read_vmcore (part 2)

Since commit 5cbcb62dddf5 ("fs/proc: fix softlockup in __read_vmcore") the number of softlockups in __read_vmcore at kdump time have gone down, but they still happen sometimes.

In a memory constrained environment like the kdump image, a softlockup is not just a harmless message, but it can interfere with things like RCU freeing memory, causing the crashdump to get stuck.

The second loop in __read_vmcore has a lot more opportunities for natural sleep points, like scheduling out while waiting for a data write to happen, but apparently that is not always enough.

Add a cond_resched() to the second loop in __read_vmcore to (hopefully) get rid of the softlockups.

Fixes 5cbcb62dddf5 ("fs/proc: fix softlockup in __read_vmcore")
---
 fs/proc/vmcore.c | 2 ++
 1 file changed, 2 insertions(+)
fs/proc/vmcore.c +2 -0
index 3d8a82cee63e..658bf199d424 100644
@@ -404,6 +404,8 @@ static ssize_t __read_vmcore(struct iov_iter *iter, loff_t *fpos)
 			if (!iov_iter_count(iter))
 				return acc;
 		}
+
+		cond_resched();
 	}
 
 	return acc;
Signature · 1 line
2.47.1