ASoC: amd: Fix build dependency for SND_SOC_AMD_YC_MACH
Subsystems (3)
PATCH 1/1 ASoC: amd: Fix build dependency for SND_SOC_AMD_YC_MACH
Commit 4095cf872084 ("ASoC: amd: yc: Fix for enabling DMIC on acp6x via _DSD entry") introduced usage of acpi_evaluate_integer in acp6x-mach.c.
A kernel config which has
# CONFIG_ACPI is not set
CONFIG_SND_SOC_AMD_YC_MACH=y
causes following compile error
sound/soc/amd/yc/acp6x-mach.c: In function ‘acp6x_probe’:
sound/soc/amd/yc/acp6x-mach.c:580:15: error: implicit declaration of function ‘acpi_evaluate_integer’; did you mean ‘acpi_evaluate_object’? [-Wimplicit-function-declaration]
580 | ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
| ^~~~~~~~~~~~~~~~~~~~~
| acpi_evaluate_objectThus ACPI is a new build dependency for SND_SOC_AMD_YC_MACH.
--- sound/soc/amd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/amd/Kconfig +1 -1
@@ -105,7 +105,7 @@ config SND_SOC_AMD_ACP6x config SND_SOC_AMD_YC_MACH tristate "AMD YC support for DMIC" select SND_SOC_DMIC - depends on SND_SOC_AMD_ACP6x + depends on SND_SOC_AMD_ACP6x && ACPI help This option enables machine driver for Yellow Carp platform using dmic. ACP IP has PDM Decoder block with DMA controller.
Signature · 1 line
2.47.1
Mark Brown
maintainerQuoted 3 lines · Andreas Herrmann
Commit
4095cf872084("ASoC: amd: yc: Fix for enabling DMIC on acp6x via_DSDentry") introduced usage ofacpi_evaluate_integerinacp6x-mach.c.
Someone already fixed this.