Skip to contentSkip to conversation

media: dt-bindings: adv7180: Document the 'interrupts' property

PATCH Superseded Fabio Estevam 2 participants 2 messages Jan 10, 2025 – Jan 13, 2025

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 media: dt-bindings: adv7180: Document the 'interrupts' property

From: Fabio Estevam <[email protected]>

The ADV7180 family of chips have an INTRQ pin that can be connected to a SoC GPIO.

Allow the 'interrupts' property to be described to fix the following dt-schema warning:

'interrupt-parent', 'interrupts' do not match any of the
regexes: 'pinctrl-[0-9]+'

---
Changes since v1:
- Detail the interrupt description.

 Documentation/devicetree/bindings/media/i2c/adv7180.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/media/i2c/adv7180.yaml +6 -0
index 4371a0ef2761..ede774dff4a8 100644
@@ -49,6 +49,12 @@ properties:
       Indicates that the output is a BT.656-4 compatible stream.
     type: boolean
 
+  interrupts:
+    description:
+      The ADV7180 chips can generate interrupt in the INTRQ pin.
+    items:
+      - description: INTRQ pin interrupt.
+
   port:
     $ref: /schemas/graph.yaml#/$defs/port-base
     unevaluatedProperties: false
Signature · 1 line
2.34.1
Acked-by on v2 1/1
#1 lore raw
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The ADV7180 family of chips have an INTRQ pin that can be connected to a SoC GPIO.

Allow the 'interrupts' property to be described to fix the following dt-schema warning:

'interrupt-parent', 'interrupts' do not match any of the
regexes: 'pinctrl-[0-9]+'

Please don't wrap the warning message, unless it would be really, really long. Wrapping makes grepping difficult.

Quoted 14 lines

---
Changes since v1:
- Detail the interrupt description.

 Documentation/devicetree/bindings/media/i2c/adv7180.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/media/i2c/adv7180.yaml +0 -0
index 4371a0ef2761..ede774dff4a8 100644

Documentation/devicetree/bindings/media/i2c/adv7180.yaml properties: · line 54

Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/adv7180.yaml +3 -0
@@ -49,6 +49,12 @@ properties:
       Indicates that the output is a BT.656-4 compatible stream.
     type: boolean
 
+  interrupts:
+    description:
+      The ADV7180 chips can generate interrupt in the INTRQ pin.

That's the same what is said in "items" with description, so no need for above description. Longer schema for no benefits makes it less readable.

Documentation/devicetree/bindings/media/i2c/adv7180.yaml properties: · line 57

Quoted 3 lines
Documentation/devicetree/bindings/media/i2c/adv7180.yaml +3 -0
+    items:
+      - description: INTRQ pin interrupt.
+

Best regards,
Krzysztof