Skip to contentSkip to conversation

RDMA/rxe: Change the return type from int to bool

PATCH In review Zhu Yanjun 3 participants 4 messages Jan 11, 2025 – Jan 14, 2025

Subsystems (2)
lore
Share & tools
lore

Zhu Yanjun

author
#0 lore raw

PATCH 1/1 RDMA/rxe: Change the return type from int to bool

The return type of the functions queue_full and queue_empty should be bool.

No functional changes.

Fixes 8700e3e7c485 ("Soft RoCE driver")
---
 drivers/infiniband/sw/rxe/rxe_cq.c    | 2 +-
 drivers/infiniband/sw/rxe/rxe_queue.h | 4 ++--
 drivers/infiniband/sw/rxe/rxe_verbs.c | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)
drivers/infiniband/sw/rxe/rxe_cq.c +1 -1
index fec87c9030ab..a2df55e13ea4 100644
@@ -88,7 +88,7 @@ int rxe_cq_resize_queue(struct rxe_cq *cq, int cqe,
 int rxe_cq_post(struct rxe_cq *cq, struct rxe_cqe *cqe, int solicited)
 {
 	struct ib_event ev;
-	int full;
+	bool full;
 	void *addr;
 	unsigned long flags;
 
drivers/infiniband/sw/rxe/rxe_queue.h +2 -2
index c711cb98b949..597e3da469a1 100644
@@ -151,7 +151,7 @@ static inline u32 queue_get_consumer(const struct rxe_queue *q,
 	return cons;
 }
 
-static inline int queue_empty(struct rxe_queue *q, enum queue_type type)
+static inline bool queue_empty(struct rxe_queue *q, enum queue_type type)
 {
 	u32 prod = queue_get_producer(q, type);
 	u32 cons = queue_get_consumer(q, type);
@@ -159,7 +159,7 @@ static inline int queue_empty(struct rxe_queue *q, enum queue_type type)
 	return ((prod - cons) & q->index_mask) == 0;
 }
 
-static inline int queue_full(struct rxe_queue *q, enum queue_type type)
+static inline bool queue_full(struct rxe_queue *q, enum queue_type type)
 {
 	u32 prod = queue_get_producer(q, type);
 	u32 cons = queue_get_consumer(q, type);
drivers/infiniband/sw/rxe/rxe_verbs.c +3 -3
index 8a5fc20fd186..c88140d896c5 100644
@@ -870,7 +870,7 @@ static int post_one_send(struct rxe_qp *qp, const struct ib_send_wr *ibwr)
 	struct rxe_send_wqe *send_wqe;
 	unsigned int mask;
 	unsigned int length;
-	int full;
+	bool full;
 
 	err = validate_send_wr(qp, ibwr, &mask, &length);
 	if (err)
@@ -960,7 +960,7 @@ static int post_one_recv(struct rxe_rq *rq, const struct ib_recv_wr *ibwr)
 	unsigned long length;
 	struct rxe_recv_wqe *recv_wqe;
 	int num_sge = ibwr->num_sge;
-	int full;
+	bool full;
 	int err;
 
 	full = queue_full(rq->queue, QUEUE_TYPE_FROM_ULP);
@@ -1185,7 +1185,7 @@ static int rxe_req_notify_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags flags)
 {
 	struct rxe_cq *cq = to_rcq(ibcq);
 	int ret = 0;
-	int empty;
+	bool empty;
 	unsigned long irq_flags;
 
 	spin_lock_irqsave(&cq->cq_lock, irq_flags);
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Zhu Yanjun

The return type of the functions queue_full and queue_empty should be bool.

No functional changes.

Fixes 8700e3e7c485 ("Soft RoCE driver")

Looks good to me

Quoted 72 lines
---
  drivers/infiniband/sw/rxe/rxe_cq.c    | 2 +-
  drivers/infiniband/sw/rxe/rxe_queue.h | 4 ++--
  drivers/infiniband/sw/rxe/rxe_verbs.c | 6 +++---
  3 files changed, 6 insertions(+), 6 deletions(-)
drivers/infiniband/sw/rxe/rxe_cq.c +1 -1
index fec87c9030ab..a2df55e13ea4 100644
@@ -88,7 +88,7 @@ int rxe_cq_resize_queue(struct rxe_cq *cq, int cqe,
  int rxe_cq_post(struct rxe_cq *cq, struct rxe_cqe *cqe, int solicited)
  {
  	struct ib_event ev;
-	int full;
+	bool full;
  	void *addr;
  	unsigned long flags;
 
drivers/infiniband/sw/rxe/rxe_queue.h +2 -2
index c711cb98b949..597e3da469a1 100644
@@ -151,7 +151,7 @@ static inline u32 queue_get_consumer(const struct rxe_queue *q,
  	return cons;
  }
 
-static inline int queue_empty(struct rxe_queue *q, enum queue_type type)
+static inline bool queue_empty(struct rxe_queue *q, enum queue_type type)
  {
  	u32 prod = queue_get_producer(q, type);
  	u32 cons = queue_get_consumer(q, type);
@@ -159,7 +159,7 @@ static inline int queue_empty(struct rxe_queue *q, enum queue_type type)
  	return ((prod - cons) & q->index_mask) == 0;
  }
 
-static inline int queue_full(struct rxe_queue *q, enum queue_type type)
+static inline bool queue_full(struct rxe_queue *q, enum queue_type type)
  {
  	u32 prod = queue_get_producer(q, type);
  	u32 cons = queue_get_consumer(q, type);
drivers/infiniband/sw/rxe/rxe_verbs.c +3 -3
index 8a5fc20fd186..c88140d896c5 100644
@@ -870,7 +870,7 @@ static int post_one_send(struct rxe_qp *qp, const struct ib_send_wr *ibwr)
  	struct rxe_send_wqe *send_wqe;
  	unsigned int mask;
  	unsigned int length;
-	int full;
+	bool full;
 
  	err = validate_send_wr(qp, ibwr, &mask, &length);
  	if (err)
@@ -960,7 +960,7 @@ static int post_one_recv(struct rxe_rq *rq, const struct ib_recv_wr *ibwr)
  	unsigned long length;
  	struct rxe_recv_wqe *recv_wqe;
  	int num_sge = ibwr->num_sge;
-	int full;
+	bool full;
  	int err;
 
  	full = queue_full(rq->queue, QUEUE_TYPE_FROM_ULP);
@@ -1185,7 +1185,7 @@ static int rxe_req_notify_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags flags)
  {
  	struct rxe_cq *cq = to_rcq(ibcq);
  	int ret = 0;
-	int empty;
+	bool empty;
  	unsigned long irq_flags;
 
  	spin_lock_irqsave(&cq->cq_lock, irq_flags);
author
#2 lore raw
Quoted 6 lines · Zhijian Li (Fujitsu)
Quoted 3 lines · Zhu Yanjun

The return type of the functions queue_full and queue_empty should be bool.

Quoted 6 lines
Quoted 4 lines

No functional changes.

Fixes 8700e3e7c485 ("Soft RoCE driver")

Looks good to me

Thanks for your code review.

Zhu Yanjun

Quoted 76 lines
Quoted 72 lines
---
   drivers/infiniband/sw/rxe/rxe_cq.c    | 2 +-
   drivers/infiniband/sw/rxe/rxe_queue.h | 4 ++--
   drivers/infiniband/sw/rxe/rxe_verbs.c | 6 +++---
   3 files changed, 6 insertions(+), 6 deletions(-)
drivers/infiniband/sw/rxe/rxe_cq.c +1 -1
index fec87c9030ab..a2df55e13ea4 100644
@@ -88,7 +88,7 @@ int rxe_cq_resize_queue(struct rxe_cq *cq, int cqe,
   int rxe_cq_post(struct rxe_cq *cq, struct rxe_cqe *cqe, int solicited)
   {
   	struct ib_event ev;
-	int full;
+	bool full;
   	void *addr;
   	unsigned long flags;
 
drivers/infiniband/sw/rxe/rxe_queue.h +2 -2
index c711cb98b949..597e3da469a1 100644
@@ -151,7 +151,7 @@ static inline u32 queue_get_consumer(const struct rxe_queue *q,
   	return cons;
   }
 
-static inline int queue_empty(struct rxe_queue *q, enum queue_type type)
+static inline bool queue_empty(struct rxe_queue *q, enum queue_type type)
   {
   	u32 prod = queue_get_producer(q, type);
   	u32 cons = queue_get_consumer(q, type);
@@ -159,7 +159,7 @@ static inline int queue_empty(struct rxe_queue *q, enum queue_type type)
   	return ((prod - cons) & q->index_mask) == 0;
   }
 
-static inline int queue_full(struct rxe_queue *q, enum queue_type type)
+static inline bool queue_full(struct rxe_queue *q, enum queue_type type)
   {
   	u32 prod = queue_get_producer(q, type);
   	u32 cons = queue_get_consumer(q, type);
drivers/infiniband/sw/rxe/rxe_verbs.c +3 -3
index 8a5fc20fd186..c88140d896c5 100644
@@ -870,7 +870,7 @@ static int post_one_send(struct rxe_qp *qp, const struct ib_send_wr *ibwr)
   	struct rxe_send_wqe *send_wqe;
   	unsigned int mask;
   	unsigned int length;
-	int full;
+	bool full;
 
   	err = validate_send_wr(qp, ibwr, &mask, &length);
   	if (err)
@@ -960,7 +960,7 @@ static int post_one_recv(struct rxe_rq *rq, const struct ib_recv_wr *ibwr)
   	unsigned long length;
   	struct rxe_recv_wqe *recv_wqe;
   	int num_sge = ibwr->num_sge;
-	int full;
+	bool full;
   	int err;
 
   	full = queue_full(rq->queue, QUEUE_TYPE_FROM_ULP);
@@ -1185,7 +1185,7 @@ static int rxe_req_notify_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags flags)
   {
   	struct rxe_cq *cq = to_rcq(ibcq);
   	int ret = 0;
-	int empty;
+	bool empty;
   	unsigned long irq_flags;
 
   	spin_lock_irqsave(&cq->cq_lock, irq_flags);
#3 lore raw
In reply to Zhu Yanjun
Quoted 5 lines · Zhu Yanjun

The return type of the functions queue_full and queue_empty should be bool.

No functional changes.

Quoted 7 lines
Fixes 8700e3e7c485 ("Soft RoCE driver")
---
 drivers/infiniband/sw/rxe/rxe_cq.c    | 2 +-
 drivers/infiniband/sw/rxe/rxe_queue.h | 4 ++--
 drivers/infiniband/sw/rxe/rxe_verbs.c | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)

Let's not do change just for the sake of change.
This standalone patch has zero effect on the code, both from functionality and readability point of views.

Thanks