mm-fix-div-by-zero-in-bdi_ratio_from_pages.patch removed from -mm tree
The quilt patch titled
Subject: mm: fix div by zero in bdi_ratio_from_pages
has been removed from the -mm tree. Its filename was
mm-fix-div-by-zero-in-bdi_ratio_from_pages.patch
This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Stefan Roesch <[email protected]>
Subject: mm: fix div by zero in bdi_ratio_from_pages
Date: Fri, 3 Jan 2025 17:20:37 -0800
During testing it has been detected, that it is possible to get div by zero error in bdi_set_min_bytes. The error is caused by the function bdi_ratio_from_pages(). bdi_ratio_from_pages() calls global_dirty_limits. If the dirty threshold is 0, the div by zero is raised. This can happen if the root user is setting:
echo 0 > /proc/sys/vm/dirty_ratio
The following is a test case:
echo 0 > /proc/sys/vm/dirty_ratio
cd /sys/class/bdi/<device>
echo 1 > strict_limit
echo 8192 > min_bytes
==> error is raised.
The problem is addressed by returning -EINVAL if dirty_ratio or dirty_bytes is set to 0.
---
mm/page-writeback.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
mm/page-writeback.c renamed from mm/page-writeback.c~mm-fix-div-by-zero-in-bdi_ratio_from_pages +8 -2
@@ -692,6 +692,8 @@ static unsigned long bdi_ratio_from_pageunsigned long ratio;global_dirty_limits (&background_thresh, &dirty_thresh); +if (!dirty_thresh) +return -EINVAL ; ratio =div64_u64 (pages *100ULL *BDI_RATIO_SCALE , dirty_thresh);return ratio;
@@ -790,13 +792,15 @@ int bdi_set_min_bytes(struct backing_dev {int ret;unsigned long pages = min_bytes >>PAGE_SHIFT ; -unsigned long min_ratio; +long min_ratio; ret =bdi_check_pages_limit (pages);if (ret)return ret; min_ratio =bdi_ratio_from_pages (pages); +if (min_ratio <0 ) +return min_ratio;return __bdi_set_min_ratio (bdi, min_ratio); }
@@ -809,13 +813,15 @@ int bdi_set_max_bytes(struct backing_dev {int ret;unsigned long pages = max_bytes >>PAGE_SHIFT ; -unsigned long max_ratio; +long max_ratio; ret =bdi_check_pages_limit (pages);if (ret)return ret; max_ratio =bdi_ratio_from_pages (pages); +if (max_ratio <0 ) +return max_ratio;return __bdi_set_max_ratio (bdi, max_ratio); }
_
Patches currently in -mm which might be from [email protected] are