mm-hugetlb-stop-using-avoid_reserve-flag-in-fork.patch removed from -mm tree
The quilt patch titled
Subject: mm/hugetlb: stop using avoid_reserve flag in fork()
has been removed from the -mm tree. Its filename was
mm-hugetlb-stop-using-avoid_reserve-flag-in-fork.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Peter Xu <[email protected]>
Subject: mm/hugetlb: stop using avoid_reserve flag in fork()
Date: Tue, 7 Jan 2025 15:39:57 -0500
When fork() and stumble on top of a dma-pinned hugetlb private page, CoW must happen during fork() to guarantee dma coherency.
In this specific path, hugetlb pages need to be allocated for the child process. Stop using avoid_reserve=1 flag here: it's not required to be used here, as dest_vma (which is destined to be a MAP_PRIVATE hugetlb vma) will have no private vma resv map, and that will make sure it won't be able to use a vma reservation later.
No functional change intended with this change. Said that, it's still wanted to do this, so as to reduce the usage of avoid_reserve to the only one user, which is also why this flag was introduced initially in commit 04f2cbe35699 ("hugetlb: guarantee that COW faults for a process that called mmap(MAP_PRIVATE) on hugetlbfs will succeed"). I don't see whoever else should set it at all.
Further patch will clean up resv accounting based on this.
---
mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/hugetlb.c renamed from mm/hugetlb.c~mm-hugetlb-stop-using-avoid_reserve-flag-in-fork +1 -1
@@ -5373,7 +5373,7 @@ again:spin_unlock (src_ptl);spin_unlock (dst_ptl);/* Do not use reserve as it's private owned */ - new_folio =alloc_hugetlb_folio (dst_vma, addr,1 ); + new_folio =alloc_hugetlb_folio (dst_vma, addr,0 );if (IS_ERR (new_folio)) {folio_put (pte_folio); ret =PTR_ERR (new_folio);
_
Patches currently in -mm which might be from [email protected] are