Skip to contentSkip to conversation

fstests: workaround for gcc-15

PATCH In review Zorro Lang 3 participants 4 messages Jan 17, 2025 – Jan 18, 2025 VFS

lore
Share & tools
lore

Zorro Lang

author
#0 lore raw

PATCH 1/1 fstests: workaround for gcc-15

GCC-15 does a big change, it changes the default language version for C compilation from -std=gnu17 to -std=gnu23. That cause lots of "old style" C codes hit build errors. On the other word, current xfstests can't be used with GCC-15. So -std=gnu17 can help that.

---

Hi,

I send this patch just for talking about this issue. The upcoming gcc-15 does lots of changes, a big change is using C23 by default:

https://gcc.gnu.org/gcc-15/porting_to.html

xfstests has many old style C codes, they hard to be built with gcc-15. So we have to either add -std=$old_version (likes this patch), or port the code to C23.

This patch is just a workaround (and a reminder for someone might hit this issue with gcc-15 too). If you have any good suggestions or experience (for this kind of issue) to share, feel free to reply.

Thanks,
Zorro

 include/builddefs.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/builddefs.in +1 -1
index 5b5864278..ef124bb87 100644
@@ -75,7 +75,7 @@ HAVE_RLIMIT_NOFILE = @have_rlimit_nofile@
 NEED_INTERNAL_XFS_IOC_EXCHANGE_RANGE = @need_internal_xfs_ioc_exchange_range@
 HAVE_FICLONE = @have_ficlone@
 
-GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall
+GCCFLAGS = -funsigned-char -fno-strict-aliasing -std=gnu17 -Wall
 SANITIZER_CFLAGS += @autovar_init_cflags@
 
 ifeq ($(PKG_PLATFORM),linux)
Signature · 1 line
2.47.1
#1 lore raw
Quoted 15 lines · Zorro Lang

GCC-15 does a big change, it changes the default language version for C compilation from -std=gnu17 to -std=gnu23. That cause lots of "old style" C codes hit build errors. On the other word, current xfstests can't be used with GCC-15. So -std=gnu17 can help that.

---

Hi,

I send this patch just for talking about this issue. The upcoming gcc-15 does lots of changes, a big change is using C23 by default:

https://gcc.gnu.org/gcc-15/porting_to.html

Quoted 7 lines

xfstests has many old style C codes, they hard to be built with gcc-15. So we have to either add -std=$old_version (likes this patch), or port the code to C23.

This patch is just a workaround (and a reminder for someone might hit this issue with gcc-15 too). If you have any good suggestions or experience (for this kind of issue) to share, feel free to reply.

-std=gnu11 to match the kernel and xfsprogs?

--D

Quoted 23 lines

Thanks,
Zorro

 include/builddefs.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/builddefs.in +1 -1
index 5b5864278..ef124bb87 100644
@@ -75,7 +75,7 @@ HAVE_RLIMIT_NOFILE = @have_rlimit_nofile@
 NEED_INTERNAL_XFS_IOC_EXCHANGE_RANGE = @need_internal_xfs_ioc_exchange_range@
 HAVE_FICLONE = @have_ficlone@
 
-GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall
+GCCFLAGS = -funsigned-char -fno-strict-aliasing -std=gnu17 -Wall
 SANITIZER_CFLAGS += @autovar_init_cflags@
 
 ifeq ($(PKG_PLATFORM),linux)
Signature · 1 line
2.47.1
#2 lore raw
Quoted 20 lines · Darrick J. Wong
Quoted 19 lines · Zorro Lang

GCC-15 does a big change, it changes the default language version for C compilation from -std=gnu17 to -std=gnu23. That cause lots of "old style" C codes hit build errors. On the other word, current xfstests can't be used with GCC-15. So -std=gnu17 can help that.

---

Hi,

I send this patch just for talking about this issue. The upcoming gcc-15 does lots of changes, a big change is using C23 by default:

https://gcc.gnu.org/gcc-15/porting_to.html

xfstests has many old style C codes, they hard to be built with gcc-15. So we have to either add -std=$old_version (likes this patch), or port the code to C23.

Quoted 5 lines
Quoted 3 lines

This patch is just a workaround (and a reminder for someone might hit this issue with gcc-15 too). If you have any good suggestions or experience (for this kind of issue) to share, feel free to reply.

-std=gnu11 to match the kernel and xfsprogs?

So you prefer using a settled "-std=xxx" to changing codes to match "gnu23"?

Quoted 27 lines

--D

Quoted 23 lines

Thanks,
Zorro

 include/builddefs.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/builddefs.in +1 -1
index 5b5864278..ef124bb87 100644
@@ -75,7 +75,7 @@ HAVE_RLIMIT_NOFILE = @have_rlimit_nofile@
 NEED_INTERNAL_XFS_IOC_EXCHANGE_RANGE = @need_internal_xfs_ioc_exchange_range@
 HAVE_FICLONE = @have_ficlone@
 
-GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall
+GCCFLAGS = -funsigned-char -fno-strict-aliasing -std=gnu17 -Wall
 SANITIZER_CFLAGS += @autovar_init_cflags@
 
 ifeq ($(PKG_PLATFORM),linux)
Signature · 1 line
2.47.1
#3 lore raw
Quoted 21 lines · Zorro Lang
Quoted 20 lines · Darrick J. Wong
Quoted 19 lines · Zorro Lang

GCC-15 does a big change, it changes the default language version for C compilation from -std=gnu17 to -std=gnu23. That cause lots of "old style" C codes hit build errors. On the other word, current xfstests can't be used with GCC-15. So -std=gnu17 can help that.

---

Hi,

I send this patch just for talking about this issue. The upcoming gcc-15 does lots of changes, a big change is using C23 by default:

https://gcc.gnu.org/gcc-15/porting_to.html

xfstests has many old style C codes, they hard to be built with gcc-15. So we have to either add -std=$old_version (likes this patch), or port the code to C23.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

This patch is just a workaround (and a reminder for someone might hit this issue with gcc-15 too). If you have any good suggestions or experience (for this kind of issue) to share, feel free to reply.

-std=gnu11 to match the kernel and xfsprogs?

So you prefer using a settled "-std=xxx" to changing codes to match "gnu23"?

Only gcc 14 and 15 support gnu23, which will break the builds on ancient distros such as Debian 12 and RHEL9. Also, there's the human cost that now fs developers have to know /two/ C dialects -- gnu11 for the kernel, and gnu23 for fstests.

So yes, I prefer using -std=gnu11 for better consistency and tooling support.

--D

Quoted 28 lines
Quoted 27 lines

--D

Quoted 23 lines

Thanks,
Zorro

 include/builddefs.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/builddefs.in +1 -1
index 5b5864278..ef124bb87 100644
@@ -75,7 +75,7 @@ HAVE_RLIMIT_NOFILE = @have_rlimit_nofile@
 NEED_INTERNAL_XFS_IOC_EXCHANGE_RANGE = @need_internal_xfs_ioc_exchange_range@
 HAVE_FICLONE = @have_ficlone@
 
-GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall
+GCCFLAGS = -funsigned-char -fno-strict-aliasing -std=gnu17 -Wall
 SANITIZER_CFLAGS += @autovar_init_cflags@
 
 ifeq ($(PKG_PLATFORM),linux)
Signature · 1 line
2.47.1