ARM: dts: socfpga: remove syscon compatible string for sysmgr node
Subsystems (2)
PATCH 1/1 ARM: dts: socfpga: remove syscon compatible string for sysmgr node
From: Niravkumar L Rabara <[email protected]>
The SoCFPGA System Manager(sysmgr) dt bindings do not use the syscon compitible, nor does the Linux system manager driver rely on it. Remove "syscon" for Arria5, Arria10 and Cyclon5 sysmgr node and fixed dtbs_check warnings like:
socfpga_arria5_socdk.dtb: sysmgr@ffd08000: compatible: 'oneOf' conditional failed, one must be fixed:
['altr,sys-mgr', 'syscon'] is too long
'altr,sys-mgr-s10' was expected
'altr,sys-mgr' was expected
from schema $id: http://devicetree.org/schemas/soc/altera/altr,sys-mgr.yaml#
--- arch/arm/boot/dts/intel/socfpga/socfpga.dtsi | 2 +- arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/intel/socfpga/socfpga.dtsi +1 -1
@@ -853,7 +853,7 @@ spi1: spi@fff01000 { }; sysmgr: sysmgr@ffd08000 { - compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd08000 0x4000>; };
arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi +1 -1
@@ -792,7 +792,7 @@ scu: snoop-control-unit@ffffc000 { }; sysmgr: sysmgr@ffd06000 { - compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd06000 0x300>; cpu1-start-addr = <0xffd06230>; };
Signature · 1 line
2.25.1
Dinh Nguyen
maintainerQuoted 39 lines · On 1/17/25 09:42, [email protected] wrote:
From: Niravkumar L Rabara <[email protected]>
The SoCFPGA System Manager(sysmgr) dt bindings do not use the syscon compitible, nor does the Linux system manager driver rely on it. Remove "syscon" for Arria5, Arria10 and Cyclon5 sysmgr node and fixed
dtbs_checkwarnings like:socfpga_arria5_socdk.dtb: sysmgr@ffd08000: compatible: 'oneOf' conditional failed, one must be fixed:
['altr,sys-mgr', 'syscon'] is too long
'altr,sys-mgr-s10' was expected
'altr,sys-mgr' was expected
from schema $id: http://devicetree.org/schemas/soc/altera/altr,sys-mgr.yaml#Reported-by kernel test robot <[email protected]>Signed-off-by Niravkumar L Rabara <[email protected]>--- arch/arm/boot/dts/intel/socfpga/socfpga.dtsi | 2 +- arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/intel/socfpga/socfpga.dtsi +1
-1@@ -853,7 +853,7 @@ spi1: spi@fff01000 { }; sysmgr: sysmgr@ffd08000 { - compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd08000 0x4000>; };arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi +0
-0
arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi scu: snoop-control-unit@ffffc000 { · line 798
Quoted 8 lines
arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi +1
-1@@ -792,7 +792,7 @@ scu: snoop-control-unit@ffffc000 { }; sysmgr: sysmgr@ffd06000 { - compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd06000 0x300>; cpu1-start-addr = <0xffd06230>; };
Did you test this patch on actual hardware? Unless something has changed in the system manager driver, this will probably cause the system hang.
Dinh
Dinh Nguyen
maintainerQuoted 39 lines · Dinh Nguyen
Quoted 38 lines · On 1/17/25 09:42, [email protected] wrote:
From: Niravkumar L Rabara <[email protected]>
The SoCFPGA System Manager(sysmgr) dt bindings do not use the syscon compitible, nor does the Linux system manager driver rely on it. Remove "syscon" for Arria5, Arria10 and Cyclon5 sysmgr node and fixed
dtbs_checkwarnings like:socfpga_arria5_socdk.dtb: sysmgr@ffd08000: compatible: 'oneOf' conditional failed, one must be fixed:
['altr,sys-mgr', 'syscon'] is too long
'altr,sys-mgr-s10' was expected
'altr,sys-mgr' was expected
from schema $id: http://devicetree.org/schemas/soc/altera/altr,sys-mgr.yaml#Reported-by kernel test robot <[email protected]>Signed-off-by Niravkumar L Rabara <[email protected]>---
arch/arm/boot/dts/intel/socfpga/socfpga.dtsi | 2 +-arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi| 2 +-2 files changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/intel/socfpga/socfpga.dtsi +1
-1@@ -853,7 +853,7 @@ spi1: spi@fff01000 { }; sysmgr: sysmgr@ffd08000 { - compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd08000 0x4000>; };arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi +0
-0@@ -792,7 +792,7 @@ scu: snoop-control-unit@ffffc000 { };
Quoted 9 lines
arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi scu: snoop-control-unit@ffffc000 { · line 798
Quoted 6 lines
arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi +1
-1sysmgr: sysmgr@ffd06000 { - compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd06000 0x300>; cpu1-start-addr = <0xffd06230>; };Did you test this patch on actual hardware? Unless something has changed in the system manager driver, this will probably cause the system hang.
Actually, it will not fail to boot, but you will see SD/MMC fail if the bootloader did not set the clk-phase correctly, or you booted from another source not SD/MMC. The SD/MMC driver uses syscon to get access to the system manager to set it's clk-phase.
Dinh
Dinh
Hi Dinh
Quoted 66 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 8:07 AM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 46 lines · Dinh Nguyen
Quoted 45 lines · On 1/17/25 09:42, [email protected] wrote:
From: Niravkumar L Rabara <[email protected]>
The SoCFPGA System Manager(sysmgr) dt bindings do not use the syscon compitible, nor does the Linux system manager driver rely on it. Remove "syscon" for Arria5, Arria10 and Cyclon5 sysmgr node and fixed
dtbs_checkwarnings like:socfpga_arria5_socdk.dtb: sysmgr@ffd08000: compatible: 'oneOf' conditional failed, one must be fixed:
['altr,sys-mgr', 'syscon'] is too long 'altr,sys-mgr-s10' was expected
'altr,sys-mgr' was expected
from schema $id:
http://devicetree.org/schemas/soc/altera/altr,sys-mgr.yaml#Reported-by kernel test robot <[email protected]>Closes:
https://lore.kernel.org/oe-kbuild-all/202501102323.Xnte2yhi-lkp@intel
.com/Signed-off-by Niravkumar L Rabara <[email protected]>---
arch/arm/boot/dts/intel/socfpga/socfpga.dtsi | 2 +-arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi| 2 +-2 files changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/intel/socfpga/socfpga.dtsi +1
-1@@ -853,7 +853,7 @@ spi1: spi@fff01000 { }; sysmgr: sysmgr@ffd08000 { - compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd08000 0x4000>; };arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi +0
-0@@ -792,7 +792,7 @@ scu: snoop-control-unit@ffffc000 { }; sysmgr: sysmgr@ffd06000 {Quoted 8 lines
arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi scu: snoop-control-unit@ffffc000 { · line 798
Quoted 5 lines
arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi +1
-1- compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd06000 0x300>; cpu1-start-addr = <0xffd06230>; };Did you test this patch on actual hardware? Unless something has changed in the system manager driver, this will probably cause the system
Quoted 8 lines
hang.
Quoted 1 line
Actually, it will not fail to boot, but you will see SD/MMC fail if the bootloader did not set the clk-phase correctly, or you booted from another source not SD/MMC. The SD/MMC driver uses syscon to get access to the system manager to set it's clk-phase.
Yes, I have tested this using NFS boot, however I didn't observe any issue with SD/MMC driver.
=> fdt print /soc/mmc@ff808000
mmc@ff808000 {
#address-cells = <0x00000001>;
#size-cells = <0x00000000>;
compatible = "altr,socfpga-dw-mshc";
reg = <0xff808000 0x00001000>;
interrupts = <0x00000000 0x00000062 0x00000004>;
fifo-depth = <0x00000400>;
clocks = <0x0000001a 0x00000024>;
clock-names = "biu", "ciu";
resets = <0x00000006 0x00000027>;
altr,sysmgr-syscon = <0x0000001c 0x00000028 0x00000004>;
status = "okay";
cap-sd-highspeed;
cap-mmc-highspeed;
broken-cd;
bus-width = <0x00000004>;
clk-phase-sd-hs = <0x00000000 0x00000087>;
phandle = <0x00000029>;
};
=> fdt print /soc/sysmgr@ffd06000
sysmgr@ffd06000 {
compatible = "altr,sys-mgr";
reg = <0xffd06000 0x00000300>;
cpu1-start-addr = <0xffd06230>;
phandle = <0x0000001c>;
};.
[ 1.095784] mmc_host mmc0: Bus speed (slot 0) = 50000000Hz (slot req 50000000Hz, actual 50000000HZ div = 0) [ 1.105692] mmc0: new high speed SDHC card at address 0001 [ 1.108238] at24 0-0051: supply vcc not found, using dummy regulator [ 1.111817] mmcblk0: mmc0:0001 SD32G 29.1 GiB [ 1.118872] at24 0-0051: 4096 byte 24c32 EEPROM, writable, 32 bytes/write [ 1.129186] mmcblk0: p1 p2 p3
.
root@arria10:~# ls /dev/mmcblk0* /dev/mmcblk0 /dev/mmcblk0p1 /dev/mmcblk0p2 /dev/mmcblk0p3 root@arria10:~# mount /dev/mmcblk0p1 /tmp/ root@arria10:~# ls /tmp/ extlinux socfpga_arria10_socdk_sdmmc.dtb zImage fit_spl_fpga.itb u-boot.img
Thanks,
Nirav
Dinh Nguyen
maintainerQuoted 117 lines · Niravkumar L
Hi Dinh
Quoted 66 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 8:07 AM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 46 lines · Dinh Nguyen
Quoted 45 lines · On 1/17/25 09:42, [email protected] wrote:
From: Niravkumar L Rabara <[email protected]>
The SoCFPGA System Manager(sysmgr) dt bindings do not use the syscon compitible, nor does the Linux system manager driver rely on it. Remove "syscon" for Arria5, Arria10 and Cyclon5 sysmgr node and fixed
dtbs_checkwarnings like:socfpga_arria5_socdk.dtb: sysmgr@ffd08000: compatible: 'oneOf' conditional failed, one must be fixed:
['altr,sys-mgr', 'syscon'] is too long 'altr,sys-mgr-s10' was expected
'altr,sys-mgr' was expected
from schema $id:
http://devicetree.org/schemas/soc/altera/altr,sys-mgr.yaml#Reported-by kernel test robot <[email protected]>Closes:
https://lore.kernel.org/oe-kbuild-all/202501102323.Xnte2yhi-lkp@intel
.com/Signed-off-by Niravkumar L Rabara <[email protected]>--- arch/arm/boot/dts/intel/socfpga/socfpga.dtsi | 2 +- arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/intel/socfpga/socfpga.dtsi +1
-1@@ -853,7 +853,7 @@ spi1: spi@fff01000 { }; sysmgr: sysmgr@ffd08000 { - compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd08000 0x4000>; };arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi +0
-0@@ -792,7 +792,7 @@ scu: snoop-control-unit@ffffc000 { }; sysmgr: sysmgr@ffd06000 {Quoted 8 lines
arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi scu: snoop-control-unit@ffffc000 { · line 798
Quoted 5 lines
arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi +1
-1- compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd06000 0x300>; cpu1-start-addr = <0xffd06230>; };Did you test this patch on actual hardware? Unless something has changed in the system manager driver, this will probably cause the system
Quoted 8 lines
hang.
Quoted 1 line
Actually, it will not fail to boot, but you will see SD/MMC fail if the bootloader did not set the clk-phase correctly, or you booted from another source not SD/MMC. The SD/MMC driver uses syscon to get access to the system manager to set it's clk-phase.
Yes, I have tested this using NFS boot, however I didn't observe any issue with SD/MMC driver.
=> fdt print /soc/mmc@ff808000
mmc@ff808000 { #address-cells = <0x00000001>; #size-cells = <0x00000000>; compatible = "altr,socfpga-dw-mshc"; reg = <0xff808000 0x00001000>; interrupts = <0x00000000 0x00000062 0x00000004>; fifo-depth = <0x00000400>; clocks = <0x0000001a 0x00000024>; clock-names = "biu", "ciu"; resets = <0x00000006 0x00000027>; altr,sysmgr-syscon = <0x0000001c 0x00000028 0x00000004>; status = "okay"; cap-sd-highspeed; cap-mmc-highspeed; broken-cd; bus-width = <0x00000004>; clk-phase-sd-hs = <0x00000000 0x00000087>; phandle = <0x00000029>; }; => fdt print /soc/sysmgr@ffd06000 sysmgr@ffd06000 { compatible = "altr,sys-mgr"; reg = <0xffd06000 0x00000300>; cpu1-start-addr = <0xffd06230>; phandle = <0x0000001c>; };.
[ 1.095784] mmc_host mmc0: Bus speed (slot 0) = 50000000Hz (slot req 50000000Hz, actual 50000000HZ div = 0) [ 1.105692] mmc0: new high speed SDHC card at address 0001 [ 1.108238] at24 0-0051: supply vcc not found, using dummy regulator [ 1.111817] mmcblk0: mmc0:0001 SD32G 29.1 GiB [ 1.118872] at24 0-0051: 4096 byte 24c32 EEPROM, writable, 32 bytes/write [ 1.129186] mmcblk0: p1 p2 p3
Quoted 10 lines
.
root@arria10:~# ls /dev/mmcblk0* /dev/mmcblk0 /dev/mmcblk0p1 /dev/mmcblk0p2 /dev/mmcblk0p3 root@arria10:~# mount /dev/mmcblk0p1 /tmp/ root@arria10:~# ls /tmp/ extlinux socfpga_arria10_socdk_sdmmc.dtb zImage fit_spl_fpga.itb u-boot.img
You didn't really test anything. There's a register in the System Manager that has set the SD/MMC clk-phase in U-Boot. So you won't see the failure unless you explicitly change the value in that register and then boot Linux, then you will see the failure. If you look at drivers/mmc/host/dw_mmc-pltfm.c and look at the function dw_mci_socfpga_priv_init(), you can see that work in action. If you remove the syscon property, then that portion of the driver will fail. Also the ethernet driver is using the system manager's to set the correct PHY mode through syscon. I think you need to test this patch more thoroughly.
DInh
Hi Dinh,
Quoted 70 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 12:15 PM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 31 lines
Yes, I have tested this using NFS boot, however I didn't observe any issue with SD/MMC driver.
=> fdt print /soc/mmc@ff808000
mmc@ff808000 { #address-cells = <0x00000001>; #size-cells = <0x00000000>; compatible = "altr,socfpga-dw-mshc"; reg = <0xff808000 0x00001000>; interrupts = <0x00000000 0x00000062 0x00000004>; fifo-depth = <0x00000400>; clocks = <0x0000001a 0x00000024>; clock-names = "biu", "ciu"; resets = <0x00000006 0x00000027>; altr,sysmgr-syscon = <0x0000001c 0x00000028 0x00000004>; status = "okay"; cap-sd-highspeed; cap-mmc-highspeed; broken-cd; bus-width = <0x00000004>; clk-phase-sd-hs = <0x00000000 0x00000087>; phandle = <0x00000029>; }; => fdt print /soc/sysmgr@ffd06000 sysmgr@ffd06000 { compatible = "altr,sys-mgr"; reg = <0xffd06000 0x00000300>; cpu1-start-addr = <0xffd06230>; phandle = <0x0000001c>; };Quoted 1 line
[ 1.095784] mmc_host mmc0: Bus speed (slot 0) = 50000000Hz (slot req50000000Hz, actual 50000000HZ div = 0)
Quoted 4 lines
[ 1.105692] mmc0: new high speed SDHC card at address 0001 [ 1.108238] at24 0-0051: supply vcc not found, using dummy regulator [ 1.111817] mmcblk0: mmc0:0001 SD32G 29.1 GiB [ 1.118872] at24 0-0051: 4096 byte 24c32 EEPROM, writable, 32bytes/write
Quoted 11 lines
[ 1.129186] mmcblk0: p1 p2 p3.
root@arria10:~# ls /dev/mmcblk0* /dev/mmcblk0 /dev/mmcblk0p1 /dev/mmcblk0p2 /dev/mmcblk0p3 root@arria10:~# mount /dev/mmcblk0p1 /tmp/ root@arria10:~# ls /tmp/ extlinux socfpga_arria10_socdk_sdmmc.dtb zImage fit_spl_fpga.itb u-boot.imgYou didn't really test anything. There's a register in the System Manager that has set the SD/MMC clk-phase in U-Boot. So you won't see the failure unless you explicitly change the value in that register and then boot Linux, then you will see the failure. If you look at
drivers/mmc/host/dw_mmc-pltfm.cand look at the functiondw_mci_socfpga_priv_init(), you can see that work in action. If you remove the syscon property, then that portion of the driver will fail. Also the ethernet driver is using the system manager's to set the correct PHY mode through syscon. I think you need to test this patch more thoroughly.
Quoted 1 line
DInh
Altera System Manager driver (drivers/mfd/altera-sysmgr.c) is enabled in "socfpga_defconfig" - i.e. CONFIG_MFD_ALTERA_SYSMGR=y
So, SoCFPGA always using drivers/mfd/altera-sysmgr.c for System Manager register access, not the generic "syscon" drivers/mfd/syscon.c. That's why we do not need "syscon" compatible for fall back mechanism.
sysmgr: sysmgr@ffd08000 {
- compatible = "altr,sys-mgr", "syscon";
+ compatible = "altr,sys-mgr";
reg = <0xffd08000 0x4000>;
};
mmc: mmc@ff808000 {
…
altr,sysmgr-syscon = <&sysmgr 0x28 4>;
clk-phase-sd-hs = <0>, <135>;
…
};
gmac0: ethernet@ff800000 {
…
altr,sysmgr-syscon = <&sysmgr 0x44 0>;
…
};Even the sdmmc driver you mentioned is using "drivers/mfd/altera-sysmgr.c" not the generic "syscon" drivers/mfd/syscon.c. Same thing for ethernet driver as well.
dw_mci_socfpga_priv_init() {
...
rc = of_property_read_variable_u32_array(np, "clk-phase-sd-hs", &clk_phase[0], 2, 0);
if (rc < 0)
return 0;
sys_mgr_base_addr = altr_sysmgr_regmap_lookup_by_phandle(np, "altr,sysmgr-syscon");
if (IS_ERR(sys_mgr_base_addr)) {
dev_warn(host->dev, "clk-phase-sd-hs was specified, but failed to find altr,sys-mgr regmap!\n");
return 0;
}
of_property_read_u32_index(np, "altr,sysmgr-syscon", 1, ®_offset);
of_property_read_u32_index(np, "altr,sysmgr-syscon", 2, ®_shift);
...
}Please let me know if my understanding is incorrect.
Thanks,
Nirav
Dinh Nguyen
maintainerQuoted 120 lines · Niravkumar L
Hi Dinh,
Quoted 70 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 12:15 PM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 31 lines
Yes, I have tested this using NFS boot, however I didn't observe any issue with SD/MMC driver.
=> fdt print /soc/mmc@ff808000
mmc@ff808000 { #address-cells = <0x00000001>; #size-cells = <0x00000000>; compatible = "altr,socfpga-dw-mshc"; reg = <0xff808000 0x00001000>; interrupts = <0x00000000 0x00000062 0x00000004>; fifo-depth = <0x00000400>; clocks = <0x0000001a 0x00000024>; clock-names = "biu", "ciu"; resets = <0x00000006 0x00000027>; altr,sysmgr-syscon = <0x0000001c 0x00000028 0x00000004>; status = "okay"; cap-sd-highspeed; cap-mmc-highspeed; broken-cd; bus-width = <0x00000004>; clk-phase-sd-hs = <0x00000000 0x00000087>; phandle = <0x00000029>; }; => fdt print /soc/sysmgr@ffd06000 sysmgr@ffd06000 { compatible = "altr,sys-mgr"; reg = <0xffd06000 0x00000300>; cpu1-start-addr = <0xffd06230>; phandle = <0x0000001c>; };Quoted 1 line
[ 1.095784] mmc_host mmc0: Bus speed (slot 0) = 50000000Hz (slot req50000000Hz, actual 50000000HZ div = 0)
Quoted 4 lines
[ 1.105692] mmc0: new high speed SDHC card at address 0001 [ 1.108238] at24 0-0051: supply vcc not found, using dummy regulator [ 1.111817] mmcblk0: mmc0:0001 SD32G 29.1 GiB [ 1.118872] at24 0-0051: 4096 byte 24c32 EEPROM, writable, 32bytes/write
Quoted 11 lines
[ 1.129186] mmcblk0: p1 p2 p3.
root@arria10:~# ls /dev/mmcblk0* /dev/mmcblk0 /dev/mmcblk0p1 /dev/mmcblk0p2 /dev/mmcblk0p3 root@arria10:~# mount /dev/mmcblk0p1 /tmp/ root@arria10:~# ls /tmp/ extlinux socfpga_arria10_socdk_sdmmc.dtb zImage fit_spl_fpga.itb u-boot.imgYou didn't really test anything. There's a register in the System Manager that has set the SD/MMC clk-phase in U-Boot. So you won't see the failure unless you explicitly change the value in that register and then boot Linux, then you will see the failure. If you look at
drivers/mmc/host/dw_mmc-pltfm.cand look at the functiondw_mci_socfpga_priv_init(), you can see that work in action. If you remove the syscon property, then that portion of the driver will fail. Also the ethernet driver is using the system manager's to set the correct PHY mode through syscon. I think you need to test this patch more thoroughly.Quoted 1 line
DInh
Altera System Manager driver (
drivers/mfd/altera-sysmgr.c) is enabled in "socfpga_defconfig" - i.e.CONFIG_MFD_ALTERA_SYSMGR=ySo, SoCFPGA always using
drivers/mfd/altera-sysmgr.cfor System Manager register access, not the generic "syscon"drivers/mfd/syscon.c. That's why we do not need "syscon" compatible for fall back mechanism.sysmgr: sysmgr@ffd08000 {arch/arm/boot/dts/intel/socfpga/socfpga.dtsi +1
-1- compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd08000 0x4000>; };mmc: mmc@ff808000 { … altr,sysmgr-syscon = <&sysmgr 0x28 4>; clk-phase-sd-hs = <0>, <135>; … }; gmac0: ethernet@ff800000 { … altr,sysmgr-syscon = <&sysmgr 0x44 0>; … };Even the sdmmc driver you mentioned is using "
drivers/mfd/altera-sysmgr.c" not the generic "syscon"drivers/mfd/syscon.c. Same thing for ethernet driver as well.dw_mci_socfpga_priv_init() { ... rc = of_property_read_variable_u32_array(np, "clk-phase-sd-hs", &clk_phase[0], 2, 0); if (rc < 0) return 0; sys_mgr_base_addr = altr_sysmgr_regmap_lookup_by_phandle(np, "altr,sysmgr-syscon"); if (IS_ERR(sys_mgr_base_addr)) { dev_warn(host->dev, "clk-phase-sd-hs was specified, but failed to find altr,sys-mgr regmap!\n"); return 0; } of_property_read_u32_index(np, "altr,sysmgr-syscon", 1, ®_offset); of_property_read_u32_index(np, "altr,sysmgr-syscon", 2, ®_shift); ... }
Quoted 2 lines
Please let me know if my understanding is incorrect.
But the altera-sysmgr driver is using syscon as the interface:
config MFD_ALTERA_SYSMGR
bool "Altera SOCFPGA System Manager"
depends on ARCH_INTEL_SOCFPGA && OF
select MFD_SYSCON
Can you look at your bootlog and see if you see this message ""clk-phase-sd-hs was specified, but failed to find altr,sys-mgr regmap!"?
Dinh
Hi Dinh,
Quoted 142 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 8:25 PM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 69 lines · Niravkumar L
Hi Dinh,
Quoted 67 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 12:15 PM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 31 lines
Yes, I have tested this using NFS boot, however I didn't observe any issue with SD/MMC driver.
=> fdt print /soc/mmc@ff808000
mmc@ff808000 { #address-cells = <0x00000001>; #size-cells = <0x00000000>; compatible = "altr,socfpga-dw-mshc"; reg = <0xff808000 0x00001000>; interrupts = <0x00000000 0x00000062 0x00000004>; fifo-depth = <0x00000400>; clocks = <0x0000001a 0x00000024>; clock-names = "biu", "ciu"; resets = <0x00000006 0x00000027>; altr,sysmgr-syscon = <0x0000001c 0x00000028 0x00000004>; status = "okay"; cap-sd-highspeed; cap-mmc-highspeed; broken-cd; bus-width = <0x00000004>; clk-phase-sd-hs = <0x00000000 0x00000087>; phandle = <0x00000029>; }; => fdt print /soc/sysmgr@ffd06000 sysmgr@ffd06000 { compatible = "altr,sys-mgr"; reg = <0xffd06000 0x00000300>; cpu1-start-addr = <0xffd06230>; phandle = <0x0000001c>; };Quoted 1 line
[ 1.095784] mmc_host mmc0: Bus speed (slot 0) = 50000000Hz (slot req50000000Hz, actual 50000000HZ div = 0)
Quoted 4 lines
[ 1.105692] mmc0: new high speed SDHC card at address 0001 [ 1.108238] at24 0-0051: supply vcc not found, using dummy regulator [ 1.111817] mmcblk0: mmc0:0001 SD32G 29.1 GiB [ 1.118872] at24 0-0051: 4096 byte 24c32 EEPROM, writable, 32bytes/write
Quoted 11 lines
[ 1.129186] mmcblk0: p1 p2 p3.
root@arria10:~# ls /dev/mmcblk0* /dev/mmcblk0 /dev/mmcblk0p1 /dev/mmcblk0p2 /dev/mmcblk0p3 root@arria10:~# mount /dev/mmcblk0p1 /tmp/ root@arria10:~# ls /tmp/ extlinux socfpga_arria10_socdk_sdmmc.dtb zImage fit_spl_fpga.itb u-boot.imgYou didn't really test anything. There's a register in the System Manager that has set the SD/MMC clk-phase in U-Boot. So you won't see the failure unless you explicitly change the value in that register and then boot Linux, then you will see the failure. If you look at
drivers/mmc/host/dw_mmc-pltfm.cand look at the functiondw_mci_socfpga_priv_init(), you can see that work in action. If you removethe syscon property, then that portion of the driver will fail.
Quoted 2 lines
Quoted 2 lines
Also the ethernet driver is using the system manager's to set the correct PHY mode through syscon. I think you need to test this patch more
thoroughly.
Quoted 28 lines
Quoted 2 lines
DInh
Altera System Manager driver (
drivers/mfd/altera-sysmgr.c) is enabled in "socfpga_defconfig" - i.e.CONFIG_MFD_ALTERA_SYSMGR=ySo, SoCFPGA always using
drivers/mfd/altera-sysmgr.cfor System Manager register access, not the generic "syscon"drivers/mfd/syscon.c. That's why we do not need "syscon" compatible for fall back mechanism.sysmgr: sysmgr@ffd08000 {(quoted diff) +1
-1- compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd08000 0x4000>; };mmc: mmc@ff808000 { … altr,sysmgr-syscon = <&sysmgr 0x28 4>; clk-phase-sd-hs = <0>, <135>; … }; gmac0: ethernet@ff800000 { … altr,sysmgr-syscon = <&sysmgr 0x44 0>; … };Quoted 7 lines
Even the sdmmc driver you mentioned is using "
drivers/mfd/altera-sysmgr.c" not the generic "syscon"drivers/mfd/syscon.c. Same thing for ethernet driver as well.dw_mci_socfpga_priv_init() { ... rc = of_property_read_variable_u32_array(np, "clk-phase-sd-hs",&clk_phase[0], 2, 0);
Quoted 4 lines
if (rc < 0) return 0; sys_mgr_base_addr = altr_sysmgr_regmap_lookup_by_phandle(np,"altr,sysmgr-syscon");
Quoted 2 lines
if (IS_ERR(sys_mgr_base_addr)) { dev_warn(host->dev, "clk-phase-sd-hs was specified, but failedto find altr,sys-mgr regmap!\n");
Quoted 10 lines
return 0; } of_property_read_u32_index(np, "altr,sysmgr-syscon", 1, ®_offset); of_property_read_u32_index(np, "altr,sysmgr-syscon", 2, ®_shift); ... }Please let me know if my understanding is incorrect.
But the altera-sysmgr driver is using syscon as the interface:
Quoted 8 lines
config
MFD_ALTERA_SYSMGR
bool "Altera SOCFPGA System Manager"
depends onARCH_INTEL_SOCFPGA&& OF
selectMFD_SYSCONCan you look at your bootlog and see if you see this message ""clk-phase-sd-hs was specified, but failed to find altr,sys-mgr regmap!"?
No, I do not see this error/warning in boot log.
" clk-phase-sd-hs was specified, but failed to find altr,sys-mgr regmap!"
Also I did test by manually changing the clock phase register value in u-boot, and then boot Linux without "syscon" compatible, and I do not see any error or warning and sdmmc and ethernet drivers are working fine.
=> md.l 0xffd06028 1ffd06028: 00000003 ....
=> mw.l 0xffd06028 0x0
Thanks,
Nirav
Dinh Nguyen
maintainerQuoted 156 lines · Niravkumar L
Hi Dinh,
Quoted 142 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 8:25 PM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 69 lines · Niravkumar L
Hi Dinh,
Quoted 67 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 12:15 PM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 31 lines
Yes, I have tested this using NFS boot, however I didn't observe any issue with SD/MMC driver.
=> fdt print /soc/mmc@ff808000
mmc@ff808000 { #address-cells = <0x00000001>; #size-cells = <0x00000000>; compatible = "altr,socfpga-dw-mshc"; reg = <0xff808000 0x00001000>; interrupts = <0x00000000 0x00000062 0x00000004>; fifo-depth = <0x00000400>; clocks = <0x0000001a 0x00000024>; clock-names = "biu", "ciu"; resets = <0x00000006 0x00000027>; altr,sysmgr-syscon = <0x0000001c 0x00000028 0x00000004>; status = "okay"; cap-sd-highspeed; cap-mmc-highspeed; broken-cd; bus-width = <0x00000004>; clk-phase-sd-hs = <0x00000000 0x00000087>; phandle = <0x00000029>; }; => fdt print /soc/sysmgr@ffd06000 sysmgr@ffd06000 { compatible = "altr,sys-mgr"; reg = <0xffd06000 0x00000300>; cpu1-start-addr = <0xffd06230>; phandle = <0x0000001c>; };Quoted 1 line
[ 1.095784] mmc_host mmc0: Bus speed (slot 0) = 50000000Hz (slot req50000000Hz, actual 50000000HZ div = 0)
Quoted 4 lines
[ 1.105692] mmc0: new high speed SDHC card at address 0001 [ 1.108238] at24 0-0051: supply vcc not found, using dummy regulator [ 1.111817] mmcblk0: mmc0:0001 SD32G 29.1 GiB [ 1.118872] at24 0-0051: 4096 byte 24c32 EEPROM, writable, 32bytes/write
Quoted 11 lines
[ 1.129186] mmcblk0: p1 p2 p3.
root@arria10:~# ls /dev/mmcblk0* /dev/mmcblk0 /dev/mmcblk0p1 /dev/mmcblk0p2 /dev/mmcblk0p3 root@arria10:~# mount /dev/mmcblk0p1 /tmp/ root@arria10:~# ls /tmp/ extlinux socfpga_arria10_socdk_sdmmc.dtb zImage fit_spl_fpga.itb u-boot.imgYou didn't really test anything. There's a register in the System Manager that has set the SD/MMC clk-phase in U-Boot. So you won't see the failure unless you explicitly change the value in that register and then boot Linux, then you will see the failure. If you look at
drivers/mmc/host/dw_mmc-pltfm.cand look at the functiondw_mci_socfpga_priv_init(), you can see that work in action. If you removethe syscon property, then that portion of the driver will fail.
Quoted 2 lines
Quoted 2 lines
Also the ethernet driver is using the system manager's to set the correct PHY mode through syscon. I think you need to test this patch more
thoroughly.
Quoted 28 lines
Quoted 2 lines
DInh
Altera System Manager driver (
drivers/mfd/altera-sysmgr.c) is enabled in "socfpga_defconfig" - i.e.CONFIG_MFD_ALTERA_SYSMGR=ySo, SoCFPGA always using
drivers/mfd/altera-sysmgr.cfor System Manager register access, not the generic "syscon"drivers/mfd/syscon.c. That's why we do not need "syscon" compatible for fall back mechanism.sysmgr: sysmgr@ffd08000 {(quoted diff) +1
-1- compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd08000 0x4000>; };mmc: mmc@ff808000 { … altr,sysmgr-syscon = <&sysmgr 0x28 4>; clk-phase-sd-hs = <0>, <135>; … }; gmac0: ethernet@ff800000 { … altr,sysmgr-syscon = <&sysmgr 0x44 0>; … };Quoted 7 lines
Even the sdmmc driver you mentioned is using "
drivers/mfd/altera-sysmgr.c" not the generic "syscon"drivers/mfd/syscon.c. Same thing for ethernet driver as well.dw_mci_socfpga_priv_init() { ... rc = of_property_read_variable_u32_array(np, "clk-phase-sd-hs",&clk_phase[0], 2, 0);
Quoted 4 lines
if (rc < 0) return 0; sys_mgr_base_addr = altr_sysmgr_regmap_lookup_by_phandle(np,"altr,sysmgr-syscon");
Quoted 2 lines
if (IS_ERR(sys_mgr_base_addr)) { dev_warn(host->dev, "clk-phase-sd-hs was specified, but failedto find altr,sys-mgr regmap!\n");
Quoted 10 lines
return 0; } of_property_read_u32_index(np, "altr,sysmgr-syscon", 1, ®_offset); of_property_read_u32_index(np, "altr,sysmgr-syscon", 2, ®_shift); ... }Please let me know if my understanding is incorrect.
But the altera-sysmgr driver is using syscon as the interface:
Quoted 8 lines
config
MFD_ALTERA_SYSMGR
bool "Altera SOCFPGA System Manager"
depends onARCH_INTEL_SOCFPGA&& OF
selectMFD_SYSCONCan you look at your bootlog and see if you see this message ""clk-phase-sd-hs was specified, but failed to find altr,sys-mgr regmap!"?
No, I do not see this error/warning in boot log.
" clk-phase-sd-hs was specified, but failed to find altr,sys-mgr regmap!"
Quoted 8 lines
Also I did test by manually changing the clock phase register value in u-boot, and then boot Linux without "syscon" compatible, and I do not see any error or warning and sdmmc and ethernet drivers are working fine.
=> md.l
0xffd060281ffd06028: 00000003 ....
=> mw.l0xffd060280x0
Can you try an image that removes MFD_SYSCON from the MFD_ALTERA_SYSMGR?
Hi Dinh,
Quoted 176 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 8:57 PM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 59 lines · Niravkumar L
Hi Dinh,
Quoted 57 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 8:25 PM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 45 lines · Niravkumar L
Hi Dinh,
Quoted 43 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 12:15 PM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 32 lines
Yes, I have tested this using NFS boot, however I didn't observe any issue with SD/MMC driver.
=> fdt print /soc/mmc@ff808000
mmc@ff808000 { #address-cells = <0x00000001>; #size-cells = <0x00000000>; compatible = "altr,socfpga-dw-mshc"; reg = <0xff808000 0x00001000>; interrupts = <0x00000000 0x00000062 0x00000004>; fifo-depth = <0x00000400>; clocks = <0x0000001a 0x00000024>; clock-names = "biu", "ciu"; resets = <0x00000006 0x00000027>; altr,sysmgr-syscon = <0x0000001c 0x00000028 0x00000004>; status = "okay"; cap-sd-highspeed; cap-mmc-highspeed; broken-cd; bus-width = <0x00000004>; clk-phase-sd-hs = <0x00000000 0x00000087>; phandle = <0x00000029>; }; => fdt print /soc/sysmgr@ffd06000 sysmgr@ffd06000 { compatible = "altr,sys-mgr"; reg = <0xffd06000 0x00000300>; cpu1-start-addr = <0xffd06230>; phandle = <0x0000001c>; };[ 1.095784] mmc_host mmc0: Bus speed (slot 0) = 50000000Hz (slotreq
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
50000000Hz, actual 50000000HZ div = 0)
Quoted 4 lines
[ 1.105692] mmc0: new high speed SDHC card at address 0001 [ 1.108238] at24 0-0051: supply vcc not found, using dummy regulator [ 1.111817] mmcblk0: mmc0:0001 SD32G 29.1 GiB [ 1.118872] at24 0-0051: 4096 byte 24c32 EEPROM, writable, 32Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
bytes/write
Quoted 7 lines
[ 1.129186] mmcblk0: p1 p2 p3.
root@arria10:~# ls /dev/mmcblk0* /dev/mmcblk0 /dev/mmcblk0p1 /dev/mmcblk0p2 /dev/mmcblk0p3 root@arria10:~# mount /dev/mmcblk0p1 /tmp/ root@arria10:~# ls
/tmp/Quoted 90 lines
Quoted 74 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
extlinux socfpga_arria10_socdk_sdmmc.dtb zImage
fit_spl_fpga.itb u-boot.imgQuoted 7 lines
Quoted 7 lines
You didn't really test anything. There's a register in the System Manager that has set the SD/MMC clk-phase in U-Boot. So you won't see the failure unless you explicitly change the value in that register and then boot Linux, then you will see the failure. If you look at
drivers/mmc/host/dw_mmc-pltfm.cand look at the functiondw_mci_socfpga_priv_init(), you can see that work in action. If you removethe syscon property, then that portion of the driver will fail.
Quoted 3 lines
Quoted 3 lines
Also the ethernet driver is using the system manager's to set the correct PHY mode through syscon. I think you need to test this patch more
thoroughly.
Quoted 28 lines
Quoted 2 lines
DInh
Altera System Manager driver (
drivers/mfd/altera-sysmgr.c) is enabled in "socfpga_defconfig" - i.e.CONFIG_MFD_ALTERA_SYSMGR=ySo, SoCFPGA always using
drivers/mfd/altera-sysmgr.cfor System Manager register access, not the generic "syscon"drivers/mfd/syscon.c. That's why we do not need "syscon" compatible for fall back mechanism.sysmgr: sysmgr@ffd08000 {(quoted diff) +1
-1- compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd08000 0x4000>; };mmc: mmc@ff808000 { … altr,sysmgr-syscon = <&sysmgr 0x28 4>; clk-phase-sd-hs = <0>, <135>; … }; gmac0: ethernet@ff800000 { … altr,sysmgr-syscon = <&sysmgr 0x44 0>; … };Quoted 7 lines
Even the sdmmc driver you mentioned is using "
drivers/mfd/altera-sysmgr.c" not the generic "syscon"drivers/mfd/syscon.c. Same thing for ethernet driver as well.dw_mci_socfpga_priv_init() { ... rc = of_property_read_variable_u32_array(np, "clk-phase-sd-hs",&clk_phase[0], 2, 0);
Quoted 4 lines
if (rc < 0) return 0; sys_mgr_base_addr = altr_sysmgr_regmap_lookup_by_phandle(np,"altr,sysmgr-syscon");
Quoted 2 lines
if (IS_ERR(sys_mgr_base_addr)) { dev_warn(host->dev, "clk-phase-sd-hs was specified, but failedto find altr,sys-mgr regmap!\n");
Quoted 10 lines
return 0; } of_property_read_u32_index(np, "altr,sysmgr-syscon", 1, ®_offset); of_property_read_u32_index(np, "altr,sysmgr-syscon", 2, ®_shift); ... }Please let me know if my understanding is incorrect.
But the altera-sysmgr driver is using syscon as the interface:
Quoted 8 lines
config
MFD_ALTERA_SYSMGR
bool "Altera SOCFPGA System Manager"
depends onARCH_INTEL_SOCFPGA&& OF
selectMFD_SYSCONCan you look at your bootlog and see if you see this message ""clk-phase-sd-hs was specified, but failed to find altr,sys-mgr regmap!"?
No, I do not see this error/warning in boot log.
" clk-phase-sd-hs was specified, but failed to find altr,sys-mgr regmap!"Also I did test by manually changing the clock phase register value in u-boot, and then boot Linux without "syscon" compatible, and I do not see any error or warning and sdmmc and ethernet drivers are working fine.
Quoted 7 lines
Quoted 4 lines
=> md.l
0xffd060281ffd06028: 00000003 ....
=> mw.l0xffd060280x0Can you try an image that removes
MFD_SYSCONfrom theMFD_ALTERA_SYSMGR?
Tried image without MFD_SYSCON in MFD_ALTERA_SYSMGR - Kconfig, it still works without any error/warning.
Thanks,
Nirav
Dinh Nguyen
maintainerQuoted 183 lines · Niravkumar L
Hi Dinh,
Quoted 181 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 8:57 PM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 59 lines · Niravkumar L
Hi Dinh,
Quoted 57 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 8:25 PM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 45 lines · Niravkumar L
Hi Dinh,
Quoted 43 lines
-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Tuesday, 11 February, 2025 12:15 PM
To: Rabara, Niravkumar L <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; linux- [email protected]
Cc: lkp <[email protected]>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr nodeQuoted 32 lines
Yes, I have tested this using NFS boot, however I didn't observe any issue with SD/MMC driver.
=> fdt print /soc/mmc@ff808000
mmc@ff808000 { #address-cells = <0x00000001>; #size-cells = <0x00000000>; compatible = "altr,socfpga-dw-mshc"; reg = <0xff808000 0x00001000>; interrupts = <0x00000000 0x00000062 0x00000004>; fifo-depth = <0x00000400>; clocks = <0x0000001a 0x00000024>; clock-names = "biu", "ciu"; resets = <0x00000006 0x00000027>; altr,sysmgr-syscon = <0x0000001c 0x00000028 0x00000004>; status = "okay"; cap-sd-highspeed; cap-mmc-highspeed; broken-cd; bus-width = <0x00000004>; clk-phase-sd-hs = <0x00000000 0x00000087>; phandle = <0x00000029>; }; => fdt print /soc/sysmgr@ffd06000 sysmgr@ffd06000 { compatible = "altr,sys-mgr"; reg = <0xffd06000 0x00000300>; cpu1-start-addr = <0xffd06230>; phandle = <0x0000001c>; };[ 1.095784] mmc_host mmc0: Bus speed (slot 0) = 50000000Hz (slotreq
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
50000000Hz, actual 50000000HZ div = 0)
Quoted 4 lines
[ 1.105692] mmc0: new high speed SDHC card at address 0001 [ 1.108238] at24 0-0051: supply vcc not found, using dummy regulator [ 1.111817] mmcblk0: mmc0:0001 SD32G 29.1 GiB [ 1.118872] at24 0-0051: 4096 byte 24c32 EEPROM, writable, 32Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
bytes/write
Quoted 7 lines
[ 1.129186] mmcblk0: p1 p2 p3.
root@arria10:~# ls /dev/mmcblk0* /dev/mmcblk0 /dev/mmcblk0p1 /dev/mmcblk0p2 /dev/mmcblk0p3 root@arria10:~# mount /dev/mmcblk0p1 /tmp/ root@arria10:~# ls
/tmp/Quoted 94 lines
Quoted 74 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
extlinux socfpga_arria10_socdk_sdmmc.dtb zImage
fit_spl_fpga.itb u-boot.imgQuoted 7 lines
Quoted 7 lines
You didn't really test anything. There's a register in the System Manager that has set the SD/MMC clk-phase in U-Boot. So you won't see the failure unless you explicitly change the value in that register and then boot Linux, then you will see the failure. If you look at
drivers/mmc/host/dw_mmc-pltfm.cand look at the functiondw_mci_socfpga_priv_init(), you can see that work in action. If you removethe syscon property, then that portion of the driver will fail.
Quoted 3 lines
Quoted 3 lines
Also the ethernet driver is using the system manager's to set the correct PHY mode through syscon. I think you need to test this patch more
thoroughly.
Quoted 28 lines
Quoted 2 lines
DInh
Altera System Manager driver (
drivers/mfd/altera-sysmgr.c) is enabled in "socfpga_defconfig" - i.e.CONFIG_MFD_ALTERA_SYSMGR=ySo, SoCFPGA always using
drivers/mfd/altera-sysmgr.cfor System Manager register access, not the generic "syscon"drivers/mfd/syscon.c. That's why we do not need "syscon" compatible for fall back mechanism.sysmgr: sysmgr@ffd08000 {(quoted diff) +1
-1- compatible = "altr,sys-mgr", "syscon"; + compatible = "altr,sys-mgr"; reg = <0xffd08000 0x4000>; };mmc: mmc@ff808000 { … altr,sysmgr-syscon = <&sysmgr 0x28 4>; clk-phase-sd-hs = <0>, <135>; … }; gmac0: ethernet@ff800000 { … altr,sysmgr-syscon = <&sysmgr 0x44 0>; … };Quoted 7 lines
Even the sdmmc driver you mentioned is using "
drivers/mfd/altera-sysmgr.c" not the generic "syscon"drivers/mfd/syscon.c. Same thing for ethernet driver as well.dw_mci_socfpga_priv_init() { ... rc = of_property_read_variable_u32_array(np, "clk-phase-sd-hs",&clk_phase[0], 2, 0);
Quoted 4 lines
if (rc < 0) return 0; sys_mgr_base_addr = altr_sysmgr_regmap_lookup_by_phandle(np,"altr,sysmgr-syscon");
Quoted 2 lines
if (IS_ERR(sys_mgr_base_addr)) { dev_warn(host->dev, "clk-phase-sd-hs was specified, but failedto find altr,sys-mgr regmap!\n");
Quoted 10 lines
return 0; } of_property_read_u32_index(np, "altr,sysmgr-syscon", 1, ®_offset); of_property_read_u32_index(np, "altr,sysmgr-syscon", 2, ®_shift); ... }Please let me know if my understanding is incorrect.
But the altera-sysmgr driver is using syscon as the interface:
Quoted 8 lines
config
MFD_ALTERA_SYSMGR
bool "Altera SOCFPGA System Manager"
depends onARCH_INTEL_SOCFPGA&& OF
selectMFD_SYSCONCan you look at your bootlog and see if you see this message ""clk-phase-sd-hs was specified, but failed to find altr,sys-mgr regmap!"?
No, I do not see this error/warning in boot log.
" clk-phase-sd-hs was specified, but failed to find altr,sys-mgr regmap!"Also I did test by manually changing the clock phase register value in u-boot, and then boot Linux without "syscon" compatible, and I do not see any error or warning and sdmmc and ethernet drivers are working fine.
=> md.l
0xffd060281ffd06028: 00000003 ....
=> mw.l0xffd060280x0
Quoted 6 lines
Quoted 2 lines
Can you try an image that removes
MFD_SYSCONfrom theMFD_ALTERA_SYSMGR?Tried image without
MFD_SYSCONinMFD_ALTERA_SYSMGR-Kconfig, it still works without any error/warning.
Then something has changed and I'd like for you to investigate what changed. This whole driver is using syscon, and now it appears that it's not? It doesn't make sense to me. Please investigate more.
Dinh