kconfig: fix memory leak in sym_warn_unmet_dep()
PATCH 1/1 kconfig: fix memory leak in sym_warn_unmet_dep()
The string allocated in sym_warn_unmet_dep() is never freed, leading to a memory leak when an unmet dependency is detected.
Fixes f8f69dc0b4e0 ("kconfig: make unmet dependency warnings readable")
Signed-off-by Masahiro Yamada <[email protected]>
---
scripts/kconfig/symbol.c | 1 + 1 file changed, 1 insertion(+)
scripts/kconfig/symbol.c +1 -0
@@ -389,6 +389,7 @@ static void sym_warn_unmet_dep(const struct symbol *sym)fputs (str_get (&gs), stderr); sym_warnings++; +str_free (&gs); }bool sym_dep_errors (void )
Signature · 1 line
2.43.0
Hi Masahiro,
Quoted 2 lines
The string allocated in
sym_warn_unmet_dep()is never freed, leading to a memory leak when an unmet dependency is detected.
Reviewed-by Petr Vorel <[email protected]>
+1
I looked at other str_new() uses, but all looks to be using str_free() (or return a pointer, which is freed by the caller).
Kind regards,
Petr
Quoted 19 lines
Fixes f8f69dc0b4e0 ("kconfig: make unmet dependency warnings readable")Signed-off-by Masahiro Yamada <[email protected]>---
scripts/kconfig/symbol.c | 1 + 1 file changed, 1 insertion(+)scripts/kconfig/symbol.c +1
-0@@ -389,6 +389,7 @@ static void sym_warn_unmet_dep(const struct symbol *sym)fputs (str_get (&gs), stderr); sym_warnings++; +str_free (&gs); }bool sym_dep_errors (void )