Skip to contentSkip to conversation

ALSA: lola: Remove unused lola_(save|restore)_mixer

PATCH Superseded [email protected] 1 participant 2 messages Jan 22, 2025 Sound

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: lola: Remove unused lola_(save|restore)_mixer

From: "Dr. David Alan Gilbert" <[email protected]>

lola_restore_mixer() and lola_save_mixer() were added in 2011 by commit d43f3010b8fa ("ALSA: Add the driver for Digigram Lola PCI-e boards")
but have remain unused.

Remove them.

---
 sound/pci/lola/lola.h | 2 --
 1 file changed, 2 deletions(-)
sound/pci/lola/lola.h +0 -2
index 0ff772cf66e6..25f72f9e3f9b 100644
@@ -499,8 +499,6 @@ int lola_init_mixer_widget(struct lola *chip, int nid);
 void lola_free_mixer(struct lola *chip);
 int lola_create_mixer(struct lola *chip);
 int lola_setup_all_analog_gains(struct lola *chip, int dir, bool mute);
-void lola_save_mixer(struct lola *chip);
-void lola_restore_mixer(struct lola *chip);
 int lola_set_src_config(struct lola *chip, unsigned int src_mask, bool update);
 
 /* proc */
Signature · 1 line
2.48.1
#1 lore raw
Quoted 8 lines · * [email protected] ([email protected]) wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

lola_restore_mixer() and lola_save_mixer() were added in 2011 by commit d43f3010b8fa ("ALSA: Add the driver for Digigram Lola PCI-e boards")
but have remain unused.

Remove them.

NAK!
This lost the .c file change.
I'll do a v2.

Dave

Quoted 21 lines
---
 sound/pci/lola/lola.h | 2 --
 1 file changed, 2 deletions(-)
sound/pci/lola/lola.h +0 -2
index 0ff772cf66e6..25f72f9e3f9b 100644
@@ -499,8 +499,6 @@ int lola_init_mixer_widget(struct lola *chip, int nid);
 void lola_free_mixer(struct lola *chip);
 int lola_create_mixer(struct lola *chip);
 int lola_setup_all_analog_gains(struct lola *chip, int dir, bool mute);
-void lola_save_mixer(struct lola *chip);
-void lola_restore_mixer(struct lola *chip);
 int lola_set_src_config(struct lola *chip, unsigned int src_mask, bool update);
 
 /* proc */
Signature · 1 line
2.48.1
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/