Skip to contentSkip to conversation

sched_ext: Include task weight in the error state dump

PATCH Applied Andrea Righi 2 participants 2 messages Jan 22, 2025 – Jan 24, 2025 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched_ext: Include task weight in the error state dump

Report the task weight when dumping the task state during an error exit. Moreover, adjust the output format to display dsq_vtime, slice, and weight on the same line.

This can help identify whether certain tasks were excessively prioritized or de-prioritized due to large niceness gaps.

---
 kernel/sched/ext.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
kernel/sched/ext.c +4 -3
index 64967d28da7f..99179aa6f7dd 100644
@@ -5230,9 +5230,10 @@ static void scx_dump_task(struct seq_buf *s, struct scx_dump_ctx *dctx,
 		  scx_get_task_state(p), p->scx.flags & ~SCX_TASK_STATE_MASK,
 		  p->scx.dsq_flags, ops_state & SCX_OPSS_STATE_MASK,
 		  ops_state >> SCX_OPSS_QSEQ_SHIFT);
-	dump_line(s, "      sticky/holding_cpu=%d/%d dsq_id=%s dsq_vtime=%llu slice=%llu",
-		  p->scx.sticky_cpu, p->scx.holding_cpu, dsq_id_buf,
-		  p->scx.dsq_vtime, p->scx.slice);
+	dump_line(s, "      sticky/holding_cpu=%d/%d dsq_id=%s",
+		  p->scx.sticky_cpu, p->scx.holding_cpu, dsq_id_buf);
+	dump_line(s, "      dsq_vtime=%llu slice=%llu weight=%u",
+		  p->scx.dsq_vtime, p->scx.slice, p->scx.weight);
 	dump_line(s, "      cpus=%*pb", cpumask_pr_args(p->cpus_ptr));
 
 	if (SCX_HAS_OP(dump_task)) {
Signature · 1 line
2.48.1
Applied
#1 lore raw
Quoted 8 lines · Andrea Righi

Report the task weight when dumping the task state during an error exit. Moreover, adjust the output format to display dsq_vtime, slice, and weight on the same line.

This can help identify whether certain tasks were excessively prioritized or de-prioritized due to large niceness gaps.

Applied to sched_ext/for-6.14-fixes.

Thanks.

Signature · 1 line
tejun