AF9005: fix typo in the bitmask size
PATCH 1/1 AF9005: fix typo in the bitmask size
Found by ALT Linux Team (altlinux.org) and Linux Verification Center (linuxtesting.org)
drivers/media/usb/dvb-usb/af9005-fe.c +0 -0
@@ -453,7 +453,7 @@ static int af9005_fe_read_status(struct dvb_frontend *fe,
ret = af9005_read_register_bits(state->d, xd_r_mp2if_sync_byte_locked, mp2if_sync_byte_locked_pos, - mp2if_sync_byte_locked_pos, &temp); + mp2if_sync_byte_locked_len, &temp); if (ret) return ret; if (temp)
Signature · 3 lines
Alexey V. Vissarionov gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net
Hi,
The same patch was sent twice [1,2]. Why? If something has changed, it's good to denote the next version as v2 and briefly explain the v1->v2 changes in the zone after ---.
[1]: https://lore.kernel.org/linux-media/[email protected]/
[2]: https://lore.kernel.org/linux-media/[email protected]/
Quoted 2 lines · Alexey V. Vissarionov
Found by ALT Linux Team (altlinux.org) and Linux Verification Center (linuxtesting.org)
Even for the one-line fixes there should be some brief explanation on *why* there is a problem and why it should be fixed, i.e. why there is a typo in the code.
I guess the problem looks obvious here but still there may be some useful information (if any) provided to the changelog.
Quoted 3 lines
Fixes af4e067e1dcf ("V4L/DVB (5625): Add support for the AF9005 demodulator from Afatech")
The blank line between Fixes and Signed-off-by is unwanted.
Quoted 1 line
Signed-off-by Alexey V. Vissarionov <[email protected]>
git format-patch usually generates a --- line here after the end of the commit message.
Please take a look at [3].
[3]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
Quoted 19 lines
drivers/media/usb/dvb-usb/af9005-fe.c +1
-1@@ -453,7 +453,7 @@ static int af9005_fe_read_status(struct dvb_frontend *fe, ret =af9005_read_register_bits (state->d, xd_r_mp2if_sync_byte_locked, mp2if_sync_byte_locked_pos, - mp2if_sync_byte_locked_pos, &temp); + mp2if_sync_byte_locked_len, &temp);if (ret)return ret;if (temp)Signature · 4 lines
-- Alexey V. Vissarionov gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net