Skip to contentSkip to conversation

busybox: Correct SPDX license reference

PATCH In review Bastian Germann 2 participants 3 messages Jan 24, 2025 – Jan 25, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 busybox: Correct SPDX license reference

Commit 6238ee3ecd (recipes-core/busybox: fixup licensing information) claims that there is no applicable license identifier in SPDX, so a bzip2-1.0.4 is made up.

There is no bzip2-1.0.4 license defined in SPDX. However, bzip2-1.0.6 is the same license.

License-Update: wrong SPDX identifier

---
 meta/recipes-core/busybox/busybox.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/busybox/busybox.inc +1 -1
index f778cff0f4..cebfd3c48c 100644
@@ -7,7 +7,7 @@ DEPENDS += "kern-tools-native virtual/crypt"
 
 # bzip2 applet in busybox is based on lightly-modified bzip2-1.0.4 source
 # the GPL is version 2 only
-LICENSE = "GPL-2.0-only & bzip2-1.0.4"
+LICENSE = "GPL-2.0-only & bzip2-1.0.6"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=de10de48642ab74318e893a61105afbb \
                     file://archival/libarchive/bz/LICENSE;md5=28e3301eae987e8cfe19988e98383dae"
 
#1 lore raw
Quoted 24 lines · Bastian Germann via lists.openembedded.org

Commit 6238ee3ecd (recipes-core/busybox: fixup licensing information) claims that there is no applicable license identifier in SPDX, so a bzip2-1.0.4 is made up.

There is no bzip2-1.0.4 license defined in SPDX. However, bzip2-1.0.6 is the same license.

License-Update: wrong SPDX identifier

---
 meta/recipes-core/busybox/busybox.inc | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/busybox/busybox.inc +0 -0
index f778cff0f4..cebfd3c48c 100644
@@ -7,7 +7,7 @@ DEPENDS += "kern-tools-native virtual/crypt"

 # bzip2 applet in busybox is based on lightly-modified bzip2-1.0.4 source
 # the GPL is version 2 only
meta/recipes-core/busybox/busybox.inc +1 -1
-LICENSE = "GPL-2.0-only & bzip2-1.0.4"
+LICENSE = "GPL-2.0-only & bzip2-1.0.6"
Quoted 2 lines

 LIC_FILES_CHKSUM = "file://LICENSE;md5=de10de48642ab74318e893a61105afbb \
                     file://archival/libarchive/bz/LICENSE;md5=28e3301eae987e8cfe19988e98383dae"

There is a bit of confusion here:

https://git.yoctoproject.org/poky/commit/meta/recipes-core/busybox/busybox.inc?h=master&id=0776bf6600c42cec2961d3f6d33c8c9c09cbb1ce

Is the 1.0.4 and 1.0.6 license different or not?

Cheers,

Richard

#2 lore raw

Am 25.01.25 um 16:14 schrieb Richard Purdie:

Quoted 30 lines · Bastian Germann via lists.openembedded.org
Quoted 19 lines

Commit 6238ee3ecd (recipes-core/busybox: fixup licensing information) claims that there is no applicable license identifier in SPDX, so a bzip2-1.0.4 is made up.

There is no bzip2-1.0.4 license defined in SPDX. However, bzip2-1.0.6 is the same license.

License-Update: wrong SPDX identifier

---
  meta/recipes-core/busybox/busybox.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/busybox/busybox.inc +0 -0
index f778cff0f4..cebfd3c48c 100644

meta/recipes-core/busybox/busybox.inc DEPENDS += "kern-tools-native virtual/crypt" · line 12

Quoted 7 lines
meta/recipes-core/busybox/busybox.inc +1 -1
@@ -7,7 +7,7 @@ DEPENDS += "kern-tools-native virtual/crypt"
 
  # bzip2 applet in busybox is based on lightly-modified bzip2-1.0.4 source
  # the GPL is version 2 only
-LICENSE = "GPL-2.0-only & bzip2-1.0.4"
+LICENSE = "GPL-2.0-only & bzip2-1.0.6"
  LIC_FILES_CHKSUM = "file://LICENSE;md5=de10de48642ab74318e893a61105afbb \
                      file://archival/libarchive/bz/LICENSE;md5=28e3301eae987e8cfe19988e98383dae"

There is a bit of confusion here:

Quoted 3 lines

https://git.yoctoproject.org/poky/commit/meta/recipes-core/busybox/busybox.inc?h=master&id=0776bf6600c42cec2961d3f6d33c8c9c09cbb1ce

Is the 1.0.4 and 1.0.6 license different or not?

They are not. You can simply diff the LICENSE FILE and will only find differences in the SPDX-optional copyright statements: https://github.com/libarchive/bzip2/compare/bzip2-1.0.4...bzip2-1.0.6#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7

SPDX should have done a better naming job...