Skip to contentSkip to conversation

scsi: mvsas: remove unused mvs_phys_reset

PATCH Applied [email protected] 2 participants 3 messages Jan 27, 2025 – Feb 10, 2025 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: mvsas: remove unused mvs_phys_reset

From: "Dr. David Alan Gilbert" <[email protected]>

mvs_phys_reset() was added in 2009's
commit 20b09c2992fe ("[SCSI] mvsas: add support for 94xx; layout change; bug fixes")
but hasn't been used.

Remove it.

---
 drivers/scsi/mvsas/mv_sas.c | 10 ----------
 drivers/scsi/mvsas/mv_sas.h |  1 -
 2 files changed, 11 deletions(-)
drivers/scsi/mvsas/mv_sas.c +0 -10
index 1444b1f1c4c8..c4592de4fefc 100644
@@ -151,16 +151,6 @@ static inline u8 mvs_assign_reg_set(struct mvs_info *mvi,
 	return MVS_CHIP_DISP->assign_reg_set(mvi, &dev->taskfileset);
 }
 
-void mvs_phys_reset(struct mvs_info *mvi, u32 phy_mask, int hard)
-{
-	u32 no;
-	for_each_phy(phy_mask, phy_mask, no) {
-		if (!(phy_mask & 1))
-			continue;
-		MVS_CHIP_DISP->phy_reset(mvi, no, hard);
-	}
-}
-
 int mvs_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func,
 			void *funcdata)
 {
drivers/scsi/mvsas/mv_sas.h +0 -1
index 19b01f7c4767..09ce3f2241f2 100644
@@ -425,7 +425,6 @@ struct mvs_task_exec_info {
 void mvs_get_sas_addr(void *buf, u32 buflen);
 void mvs_iounmap(void __iomem *regs);
 int mvs_ioremap(struct mvs_info *mvi, int bar, int bar_ex);
-void mvs_phys_reset(struct mvs_info *mvi, u32 phy_mask, int hard);
 int mvs_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func,
 			void *funcdata);
 void mvs_set_sas_addr(struct mvs_info *mvi, int port_id, u32 off_lo,
Signature · 1 line
2.48.1
#1 lore raw
Quoted 5 lines

mvs_phys_reset() was added in 2009's
commit 20b09c2992fe ("[SCSI] mvsas: add support for 94xx; layout change; bug fixes")
but hasn't been used.

Applied to 6.15/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to [email protected]
Quoted 8 lines · On Mon, 27 Jan 2025 00:26:01 +0000, [email protected] wrote:

mvs_phys_reset() was added in 2009's
commit 20b09c2992fe ("[SCSI] mvsas: add support for 94xx; layout change; bug fixes")
but hasn't been used.

Remove it.

[...]

Applied to 6.15/scsi-queue, thanks!

[1/1] scsi: mvsas: remove unused mvs_phys_reset

      https://git.kernel.org/mkp/scsi/c/a307d6ec1239
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering