Skip to contentSkip to conversation

netdev: Don't use external auth with PMKSA

RFC New James Prestwood 1 participant 1 message Jan 27, 2025

lore
Share & tools
lore
#0 lore raw

RFC 1/1 netdev: Don't use external auth with PMKSA

Based on user reports the driver seems to get confused when external auth is used along with including a PMKID.

---
 src/netdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
src/netdev.c +3 -1
index 2a6d94fc..addddff9 100644
@@ -2499,7 +2499,9 @@ static struct l_genl_msg *netdev_build_cmd_connect(struct netdev *netdev,
 	case CONNECTION_TYPE_SOFTMAC:
 		break;
 	case CONNECTION_TYPE_FULLMAC:
-		l_genl_msg_append_attr(msg,
+		/* If we have a PMKSA for SAE we won't be doing external auth */
+		if (IE_AKM_IS_SAE(hs->akm_suite) && !hs->have_pmksa)
+			l_genl_msg_append_attr(msg,
 				NL80211_ATTR_EXTERNAL_AUTH_SUPPORT, 0, NULL);
 		break;
 	case CONNECTION_TYPE_SAE_OFFLOAD:
Signature · 1 line
2.34.1