mlx4: Remove unused functions
Subsystems (5)
RFC 1/1 mlx4: Remove unused functions
From: "Dr. David Alan Gilbert" <[email protected]>
The last use of mlx4_find_cached_mac() was removed in 2014 by commit 2f5bb473681b ("mlx4: Add ref counting to port MAC table for RoCE")
mlx4_zone_free_entries() was added in 2014 by
commit 7a89399ffad7 ("net/mlx4: Add mlx4_bitmap zone allocator") but hasn't been used. (The _unique version is used)
Remove them.
--- drivers/net/ethernet/mellanox/mlx4/alloc.c | 22 ---------------------- drivers/net/ethernet/mellanox/mlx4/mlx4.h | 6 ------ drivers/net/ethernet/mellanox/mlx4/port.c | 20 -------------------- include/linux/mlx4/device.h | 1 - 4 files changed, 49 deletions(-)
drivers/net/ethernet/mellanox/mlx4/alloc.c +0 -22
@@ -526,28 +526,6 @@ u32 mlx4_zone_alloc_entries(struct mlx4_zone_allocator *zones, u32 uid, int counreturn res; } -u32 mlx4_zone_free_entries (struct mlx4_zone_allocator *zones,u32 uid,u32 obj,u32 count) -{ -struct mlx4_zone_entry *zone; -int res =0 ; - -spin_lock (&zones->lock); - - zone =__mlx4_find_zone_by_uid (zones, uid); - -if (NULL == zone) { - res =-1 ; - goto out; - } - -__mlx4_free_from_zone (zone, obj, count); - -out: -spin_unlock (&zones->lock); - -return res; -} -u32 mlx4_zone_free_entries_unique (struct mlx4_zone_allocator *zones,u32 obj,u32 count) {struct mlx4_zone_entry *zone;
drivers/net/ethernet/mellanox/mlx4/mlx4.h +0 -6
@@ -1478,12 +1478,6 @@ void mlx4_zone_allocator_destroy(struct mlx4_zone_allocator *zone_alloc);u32 mlx4_zone_alloc_entries (struct mlx4_zone_allocator *zones,u32 uid,int count,int align,u32 skip_mask,u32 *puid); -/* Free <count> objects, start from <obj> of the uid <uid> from zone_allocator -* <zones>. -*/ -u32 mlx4_zone_free_entries (struct mlx4_zone_allocator *zones, -u32 uid,u32 obj,u32 count); -/* If <zones> was allocated with MLX4_ZONE_ALLOC_FLAGS_NO_OVERLAP, instead of * specifying the uid when freeing an object, zone allocator could figure it by * itself. Other parameters are similar to mlx4_zone_free.
drivers/net/ethernet/mellanox/mlx4/port.c +0 -20
@@ -147,26 +147,6 @@ static int mlx4_set_port_mac_table(struct mlx4_dev *dev, u8 port,return err; } -int mlx4_find_cached_mac (struct mlx4_dev *dev,u8 port,u64 mac,int *idx) -{ -struct mlx4_port_info *info = &mlx4_priv (dev)->port[port]; -struct mlx4_mac_table *table = &info->mac_table; -int i; - -for (i =0 ; i <MLX4_MAX_MAC_NUM ; i++) { -if (!table->refs[i]) -continue ; - -if (mac == (MLX4_MAC_MASK &be64_to_cpu (table->entries[i]))) { - *idx = i; -return 0 ; - } - } - -return -ENOENT ; -} -EXPORT_SYMBOL_GPL (mlx4_find_cached_mac); -static bool mlx4_need_mf_bond (struct mlx4_dev *dev) {int i, num_eth_ports =0 ;
include/linux/mlx4/device.h +0 -1
@@ -1415,7 +1415,6 @@ int mlx4_get_is_vlan_offload_disabled(struct mlx4_dev *dev, u8 port, bool *vlan_offload_disabled);void mlx4_handle_eth_header_mcast_prio (struct mlx4_net_trans_rule_hw_ctrl *ctrl,struct _rule_hw *eth_header); -int mlx4_find_cached_mac (struct mlx4_dev *dev,u8 port,u64 mac,int *idx);int mlx4_find_cached_vlan (struct mlx4_dev *dev,u8 port,u16 vid,int *idx);int mlx4_register_vlan (struct mlx4_dev *dev,u8 port,u16 vlan,int *index);void mlx4_unregister_vlan (struct mlx4_dev *dev,u8 port,u16 vlan);
Signature · 1 line
2.48.1
Quoted 5 lines · On Thu, Jan 30, 2025 at 01:39:27AM +0000, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
The last use of
mlx4_find_cached_mac()was removed in 2014 by commit2f5bb473681b("mlx4: Add ref counting to port MAC table for RoCE")
Quoted 7 lines
mlx4_zone_free_entries()was added in 2014 by
commit7a89399ffad7("net/mlx4: Addmlx4_bitmapzone allocator") but hasn't been used. (The_uniqueversion is used)Remove them.
Signed-off-by Dr. David Alan Gilbert <[email protected]>