Skip to contentSkip to conversation

drm/i915/selftest: Fix spelling mistake "ofset" -> "offset"

PATCH In review Colin Ian King 3 participants 4 messages Feb 2, 2025 – Feb 3, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/selftest: Fix spelling mistake "ofset" -> "offset"

There is a spelling mistake in an error message. Fix it.

---
 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +1 -1
index 5c397a2df70e..3eff0894c26c 100644
@@ -964,7 +964,7 @@ static int __shrink_hole(struct i915_address_space *vm,
 			break;
 
 		if (igt_timeout(end_time,
-				"%s timed out at ofset %llx [%llx - %llx]\n",
+				"%s timed out at offset %llx [%llx - %llx]\n",
 				__func__, addr, hole_start, hole_end)) {
 			err = -EINTR;
 			break;
Signature · 1 line
2.47.2
#1 lore raw

✗ Fi.CI.SPARSE: warning for drm/i915/selftest: Fix spelling mistake "ofset" -> "offset"

== Series Details ==

== Series Details ==

Series: drm/i915/selftest: Fix spelling mistake "ofset" -> "offset"
URL : https://patchwork.freedesktop.org/series/144234/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2

#2 lore raw

✗ i915.CI.BAT: failure for drm/i915/selftest: Fix spelling mistake "ofset" -> "offset"

In reply to Colin Ian King
== Series Details ==

== Series Details ==

Series: drm/i915/selftest: Fix spelling mistake "ofset" -> "offset"
URL : https://patchwork.freedesktop.org/series/144234/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_16053 -> Patchwork_144234v1
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_144234v1 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_144234v1, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/index.html

Participating hosts (42 -> 40)
------------------------------

Additional (1): bat-adlp-6
Missing (3): bat-arlh-2 bat-jsl-1 fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_144234v1:

### IGT changes ###

#### Possible regressions ####

* igt@kms_flip@basic-flip-vs-dpms@c-dp2:
- fi-cfl-8109u: [PASS][1] -> [DMESG-WARN][2] +1 other test dmesg-warn
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/fi-cfl-8109u/igt@kms_flip@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/fi-cfl-8109u/igt@kms_flip@[email protected]

* igt@kms_pm_rpm@basic-pci-d3-state:
- bat-apl-1: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/bat-apl-1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-apl-1/igt@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_16053 and Patchwork_144234v1:

### New IGT tests (1) ###

* igt@i915_selftest@live@gt_tlb:
- Statuses : 36 pass(s)
- Exec time: [1.61, 11.86] s

Known issues
------------

Here are the changes found in Patchwork_144234v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@debugfs_test@basic-hwmon:
- bat-adlp-6: NOTRUN -> [SKIP][5] ([i915#9318])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-adlp-6/igt@[email protected]

* igt@dmabuf@all-tests:
- bat-apl-1: [PASS][6] -> [INCOMPLETE][7] ([i915#12904]) +1 other test incomplete
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/bat-apl-1/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-apl-1/igt@[email protected]

* igt@dmabuf@all-tests@dma_fence_chain:
- fi-bsw-nick: [PASS][8] -> [INCOMPLETE][9] ([i915#12904]) +1 other test incomplete
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/fi-bsw-nick/igt@dmabuf@all-tests@dma_fence_chain.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/fi-bsw-nick/igt@dmabuf@all-tests@dma_fence_chain.html

* igt@gem_lmem_swapping@random-engines:
- bat-adlp-6: NOTRUN -> [SKIP][10] ([i915#4613]) +3 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-adlp-6/igt@[email protected]

* igt@gem_tiled_pread_basic:
- bat-adlp-6: NOTRUN -> [SKIP][11] ([i915#3282])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-adlp-6/igt@gem_tiled_pread_basic.html

* igt@i915_module_load@load:
- fi-pnv-d510: [PASS][12] -> [ABORT][13] ([i915#13203])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/fi-pnv-d510/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/fi-pnv-d510/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- bat-rpls-4: [PASS][14] -> [FAIL][15] ([i915#13401])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/bat-rpls-4/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-rpls-4/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- bat-adlp-6: NOTRUN -> [SKIP][16] ([i915#6621])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-adlp-6/igt@[email protected]

* igt@i915_selftest@live:
- bat-apl-1: [PASS][17] -> [DMESG-FAIL][18] ([i915#12435]) +1 other test dmesg-fail
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/bat-apl-1/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-apl-1/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-6: NOTRUN -> [SKIP][19] ([i915#4103]) +1 other test skip
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-adlp-6/igt@[email protected]

* igt@kms_dsc@dsc-basic:
- bat-adlp-6: NOTRUN -> [SKIP][20] ([i915#3555] / [i915#3840])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-adlp-6/igt@[email protected]

* igt@kms_flip@basic-flip-vs-dpms:
- fi-cfl-8109u: [PASS][21] -> [DMESG-WARN][22] ([i915#13445])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/fi-cfl-8109u/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/fi-cfl-8109u/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- bat-adlp-6: NOTRUN -> [SKIP][23]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-adlp-6/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: [PASS][24] -> [SKIP][25] ([i915#9197]) +3 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/bat-dg2-11/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-dg2-11/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- bat-adlp-6: NOTRUN -> [SKIP][26] ([i915#3555])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-adlp-6/igt@[email protected]

* igt@prime_vgem@basic-write:
- bat-adlp-6: NOTRUN -> [SKIP][27] ([i915#3291] / [i915#3708]) +2 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-adlp-6/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live:
- bat-twl-1: [ABORT][28] ([i915#12919] / [i915#13503]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/bat-twl-1/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-twl-1/igt@[email protected]

* igt@i915_selftest@live@requests:
- bat-twl-1: [ABORT][30] ([i915#12919]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/bat-twl-1/igt@i915_selftest@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-twl-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-arls-5: [DMESG-FAIL][32] ([i915#12061]) -> [PASS][33] +1 other test pass
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/bat-arls-5/igt@i915_selftest@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-arls-5/igt@i915_selftest@[email protected]
- bat-mtlp-6: [DMESG-FAIL][34] ([i915#12061]) -> [PASS][35] +1 other test pass
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/bat-mtlp-6/igt@i915_selftest@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-mtlp-6/igt@i915_selftest@[email protected]
- {bat-mtlp-9}: [DMESG-FAIL][36] ([i915#12061]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16053/bat-mtlp-9/igt@i915_selftest@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/bat-mtlp-9/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12435]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12435
[i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
[i915#12919]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919
[i915#13203]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13203
[i915#13401]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13401
[i915#13445]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13445
[i915#13503]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13503
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
[i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
[i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318

Build changes
-------------

* Linux: CI_DRM_16053 -> Patchwork_144234v1

CI-20190529: 20190529
CI_DRM_16053: 01f54d1da1ffffff78047186f62b5916dfd43939 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8219: d92c8eadff2a4e5b4d90cf8c8c52936263d29394 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_144234v1: 01f54d1da1ffffff78047186f62b5916dfd43939 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144234v1/index.html

maintainer
#3 lore raw
In reply to Colin Ian King
Quoted 12 lines · Colin Ian King

There is a spelling mistake in an error message. Fix it.

---
 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +0 -0
index 5c397a2df70e..3eff0894c26c 100644

drivers/gpu/drm/i915/selftests/i915_gem_gtt.c static int __shrink_hole(struct i915_address_space *vm, · line 967

Quoted 5 lines
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +1 -1
@@ -964,7 +964,7 @@ static int __shrink_hole(struct i915_address_space *vm,
 			break;
 
 		if (igt_timeout(end_time,
-				"%s timed out at ofset %llx [%llx - %llx]\n",
+				"%s timed out at offset %llx [%llx - %llx]\n",

Thanks for your patch, but this has already been fixed
by accc7f5bf230 ("drm/i915/selftests: fix typos in i915/selftests files") which is already merged to drm-intel-next.

Quoted 6 lines
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +0 -0
 				__func__, addr, hole_start, hole_end)) {
 			err = -EINTR;
 			break;
Signature · 1 line
2.47.2