Skip to contentSkip to conversation

dt-bindings: mtd: physmap: Ensure all properties are defined

PATCH Applied Rob Herring (Arm) 3 participants 3 messages Feb 3, 2025 – Feb 7, 2025

Subsystems (3)
Device tree bindings Memory technology devices (MTD) Arm integrator, versatile and realview support
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: mtd: physmap: Ensure all properties are defined

Device specific schemas should not allow undefined properties which is what 'additionalProperties: true' allows. Add the missing 'ranges' property, and fix this constraint.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 Documentation/devicetree/bindings/mtd/mtd-physmap.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mtd/mtd-physmap.yaml +3 -2
index 18f6733408b4..1b375dee83b0 100644
@@ -122,6 +122,8 @@ properties:
   '#size-cells':
     const: 1
 
+  ranges: true
+
   big-endian: true
   little-endian: true
 

@@ -143,8 +145,7 @@ then:
   required:
     - syscon
 
-# FIXME: A parent bus may define timing properties
-additionalProperties: true
+unevaluatedProperties: false
 
 examples:
   - |
Signature · 1 line
2.47.2
Acked-by on v1 1/1
#1 lore raw
Quoted 23 lines · Rob Herring (Arm)

Device specific schemas should not allow undefined properties which is what 'additionalProperties: true' allows. Add the missing 'ranges' property, and fix this constraint.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 Documentation/devicetree/bindings/mtd/mtd-physmap.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mtd/mtd-physmap.yaml +2 -0
index 18f6733408b4..1b375dee83b0 100644
@@ -122,6 +122,8 @@ properties:
   '#size-cells':
     const: 1
 
+  ranges: true
+
   big-endian: true
   little-endian: true

Documentation/devicetree/bindings/mtd/mtd-physmap.yaml then: · line 148

Quoted 6 lines
Documentation/devicetree/bindings/mtd/mtd-physmap.yaml +1 -2
@@ -143,8 +145,7 @@ then:
   required:
     - syscon
 
-# FIXME: A parent bus may define timing properties
-additionalProperties: true
+unevaluatedProperties: false

I dunno what that comment has to do with anything? If a parent bus defined properties, wouldn't they be in the parent bus?

Acked-by Conor Dooley <[email protected]>
maintainer Applied
#2 lore raw
In reply to Rob Herring (Arm)
Quoted 5 lines · Rob Herring (Arm)

Device specific schemas should not allow undefined properties which is what 'additionalProperties: true' allows. Add the missing 'ranges' property, and fix this constraint.

Applied to mtd/next, thanks!

[1/1] dt-bindings: mtd: physmap: Ensure all properties are defined

      commit: 038e2ba01cf5ff94dc8f740328ec565d18bb764e

Patche(s) should be available on mtd/linux.git and will be part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl