Skip to contentSkip to conversation

drivers/infiniband/hw/bnxt_re/debugfs.h:34:40: error: variably modified 'gen0_parms' at file scope

PATCH kernel test robot 3 participants 4 messages Feb 4, 2025

lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git rdma-next
head:   10565c5cadcb629f7780d24dd351878de9f46db5
commit: a3c71713d9548f1a9ee141c7cfb35550c3487443 [17/75] RDMA/bnxt_re: Congestion control settings using debugfs hook
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20250204/[email protected]/config)
compiler: s390-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250204/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

In file included from drivers/infiniband/hw/bnxt_re/main.c:70:

>> drivers/infiniband/hw/bnxt_re/debugfs.h:34:40: error: variably modified 'gen0_parms' at file scope
      34 |         struct bnxt_re_cc_param        gen0_parms[BNXT_RE_CC_PARAM_GEN0];
         |                                        ^~~~~~~~~~

vim +/gen0_parms +34 drivers/infiniband/hw/bnxt_re/debugfs.h

    32	
    33	struct bnxt_re_dbg_cc_config_params {
  > 34		struct bnxt_re_cc_param        gen0_parms[BNXT_RE_CC_PARAM_GEN0];
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#1 lore raw
Quoted 13 lines · kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git rdma-next
head:   10565c5cadcb629f7780d24dd351878de9f46db5
commit: a3c71713d9548f1a9ee141c7cfb35550c3487443 [17/75] RDMA/bnxt_re: Congestion control settings using debugfs hook
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20250204/[email protected]/config)
compiler: s390-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250204/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Quoted 8 lines

All errors (new ones prefixed by >>):

In file included from drivers/infiniband/hw/bnxt_re/main.c:70:

Quoted 1 line
Quoted 1 line

drivers/infiniband/hw/bnxt_re/debugfs.h:34:40: error: variably modified 'gen0_parms' at file scope

      34 |         struct bnxt_re_cc_param        gen0_parms[BNXT_RE_CC_PARAM_GEN0];
         |                                        ^~~~~~~~~~

Leon,
I had a fix for it. Do you want to revert this check-in and want me
to post a v3 for this patch ? or shall i post a bug fix patch?

Thanks,
Selvin

Quoted 9 lines

vim +/gen0_parms +34 drivers/infiniband/hw/bnxt_re/debugfs.h

    32
    33  struct bnxt_re_dbg_cc_config_params {
Quoted 1 line

34 struct bnxt_re_cc_param gen0_parms[BNXT_RE_CC_PARAM_GEN0];

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

#2 lore raw
Quoted 17 lines · Selvin Xavier
Quoted 16 lines · kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git rdma-next
head:   10565c5cadcb629f7780d24dd351878de9f46db5
commit: a3c71713d9548f1a9ee141c7cfb35550c3487443 [17/75] RDMA/bnxt_re: Congestion control settings using debugfs hook
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20250204/[email protected]/config)
compiler: s390-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250204/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

In file included from drivers/infiniband/hw/bnxt_re/main.c:70:

Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line

drivers/infiniband/hw/bnxt_re/debugfs.h:34:40: error: variably modified 'gen0_parms' at file scope

      34 |         struct bnxt_re_cc_param        gen0_parms[BNXT_RE_CC_PARAM_GEN0];
         |                                        ^~~~~~~~~~

Leon,
I had a fix for it. Do you want to revert this check-in and want me
to post a v3 for this patch ? or shall i post a bug fix patch?

Is it small fix? If yes, just send me Fixup patch as debugfs patch is still in wip branch which we can change.

Thanks

Quoted 16 lines

Thanks,
Selvin

Quoted 9 lines

vim +/gen0_parms +34 drivers/infiniband/hw/bnxt_re/debugfs.h

    32
    33  struct bnxt_re_dbg_cc_config_params {
Quoted 1 line

34 struct bnxt_re_cc_param gen0_parms[BNXT_RE_CC_PARAM_GEN0];

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Attachments:
* smime.p7s

#3 lore raw
Quoted 26 lines · Leon Romanovsky
Quoted 22 lines · Selvin Xavier
Quoted 21 lines · kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git rdma-next
head:   10565c5cadcb629f7780d24dd351878de9f46db5
commit: a3c71713d9548f1a9ee141c7cfb35550c3487443 [17/75] RDMA/bnxt_re: Congestion control settings using debugfs hook
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20250204/[email protected]/config)
compiler: s390-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250204/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

In file included from drivers/infiniband/hw/bnxt_re/main.c:70:

Quoted 1 line
Quoted 1 line

drivers/infiniband/hw/bnxt_re/debugfs.h:34:40: error: variably modified 'gen0_parms' at file scope

      34 |         struct bnxt_re_cc_param        gen0_parms[BNXT_RE_CC_PARAM_GEN0];
         |                                        ^~~~~~~~~~
Quoted 5 lines
Quoted 3 lines

Leon,
I had a fix for it. Do you want to revert this check-in and want me
to post a v3 for this patch ? or shall i post a bug fix patch?

Is it small fix? If yes, just send me Fixup patch as debugfs patch is still in wip branch which we can change.

yes. i am hard coding the array size. Will send it to you now.

Quoted 19 lines

Thanks

Quoted 16 lines

Thanks,
Selvin

Quoted 9 lines

vim +/gen0_parms +34 drivers/infiniband/hw/bnxt_re/debugfs.h

    32
    33  struct bnxt_re_dbg_cc_config_params {
Quoted 1 line

34 struct bnxt_re_cc_param gen0_parms[BNXT_RE_CC_PARAM_GEN0];

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Attachments:
* smime.p7s