Skip to contentSkip to conversation

package/swipl: fix build without C++ compiler

PATCH Applied Peter Korsgaard 2 participants 3 messages Feb 5, 2025 – Feb 8, 2025

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/swipl: fix build without C++ compiler

Fixes http://autobuild.buildroot.net/results/b24a96b999676990995a466686fe1eacf6cddfef

Some of the optional packages in swipl are written in C++, so CMake thinks a C++ compiler is needed even though we build with -DSWIPL_PACKAGES=OFF since the bump to 9.2.6 in commit 33d45b9c672df0 ("package/swipl: bump version to 9.2.6").

Add -DCMAKE_CXX_COMPILER=true to satisfy this check even in setups without C++:

-- Check for working CXX compiler: /usr/bin/true -- Check for working CXX compiler: /usr/bin/true - works

---
Changes since v1:
- Add info about since when the issue occurs.

 package/swipl/swipl.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/swipl/swipl.mk +2 -1
index ef9aedcd2d..e29b8d8f46 100644
@@ -36,7 +36,8 @@ SWIPL_CONF_OPTS = \
 	-DQSORT_R_GNU=1 \
 	-DSWIPL_NATIVE_FRIEND=$(HOST_SWIPL_SRCDIR) \
 	-DSWIPL_PACKAGES=OFF \
-	-DUSE_TCMALLOC=OFF
+	-DUSE_TCMALLOC=OFF \
+	-DCMAKE_CXX_COMPILER=true
 
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
 SWIPL_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
Signature · 6 lines
2.39.5

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 10 lines · On Wed, 5 Feb 2025 13:00:58 +0100 Peter Korsgaard <[email protected]> wrote:

Fixes http://autobuild.buildroot.net/results/b24a96b999676990995a466686fe1eacf6cddfef

Some of the optional packages in swipl are written in C++, so CMake thinks a C++ compiler is needed even though we build with -DSWIPL_PACKAGES=OFF since the bump to 9.2.6 in commit 33d45b9c672df0 ("package/swipl: bump version to 9.2.6").

Add -DCMAKE_CXX_COMPILER=true to satisfy this check even in setups without C++:

Quoted 7 lines

-- Check for working CXX compiler: /usr/bin/true -- Check for working CXX compiler: /usr/bin/true - works

---
Changes since v1:
- Add info about since when the issue occurs.

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Peter Korsgaard
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Fixes http://autobuild.buildroot.net/results/b24a96b999676990995a466686fe1eacf6cddfef
Some of the optional packages in swipl are written in C++, so CMake thinks a C++ compiler is needed even though we build with -DSWIPL_PACKAGES=OFF since the bump to 9.2.6 in commit 33d45b9c672df0 ("package/swipl: bump version to 9.2.6").

Add -DCMAKE_CXX_COMPILER=true to satisfy this check even in setups without C++:

Quoted 7 lines

-- Check for working CXX compiler: /usr/bin/true -- Check for working CXX compiler: /usr/bin/true - works

---
Changes since v1:
- Add info about since when the issue occurs.

Committed to 2024.11.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot