mm/mm_init.c: use round_up() to align movable range
PATCH 1/1 mm/mm_init.c: use round_up() to align movable range
Since MAX_ORDER_NR_PAGES is power of 2, let's use a faster version.
--- mm/mm_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/mm_init.c +2 -2
@@ -438,7 +438,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)* was requested by the user */ required_movablecore = -roundup (required_movablecore,MAX_ORDER_NR_PAGES ); +round_up (required_movablecore,MAX_ORDER_NR_PAGES ); required_movablecore =min (totalpages, required_movablecore); corepages = totalpages - required_movablecore;
@@ -549,7 +549,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)unsigned long start_pfn, end_pfn; zone_movable_pfn[nid] = -roundup (zone_movable_pfn[nid],MAX_ORDER_NR_PAGES ); +round_up (zone_movable_pfn[nid],MAX_ORDER_NR_PAGES );get_pfn_range_for_nid (nid, &start_pfn, &end_pfn);if (zone_movable_pfn[nid] >= end_pfn)
Signature · 1 line
2.34.1
Quoted 1 line · Wei Yang
Since
MAX_ORDER_NR_PAGESis power of 2, let's use a faster version.
Makes sense to me.
I noticed two similar instances in the same file
where round_up() might also be applicable:
mm_init.c (usemap_size):
usemapsize = roundup(zonesize, pageblock_nr_pages);
usemapsize = roundup(usemapsize, BITS_PER_LONG);Since both pageblock_nr_pages (1UL << pageblock_order) and BITS_PER_LONG (32 or 64) are powers of 2, these could potentially use round_up() as well. Perhaps worth considering in a follow-up patch?
Thanks,
Shivank
Quoted 28 lines
Signed-off-by Wei Yang <[email protected]>--- mm/mm_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)mm/mm_init.c +2
-2@@ -438,7 +438,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)* was requested by the user */ required_movablecore = -roundup (required_movablecore,MAX_ORDER_NR_PAGES ); +round_up (required_movablecore,MAX_ORDER_NR_PAGES ); required_movablecore =min (totalpages, required_movablecore); corepages = totalpages - required_movablecore;@@ -549,7 +549,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)unsigned long start_pfn, end_pfn; zone_movable_pfn[nid] = -roundup (zone_movable_pfn[nid],MAX_ORDER_NR_PAGES ); +round_up (zone_movable_pfn[nid],MAX_ORDER_NR_PAGES );get_pfn_range_for_nid (nid, &start_pfn, &end_pfn);if (zone_movable_pfn[nid] >= end_pfn)
Quoted 9 lines · Shivank Garg
Quoted 1 line · Wei Yang
Since
MAX_ORDER_NR_PAGESis power of 2, let's use a faster version.Makes sense to me.
Reviewed-by Shivank Garg <[email protected]>
Thanks for taking a look.
Quoted 11 lines
I noticed two similar instances in the same file
whereround_up()might also be applicable:
mm_init.c(usemap_size):usemapsize = roundup(zonesize, pageblock_nr_pages); usemapsize = roundup(usemapsize, BITS_PER_LONG);Since both
pageblock_nr_pages(1UL <<pageblock_order) andBITS_PER_LONG(32 or 64) are powers of 2, these could potentially useround_up()as well. Perhaps worth considering in a follow-up patch?
It looks reasonable to me. I would prepare one.
Thanks.
Quoted 34 lines
Thanks,
ShivankQuoted 28 lines
Signed-off-by Wei Yang <[email protected]>--- mm/mm_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)mm/mm_init.c +2
-2@@ -438,7 +438,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)* was requested by the user */ required_movablecore = -roundup (required_movablecore,MAX_ORDER_NR_PAGES ); +round_up (required_movablecore,MAX_ORDER_NR_PAGES ); required_movablecore =min (totalpages, required_movablecore); corepages = totalpages - required_movablecore;@@ -549,7 +549,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)unsigned long start_pfn, end_pfn; zone_movable_pfn[nid] = -roundup (zone_movable_pfn[nid],MAX_ORDER_NR_PAGES ); +round_up (zone_movable_pfn[nid],MAX_ORDER_NR_PAGES );get_pfn_range_for_nid (nid, &start_pfn, &end_pfn);if (zone_movable_pfn[nid] >= end_pfn)
Signature · 2 lines
Wei Yang Help you, Help me
Quoted 3 lines · Wei Yang
Since
MAX_ORDER_NR_PAGESis power of 2, let's use a faster version.Signed-off-by Wei Yang <[email protected]>
Quoted 29 lines
--- mm/mm_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)mm/mm_init.c +2
-2@@ -438,7 +438,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)* was requested by the user */ required_movablecore = -roundup (required_movablecore,MAX_ORDER_NR_PAGES ); +round_up (required_movablecore,MAX_ORDER_NR_PAGES ); required_movablecore =min (totalpages, required_movablecore); corepages = totalpages - required_movablecore;@@ -549,7 +549,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)unsigned long start_pfn, end_pfn; zone_movable_pfn[nid] = -roundup (zone_movable_pfn[nid],MAX_ORDER_NR_PAGES ); +round_up (zone_movable_pfn[nid],MAX_ORDER_NR_PAGES );get_pfn_range_for_nid (nid, &start_pfn, &end_pfn);if (zone_movable_pfn[nid] >= end_pfn)Signature · 1 line
2.34.1
Signature · 2 lines
Sincerely yours, Mike.
Quoted 21 lines · Wei Yang
Since
MAX_ORDER_NR_PAGESis power of 2, let's use a faster version.Signed-off-by Wei Yang <[email protected]>--- mm/mm_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)mm/mm_init.c +1
-1@@ -438,7 +438,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)* was requested by the user */ required_movablecore = -roundup (required_movablecore,MAX_ORDER_NR_PAGES ); +round_up (required_movablecore,MAX_ORDER_NR_PAGES ); required_movablecore =min (totalpages, required_movablecore); corepages = totalpages - required_movablecore;
mm/mm_init.c static void __init find_zone_movable_pfns_for_nodes(void) · line 555
Quoted 8 lines
mm/mm_init.c +1
-1@@ -549,7 +549,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)unsigned long start_pfn, end_pfn; zone_movable_pfn[nid] = -roundup (zone_movable_pfn[nid],MAX_ORDER_NR_PAGES ); +round_up (zone_movable_pfn[nid],MAX_ORDER_NR_PAGES );get_pfn_range_for_nid (nid, &start_pfn, &end_pfn);if (zone_movable_pfn[nid] >= end_pfn)