crypto/mlx5: log when num of segs exceed max segs
PATCH 1/1 crypto/mlx5: log when num of segs exceed max segs
From: Shani Peretz <[email protected]>
This patch logs and aborts when mbuf segment count exceeding max_segs_num. The log message suggests the user to either increase the segment size or set a higher value for the max_segs_num devarg.
--- drivers/crypto/mlx5/mlx5_crypto_gcm.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/crypto/mlx5/mlx5_crypto_gcm.c +9 -1
@@ -554,7 +554,15 @@ mlx5_crypto_gcm_build_mbuf_chain_klms(struct mlx5_crypto_qp *qp,uint32_t klm_n =0 ;/* mbuf seg num should be less than max_segs_num. */ -MLX5_ASSERT (nb_segs <= qp->priv->max_segs_num); +if (nb_segs > qp->priv->max_segs_num) { +DRV_LOG (WARNING ,"Segment count exceeds limit. " +"Current segments: %d, Maximum allowed: %d. " +"To resolve, either increase the segment size " +"or set a higher value for the devargs max_segs_num parameter." , + nb_segs, qp->priv->max_segs_num); +RTE_VERIFY (nb_segs <= qp->priv->max_segs_num); +return 0 ; + }/* First mbuf needs to take the data offset. */ if (unlikely (_mlx5_crypto_gcm_umr_build_mbuf_klm (qp, mbuf, klm, op->sym->aead.data.offset, &remain_len) ==UINT32_MAX )) {
Signature · 1 line
2.45.2
drivers/crypto/mlx5/mlx5_crypto_gcm.c mlx5_crypto_gcm_build_mbuf_chain_klms(struct mlx5_crypto_qp *qp, · line 565
Quoted 10 lines · On Sun, 9 Feb 2025 14:08:51 +0200 Gregory Etelson <[email protected]> wrote:
drivers/crypto/mlx5/mlx5_crypto_gcm.c +9
-1-MLX5_ASSERT (nb_segs <= qp->priv->max_segs_num); +if (nb_segs > qp->priv->max_segs_num) { +DRV_LOG (WARNING ,"Segment count exceeds limit. " +"Current segments: %d, Maximum allowed: %d. " +"To resolve, either increase the segment size " +"or set a higher value for the devargs max_segs_num parameter." , + nb_segs, qp->priv->max_segs_num); +RTE_VERIFY (nb_segs <= qp->priv->max_segs_num); +return 0 ; + }
Way to verbose.RTE_VERIFY never returns since it calls rte_panic().
Would it be better to just use RTE_VERIFY()?
Maybe MLX5 should have MLX5_ASSERT() and MLX5_VERIFY() macro.
Je n’ai fait celle-ci plus longue que parce que je n’ai pas eu le loisir de la faire plus courte. I have made this longer than usual because I have not had time to make it shorter.