Skip to contentSkip to conversation

dmaengine: Remove device_prep_dma_imm_data from struct dma_device

PATCH Applied Nathan Lynch 2 participants 2 messages Feb 10, 2025 – Mar 10, 2025 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: Remove device_prep_dma_imm_data from struct dma_device

The device_prep_dma_imm_data() method isn't implemented or invoked by any code since commit 80ade22c06ca ("misc: mic: remove the MIC drivers").

Remove it, shrinking struct dma_device by a few bytes.

---
 include/linux/dmaengine.h | 4 ----
 1 file changed, 4 deletions(-)
include/linux/dmaengine.h +0 -4
index a360e0330436470bfea17f8df567ff785e4293ea..bb146c5ac3e4ccd7bc0afbf3b28e5b3d659ad62f 100644
@@ -839,7 +839,6 @@ struct dma_filter {
  *	The function takes a buffer of size buf_len. The callback function will
  *	be called after period_len bytes have been transferred.
  * @device_prep_interleaved_dma: Transfer expression in a generic way.
- * @device_prep_dma_imm_data: DMA's 8 byte immediate data to the dst address
  * @device_caps: May be used to override the generic DMA slave capabilities
  *	with per-channel specific ones
  * @device_config: Pushes a new configuration to a channel, return 0 or an error
@@ -942,9 +941,6 @@ struct dma_device {
 	struct dma_async_tx_descriptor *(*device_prep_interleaved_dma)(
 		struct dma_chan *chan, struct dma_interleaved_template *xt,
 		unsigned long flags);
-	struct dma_async_tx_descriptor *(*device_prep_dma_imm_data)(
-		struct dma_chan *chan, dma_addr_t dst, u64 data,
-		unsigned long flags);
 
 	void (*device_caps)(struct dma_chan *chan, struct dma_slave_caps *caps);
 	int (*device_config)(struct dma_chan *chan, struct dma_slave_config *config);

---
base-commit: 2c17e9ea0caa5555e31e154fa1b06260b816f5cc
change-id: 20250210-dmaengine-drop-imm-data-f7a8e749fcef

Best regards,

Signature · 1 line
Nathan Lynch <[email protected]>
maintainer Applied
#1 lore raw
Quoted 6 lines · Nathan Lynch

The device_prep_dma_imm_data() method isn't implemented or invoked by any code since commit 80ade22c06ca ("misc: mic: remove the MIC drivers").

Remove it, shrinking struct dma_device by a few bytes.

Applied, thanks!

[1/1] dmaengine: Remove device_prep_dma_imm_data from struct dma_device

      commit: b9014a10bdb8e967d85819f5ef61e6f80d0b46c9

Best regards,

Signature · 1 line
~Vinod