Skip to contentSkip to conversation

mm/vmstat: Revert "fix a W=1 clang compiler warning"

PATCH Applied Bart Van Assche 2 participants 2 messages Feb 11, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/vmstat: Revert "fix a W=1 clang compiler warning"

Commit 75b5ab134bb5 enabled -Wenum-enum-conversion in W=1 builds. Commit 30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning") fixed a -Wenum-enum-conversion warning. Commit 8f6629c004b1 removed the -Wenum-enum-conversion option again from W=1 builds. Since the W=1 compiler warning fix is no longer necessary, revert it.

Cc Vlastimil Babka <[email protected]>
Cc Matthew Wilcox <[email protected]>
CC Andrew Morton <[email protected]>
Cc Ivan Shapovalov <[email protected]>
Cc David Laight <[email protected]>
Cc Nathan Chancellor <[email protected]>
---
 include/linux/vmstat.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/vmstat.h +1 -1
index 9f3a04345b86..d2761bf8ff32 100644
@@ -515,7 +515,7 @@ static inline const char *node_stat_name(enum node_stat_item item)
 
 static inline const char *lru_list_name(enum lru_list lru)
 {
-	return node_stat_name(NR_LRU_BASE + (enum node_stat_item)lru) + 3; // skip "nr_"
+	return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
 }
 
 #if defined(CONFIG_VM_EVENT_COUNTERS) || defined(CONFIG_MEMCG)
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Bart Van Assche

Commit 75b5ab134bb5 enabled -Wenum-enum-conversion in W=1 builds. Commit 30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning") fixed a -Wenum-enum-conversion warning.

We could expand? ... warning related to enum node_stat_item, but not all of them.

Quoted 3 lines

Commit 8f6629c004b1 removed the
-Wenum-enum-conversion option again from W=1 builds. Since the W=1 compiler warning fix is no longer necessary, revert it.

no longer necessary and incomplete anyway,

Quoted 8 lines
Cc Vlastimil Babka <[email protected]>
Cc Matthew Wilcox <[email protected]>
CC Andrew Morton <[email protected]>
Cc Ivan Shapovalov <[email protected]>
Cc David Laight <[email protected]>
Cc Nathan Chancellor <[email protected]>

Thanks!

Quoted 17 lines
---
 include/linux/vmstat.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/vmstat.h +1 -1
index 9f3a04345b86..d2761bf8ff32 100644
@@ -515,7 +515,7 @@ static inline const char *node_stat_name(enum node_stat_item item)
 
 static inline const char *lru_list_name(enum lru_list lru)
 {
-	return node_stat_name(NR_LRU_BASE + (enum node_stat_item)lru) + 3; // skip "nr_"
+	return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
 }
 
 #if defined(CONFIG_VM_EVENT_COUNTERS) || defined(CONFIG_MEMCG)