gpiolib: read descriptor flags once in gpiolib_dbg_show()
PATCH 1/1 gpiolib: read descriptor flags once in gpiolib_dbg_show()
From: Bartosz Golaszewski <[email protected]>
For consistency with most other code that can access requested
descriptors: read the flags once atomically and then test individual bits from the helper variable. This avoids any potential discrepancies should flags change during the debug print.
Signed-off-by Bartosz Golaszewski <[email protected]>
--- drivers/gpio/gpiolib.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/gpio/gpiolib.c +6 -4
@@ -5003,6 +5003,7 @@ static void gpiolib_dbg_show(struct seq_file *s, struct gpio_device *gdev)unsigned int gpio = gdev->base;struct gpio_desc *desc;struct gpio_chip *gc; +unsigned long flags;int value;guard (srcu)(&gdev->srcu);
@@ -5015,12 +5016,13 @@ static void gpiolib_dbg_show(struct seq_file *s, struct gpio_device *gdev)for_each_gpio_desc (gc, desc) {guard (srcu)(&desc->gdev->desc_srcu); - is_irq =test_bit (FLAG_USED_AS_IRQ , &desc->flags); -if (is_irq ||test_bit (FLAG_REQUESTED , &desc->flags)) { + flags =READ_ONCE (desc->flags); + is_irq =test_bit (FLAG_USED_AS_IRQ , &flags); +if (is_irq ||test_bit (FLAG_REQUESTED , &flags)) {gpiod_get_direction (desc); - is_out =test_bit (FLAG_IS_OUT , &desc->flags); + is_out =test_bit (FLAG_IS_OUT , &flags); value =gpio_chip_get_value (gc, desc); - active_low =test_bit (FLAG_ACTIVE_LOW , &desc->flags); + active_low =test_bit (FLAG_ACTIVE_LOW , &flags); seq_printf(s, " gpio-%-3u (%-20.20s|%-20.20s) %s %s %s%s\n", gpio, desc->name ?: "", gpiod_get_label(desc), is_out ? "out" : "in ",
Signature · 1 line
2.45.2
Bartosz Golaszewski
AppliedFrom: Bartosz Golaszewski <[email protected]>
Quoted 6 lines · Bartosz Golaszewski
For consistency with most other code that can access requested
descriptors: read the flags once atomically and then test individual bits from the helper variable. This avoids any potential discrepancies should flags change during the debug print.
Applied, thanks!
[1/1] gpiolib: read descriptor flags once in gpiolib_dbg_show()
commit: 11067f50458a5bb3b72f83c508e03f321e0c0c34
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>