Skip to contentSkip to conversation

crypto: bpf - Add MODULE_DESCRIPTION for skcipher

PATCH In review Arnd Bergmann 3 participants 3 messages Feb 17, 2025 – Mar 2, 2025

Subsystems (2)
BPF Crypto API
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 crypto: bpf - Add MODULE_DESCRIPTION for skcipher

From: Arnd Bergmann <[email protected]>

All modules should have a description, building with extra warnings enabled prints this outfor the for bpf_crypto_skcipher module:

WARNING: modpost: missing MODULE_DESCRIPTION() in crypto/bpf_crypto_skcipher.o

Add a description line.

Fixes fda4f71282b2 ("bpf: crypto: add skcipher to bpf crypto")
Signed-off-by Arnd Bergmann <[email protected]>
---
 crypto/bpf_crypto_skcipher.c | 1 +
 1 file changed, 1 insertion(+)
crypto/bpf_crypto_skcipher.c +1 -0
index b5e657415770..a88798d3e8c8 100644
@@ -80,3 +80,4 @@ static void __exit bpf_crypto_skcipher_exit(void)
 module_init(bpf_crypto_skcipher_init);
 module_exit(bpf_crypto_skcipher_exit);
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Symmetric key cipher support for BPF");
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

All modules should have a description, building with extra warnings enabled prints this outfor the for bpf_crypto_skcipher module:

WARNING: modpost: missing MODULE_DESCRIPTION() in crypto/bpf_crypto_skcipher.o

Add a description line.

Fixes fda4f71282b2 ("bpf: crypto: add skcipher to bpf crypto")
Signed-off-by Arnd Bergmann <[email protected]>
---
  crypto/bpf_crypto_skcipher.c | 1 +
  1 file changed, 1 insertion(+)
crypto/bpf_crypto_skcipher.c +0 -0
index b5e657415770..a88798d3e8c8 100644

crypto/bpf_crypto_skcipher.c static void __exit bpf_crypto_skcipher_exit(void) · line 83

Quoted 4 lines
crypto/bpf_crypto_skcipher.c +1 -0
@@ -80,3 +80,4 @@ static void __exit bpf_crypto_skcipher_exit(void)
  module_init(bpf_crypto_skcipher_init);
  module_exit(bpf_crypto_skcipher_exit);
  MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Symmetric key cipher support for BPF");

Thanks for fixing!

Reviewed-by Vadim Fedorenko <[email protected]>
maintainer
#2 lore raw
In reply to Arnd Bergmann
Quoted 7 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

All modules should have a description, building with extra warnings enabled prints this outfor the for bpf_crypto_skcipher module:

WARNING: modpost: missing MODULE_DESCRIPTION() in crypto/bpf_crypto_skcipher.o

Quoted 7 lines

Add a description line.

Fixes fda4f71282b2 ("bpf: crypto: add skcipher to bpf crypto")
Signed-off-by Arnd Bergmann <[email protected]>
---
 crypto/bpf_crypto_skcipher.c | 1 +
 1 file changed, 1 insertion(+)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt