Revert "fsverity: relax build time dependency on CRYPTO_SHA256"
Eric Biggers
maintainerPATCH 1/1 Revert "fsverity: relax build time dependency on CRYPTO_SHA256"
From: Eric Biggers <[email protected]>
This reverts commit e3a606f2c544b231f6079c8c5fea451e772e1139 because it allows people to create broken configurations that enable FS_VERITY but not SHA-256 support.
The commit did allow people to disable the generic SHA-256 implementation when it's not needed. But that at best allowed saving a bit of code. In the real world people are unlikely to intentionally and correctly make such a tweak anyway, as they tend to just be confused by what all the different crypto kconfig options mean.
Of course we really need the crypto API to enable the correct implementations automatically, but that's for a later fix.
--- fs/verity/Kconfig | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
fs/verity/Kconfig +2 -6
@@ -2,17 +2,13 @@ config FS_VERITY bool "FS Verity (read-only file-based authenticity protection)" select CRYPTO select CRYPTO_HASH_INFO - # SHA-256 is implied as it's intended to be the default hash algorithm. + # SHA-256 is selected as it's intended to be the default hash algorithm. # To avoid bloat, other wanted algorithms must be selected explicitly. - # Note that CRYPTO_SHA256 denotes the generic C implementation, but - # some architectures provided optimized implementations of the same - # algorithm that may be used instead. In this case, CRYPTO_SHA256 may - # be omitted even if SHA-256 is being used. - imply CRYPTO_SHA256 + select CRYPTO_SHA256 help This option enables fs-verity. fs-verity is the dm-verity mechanism implemented at the file level. On supported filesystems (currently ext4, f2fs, and btrfs), userspace can use an ioctl to enable verity for a file, which causes the
base-commit: 0ad2507d5d93f39619fc42372c347d6006b64319
Signature · 1 line
2.48.1
Quoted 16 lines · Eric Biggers
From: Eric Biggers <[email protected]>
This reverts commit
e3a606f2c544b231f6079c8c5fea451e772e1139because it allows people to create broken configurations that enableFS_VERITYbut not SHA-256 support.The commit did allow people to disable the generic SHA-256 implementation when it's not needed. But that at best allowed saving a bit of code. In the real world people are unlikely to intentionally and correctly make such a tweak anyway, as they tend to just be confused by what all the different crypto kconfig options mean.
Of course we really need the crypto API to enable the correct implementations automatically, but that's for a later fix.
Quoted 7 lines
Cc Ard Biesheuvel <[email protected]>Cc Herbert Xu <[email protected]>Signed-off-by Eric Biggers <[email protected]>--- fs/verity/Kconfig | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
Quoted 29 lines
fs/verity/Kconfig +2
-6@@ -2,17 +2,13 @@ config FS_VERITY bool "FS Verity (read-only file-based authenticity protection)" select CRYPTO select CRYPTO_HASH_INFO - # SHA-256 is implied as it's intended to be the default hash algorithm. + # SHA-256 is selected as it's intended to be the default hash algorithm. # To avoid bloat, other wanted algorithms must be selected explicitly. - # Note that CRYPTO_SHA256 denotes the generic C implementation, but - # some architectures provided optimized implementations of the same - # algorithm that may be used instead. In this case, CRYPTO_SHA256 may - # be omitted even if SHA-256 is being used. - imply CRYPTO_SHA256 + select CRYPTO_SHA256 help This option enables fs-verity. fs-verity is the dm-verity mechanism implemented at the file level. On supported filesystems (currently ext4, f2fs, and btrfs), userspace can use an ioctl to enable verity for a file, which causes thebase-commit:
0ad2507d5d93f39619fc42372c347d6006b64319--
2.48.1