usb: typec: ps883x: fix probe error handling
Subsystems (2)
PATCH 1/1 usb: typec: ps883x: fix probe error handling
Fix the probe error handling to avoid unbalanced clock disable or leaving regulators on after probe failure.
Note that the active-low reset pin should also be asserted to avoid leaking current after disabling the regulators.
Fixes 257a087c8b52 ("usb: typec: Add support for Parade PS8830 Type-C Retimer")
Cc Abel Vesa <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
--- drivers/usb/typec/mux/ps883x.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/usb/typec/mux/ps883x.c +3 -2
@@ -387,10 +387,11 @@ static int ps883x_retimer_probe(struct i2c_client *client) err_switch_unregister:typec_switch_unregister (retimer->sw); -err_vregs_disable: -ps883x_disable_vregs (retimer); err_clk_disable:clk_disable_unprepare (retimer->xo_clk); +err_vregs_disable: +gpiod_set_value (retimer->reset_gpio,1 ); +ps883x_disable_vregs (retimer); err_mux_put:typec_mux_put (retimer->typec_mux); err_switch_put:
Signature · 1 line
2.45.3
Quoted 9 lines · Johan Hovold
Fix the probe error handling to avoid unbalanced clock disable or leaving regulators on after probe failure.
Note that the active-low reset pin should also be asserted to avoid leaking current after disabling the regulators.
Fixes 257a087c8b52 ("usb: typec: Add support for Parade PS8830 Type-C Retimer")Cc Abel Vesa <[email protected]>Signed-off-by Johan Hovold <[email protected]>
Reviewed-by Heikki Krogerus <[email protected]>
Quoted 24 lines
--- drivers/usb/typec/mux/ps883x.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/usb/typec/mux/ps883x.c +3
-2@@ -387,10 +387,11 @@ static int ps883x_retimer_probe(struct i2c_client *client) err_switch_unregister:typec_switch_unregister (retimer->sw); -err_vregs_disable: -ps883x_disable_vregs (retimer); err_clk_disable:clk_disable_unprepare (retimer->xo_clk); +err_vregs_disable: +gpiod_set_value (retimer->reset_gpio,1 ); +ps883x_disable_vregs (retimer); err_mux_put:typec_mux_put (retimer->typec_mux); err_switch_put:Signature · 1 line
2.45.3
Signature · 1 line
heikki