Skip to contentSkip to conversation

package/kodi: Do not select BR2_PACKAGE_LIBDISPLAY_INFO unconditionally

PATCH In review Alexander Shiyan 2 participants 2 messages Feb 18, 2025 – Feb 23, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/kodi: Do not select BR2_PACKAGE_LIBDISPLAY_INFO unconditionally

BR2_PACKAGE_LIBDISPLAY_INFO is selected unconditionally when the symbol BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM is evaluated. Let's use it only if BR2_PACKAGE_KODI opyion is selected by the user.

---
 package/kodi/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/kodi/Config.in +1 -1
index 1977263db8..9661ab47bc 100644
@@ -27,7 +27,6 @@ config BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM
 	depends on BR2_PACKAGE_LIBGBM_HAS_FEATURE_DMA_BUF
 	depends on BR2_PACKAGE_HAS_UDEV # libinput
 	select BR2_PACKAGE_KODI_PLATFORM_SUPPORTS
-	select BR2_PACKAGE_LIBDISPLAY_INFO
 
 comment "kodi needs udev support for gbm"
 	depends on !BR2_PACKAGE_KODI_PLATFORM_SUPPORTS
@@ -108,6 +107,7 @@ menuconfig BR2_PACKAGE_KODI
 	select BR2_PACKAGE_TINYXML2
 	select BR2_PACKAGE_ZLIB
 	select BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY if BR2_TOOLCHAIN_USES_GLIBC # runtime UTF conversion support
+	select BR2_PACKAGE_LIBDISPLAY_INFO if BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM
 	select BR2_PACKAGE_LIBINPUT if BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM
 	select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM
 	select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_WAYLAND
Signature · 6 lines
2.39.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hi Alexander,

Thanks for the submission.

Quoted 5 lines · Alexander Shiyan

BR2_PACKAGE_LIBDISPLAY_INFO is selected unconditionally when the symbol BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM is evaluated. Let's use it only if BR2_PACKAGE_KODI opyion is selected by the user.

A similar patch has been merged in:
https://gitlab.com/buildroot.org/buildroot/-/commit/64b2f03f5a2e35b7ab873d6f7db64735a0567d59

I'll just mark this one as "Handled Elsewhere".

Best regards,

Julien.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot