Skip to contentSkip to conversation

Revert "leds-pca955x: Remove the unused function pca95xx_num_led_regs()"

PATCH Applied Eddie James 2 participants 2 messages Feb 21, 2025 LED

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "leds-pca955x: Remove the unused function pca95xx_num_led_regs()"

This reverts commit 38bcb51f81af17a6d40fc135e565fc1fb8aa8e9d. This function is needed by the hardware blink support just introduced. Also rename the function to pca955x_num_led_regs to match the rest of the functions in the driver.

---
Sorry for the build failure everyone. My series was pretty old so I didn't have that commit to remove the function. Simple rebase didn't conflict so I didn't notice. Will make sure to test build *after* rebasing next time.

 drivers/leds/leds-pca955x.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/leds/leds-pca955x.c +6 -0
index 156649e1e1c4f..e9cfde9fe4b13 100644
@@ -147,6 +147,12 @@ static inline int pca955x_num_input_regs(int bits)
 	return (bits + 7) / 8;
 }
 
+/* 4 bits per LED selector register */
+static inline int pca955x_num_led_regs(int bits)
+{
+	return (bits + 3)  / 4;
+}
+
 /*
  * Return an LED selector register value based on an existing one, with
  * the appropriate 2-bit state value set for the given LED number (0-3).
Signature · 1 line
2.43.5
maintainer Applied
#1 lore raw

Re: (subset) [PATCH] Revert "leds-pca955x: Remove the unused function pca95xx_num_led_regs()"

Quoted 6 lines · Eddie James

This reverts commit 38bcb51f81af17a6d40fc135e565fc1fb8aa8e9d. This function is needed by the hardware blink support just introduced. Also rename the function to pca955x_num_led_regs to match the rest of the functions in the driver.

Applied, thanks!

[1/1] Revert "leds-pca955x: Remove the unused function pca95xx_num_led_regs()"

      commit: 012825dbd5aa7454b93f7a17bd99efee114023ba

--
Lee Jones [李琼斯]