Skip to contentSkip to conversation

usb: olpi: Remove unused otg_ulpi_create

PATCH In review [email protected] 2 participants 3 messages Feb 23, 2025 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: olpi: Remove unused otg_ulpi_create

From: "Dr. David Alan Gilbert" <[email protected]>

otg_ulpi_create() has been unused since 2022's commit 8ca79aaad8be ("ARM: pxa: remove unused pxa3xx-ulpi")

Remove it.

The devm_ variant is still used.

---
 drivers/usb/phy/phy-ulpi.c | 23 -----------------------
 include/linux/usb/ulpi.h   |  9 ---------
 2 files changed, 32 deletions(-)
drivers/usb/phy/phy-ulpi.c +0 -23
index e683a37e3a7a..4df63e67bb37 100644
@@ -255,29 +255,6 @@ static void otg_ulpi_init(struct usb_phy *phy, struct usb_otg *otg,
 	otg->set_vbus	= ulpi_set_vbus;
 }
 
-struct usb_phy *
-otg_ulpi_create(struct usb_phy_io_ops *ops,
-		unsigned int flags)
-{
-	struct usb_phy *phy;
-	struct usb_otg *otg;
-
-	phy = kzalloc(sizeof(*phy), GFP_KERNEL);
-	if (!phy)
-		return NULL;
-
-	otg = kzalloc(sizeof(*otg), GFP_KERNEL);
-	if (!otg) {
-		kfree(phy);
-		return NULL;
-	}
-
-	otg_ulpi_init(phy, otg, ops, flags);
-
-	return phy;
-}
-EXPORT_SYMBOL_GPL(otg_ulpi_create);
-
 struct usb_phy *
 devm_otg_ulpi_create(struct device *dev,
 		     struct usb_phy_io_ops *ops,
include/linux/usb/ulpi.h +0 -9
index 5050f502c1ed..4b651065738a 100644
@@ -49,19 +49,10 @@
 /*-------------------------------------------------------------------------*/
 
 #if IS_ENABLED(CONFIG_USB_ULPI)
-struct usb_phy *otg_ulpi_create(struct usb_phy_io_ops *ops,
-					unsigned int flags);
-
 struct usb_phy *devm_otg_ulpi_create(struct device *dev,
 				     struct usb_phy_io_ops *ops,
 				     unsigned int flags);
 #else
-static inline struct usb_phy *otg_ulpi_create(struct usb_phy_io_ops *ops,
-					      unsigned int flags)
-{
-	return NULL;
-}
-
 static inline struct usb_phy *devm_otg_ulpi_create(struct device *dev,
 						   struct usb_phy_io_ops *ops,
 						   unsigned int flags)
Signature · 1 line
2.48.1
#1 lore raw
Quoted 5 lines · On 2/23/25 7:06 PM, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

otg_ulpi_create() has been unused since 2022's commit 8ca79aaad8be ("ARM: pxa: remove unused pxa3xx-ulpi")

Quoted 7 lines

Remove it.

The devm_ variant is still used.

---
 drivers/usb/phy/phy-ulpi.c | 23 -----------------------

Probably s/olpi/ulpi/ in the subject then?

Quoted 3 lines
 include/linux/usb/ulpi.h   |  9 ---------
 2 files changed, 32 deletions(-)

[...]

MBR, Sergey

#2 lore raw
Quoted 9 lines · * Sergey Shtylyov ([email protected]) wrote:
Quoted 7 lines · On 2/23/25 7:06 PM, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

otg_ulpi_create() has been unused since 2022's commit 8ca79aaad8be ("ARM: pxa: remove unused pxa3xx-ulpi")

Remove it.

Quoted 7 lines
Quoted 5 lines

The devm_ variant is still used.

---
 drivers/usb/phy/phy-ulpi.c | 23 -----------------------

Probably s/olpi/ulpi/ in the subject then?

Oops, thanks!

Dave

Quoted 5 lines
Quoted 3 lines
 include/linux/usb/ulpi.h   |  9 ---------
 2 files changed, 32 deletions(-)

[...]

MBR, Sergey

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/